From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#32477: 27.0.50; `=` burps on bignums when compiled Date: Mon, 20 Aug 2018 20:44:18 +0000 Message-ID: References: <86o9dxg6nq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1534797992 24523 195.159.176.226 (20 Aug 2018 20:46:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2018 20:46:32 +0000 (UTC) Cc: 32477@debbugs.gnu.org To: andrewjmoreton@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 20 22:46:28 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frr4B-0006B9-2U for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Aug 2018 22:46:23 +0200 Original-Received: from localhost ([::1]:49261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frr6H-00057t-DL for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Aug 2018 16:48:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frr31-000283-HX for bug-gnu-emacs@gnu.org; Mon, 20 Aug 2018 16:45:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frr2x-0008EO-Ee for bug-gnu-emacs@gnu.org; Mon, 20 Aug 2018 16:45:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50929) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frr2u-0008Ci-FN for bug-gnu-emacs@gnu.org; Mon, 20 Aug 2018 16:45:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1frr2s-00039E-Lj for bug-gnu-emacs@gnu.org; Mon, 20 Aug 2018 16:45:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Aug 2018 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32477 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32477-submit@debbugs.gnu.org id=B32477.153479790112082 (code B ref 32477); Mon, 20 Aug 2018 20:45:02 +0000 Original-Received: (at 32477) by debbugs.gnu.org; 20 Aug 2018 20:45:01 +0000 Original-Received: from localhost ([127.0.0.1]:55947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frr2r-00038o-KD for submit@debbugs.gnu.org; Mon, 20 Aug 2018 16:45:01 -0400 Original-Received: from mail-lf1-f46.google.com ([209.85.167.46]:34666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frr2q-00038c-ML for 32477@debbugs.gnu.org; Mon, 20 Aug 2018 16:45:01 -0400 Original-Received: by mail-lf1-f46.google.com with SMTP id g9-v6so6680177lfh.1 for <32477@debbugs.gnu.org>; Mon, 20 Aug 2018 13:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VaJqpORR/wE4IgLKMo2pnuWDeeUHYNvqoFG4H7LqW28=; b=FHHjQTswGK8S+Oa3qZ1cS/ARPkdZeScFO5JUB8pfDG4wTjGdYkwp37MJ7j1XyJBTPE OBUOKqvOkK8AgCUojJTEbnbzE/4o8Aoj8s+DDQdHsGSRkExhbtzd9PTHt0+4U6qU1A5u aQ6Lzi2hYDtDZgYOM9QQlk5rcuQMRQEhIkC5d543ldSmbPEAM/fJHwfcjsxd24NJN62R WAK3GhQeh9igNBAQpjhp/KeuiwMGSrZ/t9sP+bQRvViXYi54oJ502u1kt/SkTpd1+p+P vK0DidREnhh7N70VcG/OhUmGvnWgXc35jK51dNOGHCpKpgjFNUKeTkol8Sxu1jg8lANj 6sQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VaJqpORR/wE4IgLKMo2pnuWDeeUHYNvqoFG4H7LqW28=; b=ZTyo5booZpMMPvJZlfsjixm9hYfD9i2kzGG4UGrhx+yImmzS0wjqN2fJHbQh9AKBbX UCCudwlSAJRUmQLVQttkqn/VTWbrHSZ2OIQBzjz9afpA+TUUW3qv2C8AcVSOg7YP0pqO FQa0VhFUpehK5QnvaI8b+R5uWhlITZGysus6eRd4dzTcwc2LZ7Oyg1ndeDgLc2tF4ykv AUWRklod1qaqgc0B+piUlNSKexRVvYxOI6EoxL/lFkl1SrdrG7SzXatXHibShJPwBGXb gOjs1ooYkLTrr1NfyGaMWdU6FV3ysBKL1dRX6cAdohoXea72JCUGXyCcDev2qGqo/VBM ND/A== X-Gm-Message-State: AOUpUlF3WIK+immcDnqspnJ9xVL8ti6iBqmb3VngM0iS5F2Ge4GuKB20 8Zb7kj/ntAWHUOkPaLZuRPG5g4judge82igXl9w= X-Google-Smtp-Source: AA+uWPzQgdlPsDigUc+gDhgRQ5r1l8wxqvOk2A9+bwWFcZ8b7fa7RVy1mubrE2fjmpaojSSTKafDJYr8ibAo/wI3mLU= X-Received: by 2002:a19:c20f:: with SMTP id l15-v6mr10290532lfc.21.1534797894948; Mon, 20 Aug 2018 13:44:54 -0700 (PDT) In-Reply-To: <86o9dxg6nq.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149624 Archived-At: On Mon, Aug 20, 2018 at 1:38 AM Andy Moreton wrote: > On Sun 19 Aug 2018, Stefan Monnier wrote: > > > Package: Emacs > > Version: 27.0.50 > > > > If you try > > > > M-: (funcall (lambda (x) (= x x)) (expt 2 64)) RET > > > > you'll unsurprisingly get t as result. Yay! But if you try > > > > M-: (funcall (byte-compile '(lambda (x) (= x x))) (expt 2 64)) RET > > > > you should be prompted with an error stating that this largish number is > > not a number-or-marker. This error occurs for example when loading > > elpa/packages/xelb/xcb-types.elc. > > I can reproduce this on a 64bit build on Windows. The following lightly > tested patch appears to work: > > diff --git a/src/bytecode.c b/src/bytecode.c > index b27fa7c5c6..155f714a56 100644 > --- a/src/bytecode.c > +++ b/src/bytecode.c > @@ -990,8 +990,8 @@ exec_byte_code (Lisp_Object bytestr, Lisp_Object vector, Lisp_Object maxdepth, > TOP = arithcompare (v1, v2, ARITH_EQUAL); > else > { > - CHECK_FIXNUM_OR_FLOAT_COERCE_MARKER (v1); > - CHECK_FIXNUM_OR_FLOAT_COERCE_MARKER (v2); > + CHECK_INTEGER_COERCE_MARKER (v1); > + CHECK_INTEGER_COERCE_MARKER (v2); > TOP = EQ (v1, v2) ? Qt : Qnil; > } > NEXT; > (funcall (byte-compile '(lambda (x y) (= (expt 2 x) (expt 2 y)))) 64 64) returns nil with this patch: we want `eql', not `eq'. (I think we should simply call arithcompare in all cases, but we can add a FIXNUMP (v1) && FIXNUMP (v2) condition, too).