From: Pip Cet <pipcet@gmail.com>
To: Erik Hetzner <egh@e6h.org>
Cc: 46974@debbugs.gnu.org, Andrea Corallo <akrl@sdf.org>
Subject: bug#46974: 28.0.50; [nativecomp] wrong-type-argument number-or-marker-p with native compiled code only
Date: Sat, 6 Mar 2021 20:28:19 +0000 [thread overview]
Message-ID: <CAOqdjBd80tr+Hm1i6vwaH3sACU5_yNmbT-O1bs2U+PG7Yz929w@mail.gmail.com> (raw)
In-Reply-To: <6043d628.1c69fb81.dc872.e8e3@mx.google.com>
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
On Sat, Mar 6, 2021 at 7:22 PM Erik Hetzner <egh@e6h.org> wrote:
> Hi all,
>
> There is a difference between native compiled code and non-native
> compiled code that the wanderlust community has surfaced. It is not
> clear to me why this is happening.
Can you try this patch? It might help, or not, but it should be
applied in any case. Cc'ing Andrea.
Pip
[-- Attachment #2: bug46974.diff --]
[-- Type: text/x-patch, Size: 919 bytes --]
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 4a418c1aadebc..8d65d6c1c65e3 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -3283,11 +3283,13 @@ comp-call-optim-func
do (comp-loop-insn-in-block b
(pcase insn
(`(set ,lval (callref funcall ,f . ,rest))
- (when-let ((new-form (comp-call-optim-form-call
+ (when-let ((ok (comp-cstr-imm-vld-p f))
+ (new-form (comp-call-optim-form-call
(comp-cstr-imm f) rest)))
(setf insn `(set ,lval ,new-form))))
(`(callref funcall ,f . ,rest)
- (when-let ((new-form (comp-call-optim-form-call
+ (when-let ((ok (comp-cstr-imm-vld-p f))
+ (new-form (comp-call-optim-form-call
(comp-cstr-imm f) rest)))
(setf insn new-form)))))))
next prev parent reply other threads:[~2021-03-06 20:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 19:21 bug#46974: 28.0.50; [nativecomp] wrong-type-argument number-or-marker-p with native compiled code only Erik Hetzner
2021-03-06 20:28 ` Pip Cet [this message]
2021-03-06 20:49 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 3:24 ` Erik Hetzner
2021-03-07 6:30 ` Pip Cet
2021-03-07 19:41 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 20:13 ` Pip Cet
2021-03-07 20:33 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 20:43 ` Pip Cet
2021-03-07 20:44 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBd80tr+Hm1i6vwaH3sACU5_yNmbT-O1bs2U+PG7Yz929w@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=46974@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=egh@e6h.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).