From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#46834: 28.0.50; byte-compiling the standard counter closure fails Date: Mon, 1 Mar 2021 17:13:34 +0000 Message-ID: References: <8735xf8154.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4847"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46834@debbugs.gnu.org, Lars Ingebrigtsen To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 18:15:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGm8b-00018C-6s for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 18:15:17 +0100 Original-Received: from localhost ([::1]:54402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGm8a-00079r-8U for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 12:15:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGm8P-00078I-9B for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 12:15:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGm8M-0007Ii-74 for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 12:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGm8M-0007dQ-13 for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 12:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 17:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46834 X-GNU-PR-Package: emacs Original-Received: via spool by 46834-submit@debbugs.gnu.org id=B46834.161461885829282 (code B ref 46834); Mon, 01 Mar 2021 17:15:01 +0000 Original-Received: (at 46834) by debbugs.gnu.org; 1 Mar 2021 17:14:18 +0000 Original-Received: from localhost ([127.0.0.1]:50683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGm7e-0007cE-6a for submit@debbugs.gnu.org; Mon, 01 Mar 2021 12:14:18 -0500 Original-Received: from mail-ot1-f44.google.com ([209.85.210.44]:36301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGm7c-0007c1-Ky for 46834@debbugs.gnu.org; Mon, 01 Mar 2021 12:14:17 -0500 Original-Received: by mail-ot1-f44.google.com with SMTP id 105so17200588otd.3 for <46834@debbugs.gnu.org>; Mon, 01 Mar 2021 09:14:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HBZRW8rLt5wH5MrAo/uSFlq6rLY1y1QzZL/zgX9ZqqE=; b=RQPY0pY4vOcjYPxkTyOmmKmKGWmeuYfqePe/gPPxcGqGbomGUzZ/ue2jTOLLz6ekQp P1TAjRfFZ91wxZ2//+ahwkpyhiA3LvvUAsJTgZgk0jrry/dPg/aCB0kBXnHDxmhpdEqp 2KNWes+s6oeQzuBxKRY1OkTkwdUYsYy4LU5Q3X9Kzh+6FSPuozeeo3ViBiONKS5F0Wkn EPS8kr0lwwknbubl4U99nL310TDEkioyAhtlXO4ODsgf30apNqR0THpyXbq1c6PsU+Tt mzO1/T5C4biKeSuzCXgCWSOIsBBkvcNaY+VPBa6bWi1fem+nW/Fgap40pzxJDJh96rNb EU0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HBZRW8rLt5wH5MrAo/uSFlq6rLY1y1QzZL/zgX9ZqqE=; b=drHt+aeXHcHqOYNxoyCzoRoAZiExe+8NYiPu6RXsmc1B4cosvYnWHD45rJiOzvLBB/ 5OgPJikwiSgo3ADF01AEKIQpwhMzHS8Es47k4foF021CME+tvXg3hWDEc1sEIAX59c5G 31MD0gi1P7kQfUNO6EOi1eeIl0vM3w4IpMDzYSkS9o8TEsjsPleOfFHTP5RBmWoT9N6R txm+eMPvT3pEuL9e+Ghk3yT3zVZwg3wIubiyKofPl78mQehZlZ3YOch9aAE1fgck+M+G x0BgqSDXRpQT6mehc1kyAK155VVF/5XfurMuJnGv/eL0rkR0PmC7jHKcvCgtm1tZYuAE tgzg== X-Gm-Message-State: AOAM531U8cNXnP7GE1mLiV1d5fsUpth/czy9CFAEUQDh46sYNFETrag/ zzL8+QfYzAeafg+X5A0/MCnI4bNjTdMivs++8T0= X-Google-Smtp-Source: ABdhPJyHSvwdVoBA1XsEWvqx7epq4wvMrNMcU7vh81njJayR/RKSvAQoXX1OvkS3WXfF3/fbe8MS/ueFXBYlcIbWSws= X-Received: by 2002:a9d:131:: with SMTP id 46mr14214508otu.287.1614618850977; Mon, 01 Mar 2021 09:14:10 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201133 Archived-At: On Mon, Mar 1, 2021 at 5:01 PM Stefan Monnier wrote: > >> > That said, the comment in byte-compile--reify-function is incorrect: > >> [ I don't see which comment you're referring to. ] > > The docstring, sorry. It says the return value evaluates to FUN, which > > is incorrect (but, IMHO at least, this behavior is desirable and > > consistent, at least, with the way byte-compile changes string > > identities). > > Ah, that. Yes, we could clarify that it's not 100% equivalent, but it's > an internal function anyway. The doc there is only intended to explain > what the function is supposed to do. I think we should, generally, document that bytecode compilation (and native compilation soon) take a snapshot of the function as it stands at compilation time. You can't modify the lambda list you turned into a native function and expect the native function to change. > > I agree, it is repulsive. I wasn't going to mention it for that reason > > :-) (Also for the reason that I wasn't sure whether anything would > > break out of the cl-symbol-macrolet jail (no luck so far...)) > > I'm not quite sure it'll always get it right, indeed, tho I think > it should. Haven't found a way to break out yet, but this detects that we're in c-s-m, at least: (let ((cell (cons nil nil))) (cl-symbol-macrolet ((x (car cell))) (condition-case error (funcall #'setq x 5) (error (message "I know I'm in a c-s-m jail!"))))) And, yes, that relies on another bug... Pip