From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36403: 27.0.50; Trivial image.c bugs Date: Sun, 28 Jul 2019 14:50:47 +0000 Message-ID: References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="21072"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36403@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 16:52:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrkX4-0005OY-FI for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 16:52:18 +0200 Original-Received: from localhost ([::1]:45506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrkX3-0007UJ-Gw for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 10:52:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48580) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrkWp-0007S8-Od for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrkWo-0007Hc-NM for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38147) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrkWo-0007Gm-KD for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrkWo-0004Z0-Hy for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs Original-Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.156432549217480 (code B ref 36403); Sun, 28 Jul 2019 14:52:02 +0000 Original-Received: (at 36403) by debbugs.gnu.org; 28 Jul 2019 14:51:32 +0000 Original-Received: from localhost ([127.0.0.1]:46964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrkWJ-0004Xs-Qh for submit@debbugs.gnu.org; Sun, 28 Jul 2019 10:51:32 -0400 Original-Received: from mail-oi1-f181.google.com ([209.85.167.181]:41423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrkWI-0004Xd-38 for 36403@debbugs.gnu.org; Sun, 28 Jul 2019 10:51:30 -0400 Original-Received: by mail-oi1-f181.google.com with SMTP id g7so43546481oia.8 for <36403@debbugs.gnu.org>; Sun, 28 Jul 2019 07:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AaVQutwkgaH+1iKgi78YlgThg96A7UDol8B1jjcTgmg=; b=TwxzjJVymypq7AgvvsnqRN6cxFo++MQX/Ep8jcVHdQthXW6HJTnamKkc5ldqS1OlcC GS3h7rGm1Unc9P1o2SpiMD1TAL5s9pP4EI2K6aLn0cVh2TQzEZtwDFefMLij0xgSPy/y qRIrxZspr+VAPNpNpxI3laXX52Gi0sr9CdGD8n37Dh/ooBMjC7tpBIUYQoaorMDo5hOw Qn8sxg9Yg1YwziIDgPEH1f0QXAIOkH7bwIicGZQ5Y2Io2cSGdQSq7YF8l69mbr2N51q7 GB8s7YV5ad+CI1dboSpFHx4QM4I/UTMiocsyuaVg/dxteSO9hN6RPQ7Wc3+/KTFGKHwf mrGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AaVQutwkgaH+1iKgi78YlgThg96A7UDol8B1jjcTgmg=; b=J/py5KYXOxQPwx/19xt8waIPPWPO8G82OwUbLlDRjOnc8dHYY+CqGA67rOrbQ+jH5u Ezv0EGy6T6wmHHNrBIT0VOSr1UXTGlYhV0pgEnqY5VQtBEu8eSD/JQ+MDVAzQeFDqSKd 9FZ0qqK0fQ6j+wxpPSbgICr8v+W3hYpIgqINMxdWzCGEraUHlz12Ad7rStqCFEAOdZcf WC9LfEUr9xKUfzOjlMnuRJ5Ud2kVPiCN7G1Zg4wj5S6t8LnY4lZBBzCKz+aBQ6j3YO5k vxjA1k/ofrm51GH4T4N7oq9vJhQi6/XOP8FXvl3hIFDwIQMSSb/OV89V84XCAMLsvsaM LPQA== X-Gm-Message-State: APjAAAUqhp3/RDj01XGhHItFsKzfXQSJxeXjX1yS9XbaPAvCjQuU3iA/ M1CzYQu1Rf5STmBFP3n6LYADMg+wRrkUJEqNLlDQww== X-Google-Smtp-Source: APXvYqyhliUley7FDuzBFjQo/HawfKMzmjiCyTjxYmfnMwsBI/aBYnMj7d5ZwQWqf/vfsjcSAWe3v1J/o4JtfQUYbqc= X-Received: by 2002:a05:6808:313:: with SMTP id i19mr50018878oie.30.1564325484167; Sun, 28 Jul 2019 07:51:24 -0700 (PDT) In-Reply-To: <83tvb9mggh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163965 Archived-At: On Fri, Jul 26, 2019 at 6:56 AM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Mon, 22 Jul 2019 02:55:50 +0000 > > Cc: 36403@debbugs.gnu.org > > > > On Fri, Jun 28, 2019 at 7:53 PM Eli Zaretskii wrote: > > > > Attached patch has tests and fixes. > > > > > > Thanks. Let's wait for a few days to let others comment. > > > > Rebased patch attached. > > Thanks. > > Now that I applied this and looked into the results and the code, I > have a few questions/comments. Sorry I didn't see this earlier. No problem at all, and thank you, as always, for your thoughtful comments! > In your bug report, you say, among other things: > > > (insert-image `(image :dummy :type :type xbm :height 1 :width 1 :data > > ,(bool-vector t))) > > > > produces an error. It should arguably behave the same as > > > > (insert-image `(image :dummy :dummy :type xbm :height 1 :width 1 :data > > ,(bool-vector t))) > > Can you explain why these two are equivalent? The ":dummy" property should be ignored, whether its value is ":dummy" or ":type"; previously, we used the first occurence of :type even if it was at an odd offset in the plist. > > (equal_lists): Introduce. > > (search_image_cache): Use `equal_lists'. > > I don't think I understand why we need this new function. Can you explain? IIRC, Fequal throwing a signal at this point caused a livelock, so we needed a stricter check. I'll look into it again to see whether there's a better alternative. Thanks again!