From: Pip Cet <pipcet@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rms@gnu.org, 36304@debbugs.gnu.org
Subject: bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors
Date: Sat, 22 Jun 2019 12:13:20 +0000 [thread overview]
Message-ID: <CAOqdjBcxoq7vt7gPTq7cQhUKcKLAcscr0831neer4kgJCLcXBw@mail.gmail.com> (raw)
In-Reply-To: <83fto1onky.fsf@gnu.org>
On Sat, Jun 22, 2019 at 11:40 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Pip Cet <pipcet@gmail.com>
> > Date: Sat, 22 Jun 2019 11:23:35 +0000
> > Cc: 36304@debbugs.gnu.org
> >
> > Here's a patch. I've read the documentation and it appears already to
> > have been updated by someone so it no longer links to the X
> > documentation.
> >
> > * src/xterm.c (x_parse_color): Translate #RGB notation to rgb:R/G/B
> > notation, which X handles slightly differently.
>
> Can this change be limited to xterm.c alone?
It'd leave us inconsistently still using the X standard in some
places, but at first glance they appear to be documented to use the X
standard, so maybe that's not wrong.
> I think we assume this color handling also in xfaces.c
Only via tty-color-standard-values, as far as I can see.
> and in lisp/term/tty-colors.el (and perhaps elsewhere, where TTY colors are used/defined).
tty-color-standard-values is documented to use the X convention, and
it does. tty-color-desc is documented to return approximate results,
and it does; and it's only used for text terminals, right?
> There's also lisp/color.el.
Anything in particular? As far as I can tell, the functions work
properly using the new convention with this patch, although I am sure
there are places that fail to deal with the 65280-as-maximum
convention that nsfns.m uses.
> Am I missing something?
I don't think so, but I don't see anything, so far, that needs
changing. I'm almost certain that some more places will need changing,
but how do we find them?
next prev parent reply other threads:[~2019-06-22 12:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 11:22 bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors Pip Cet
2019-06-21 1:54 ` Richard Stallman
2019-06-22 11:23 ` Pip Cet
2019-06-22 11:40 ` Eli Zaretskii
2019-06-22 12:13 ` Pip Cet [this message]
2019-06-22 12:35 ` Eli Zaretskii
2019-06-22 14:41 ` Pip Cet
2019-06-22 15:05 ` Eli Zaretskii
2019-06-22 15:33 ` Pip Cet
2019-06-28 8:12 ` Eli Zaretskii
2019-06-28 9:28 ` Pip Cet
2019-06-28 9:42 ` Robert Pluim
2019-06-28 10:00 ` Pip Cet
2019-06-28 13:07 ` Andy Moreton
2019-06-28 12:33 ` Eli Zaretskii
2019-06-28 14:34 ` Pip Cet
2019-06-28 19:54 ` Eli Zaretskii
2019-06-28 21:27 ` Andy Moreton
2019-07-22 2:46 ` Pip Cet
2019-07-27 11:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBcxoq7vt7gPTq7cQhUKcKLAcscr0831neer4kgJCLcXBw@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=36304@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).