From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#46670: 28.0.50; [feature/native-comp] possible miscompilation affecting lsp-mode Date: Wed, 24 Feb 2021 07:00:22 +0000 Message-ID: References: <87a6ry46uc.fsf@collares.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000d7b12005bc0f9856" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26712"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46670@debbugs.gnu.org, Mauricio Collares To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 24 08:02:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEoBf-0006qP-7W for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Feb 2021 08:02:19 +0100 Original-Received: from localhost ([::1]:47348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEoBd-000162-Nv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Feb 2021 02:02:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEoBP-00015n-5d for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2021 02:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEoBN-00032l-RQ for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2021 02:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lEoBN-0006ke-PA for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2021 02:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2021 07:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46670 X-GNU-PR-Package: emacs Original-Received: via spool by 46670-submit@debbugs.gnu.org id=B46670.161415006825891 (code B ref 46670); Wed, 24 Feb 2021 07:02:01 +0000 Original-Received: (at 46670) by debbugs.gnu.org; 24 Feb 2021 07:01:08 +0000 Original-Received: from localhost ([127.0.0.1]:33171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEoAV-0006jW-Qx for submit@debbugs.gnu.org; Wed, 24 Feb 2021 02:01:08 -0500 Original-Received: from mail-oi1-f177.google.com ([209.85.167.177]:33976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEoAS-0006iu-3t for 46670@debbugs.gnu.org; Wed, 24 Feb 2021 02:01:06 -0500 Original-Received: by mail-oi1-f177.google.com with SMTP id w69so1472013oif.1 for <46670@debbugs.gnu.org>; Tue, 23 Feb 2021 23:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mGPvdUdi9J3vmPX/bIxDtos8SdMZZ7HNYylFkXRS+6c=; b=pif3mWdLpqh+jLeXM69v4i0BGdLguDZYUtGj2DaSo0THxWoOCSsHtuyhbJHxxSAD0H c8zOFXtyVSopG/a3mnv6FVRU/FMdasyq6VMtmgUWJAZSDoedJwQZYKhmzskjiU/Xnht3 3Z7m02VhH5P91ZlW8jEpVI5VRriDx35Yn8GMAtz+PJU2XM4cY8P8f0x97ohOT6gi0WcX FLTiywargLxm+wj+rZgn9EBM857OhbKY2srFO2zj5QtnizM13TQCL9cTYaV9V7IC0AyD /HqWCWOOm588cZ52wjY2LAVvUjPyoJwSgRedfgUsHsPGwXjkTumYsGnAp9YvvPdNPtoN zNbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mGPvdUdi9J3vmPX/bIxDtos8SdMZZ7HNYylFkXRS+6c=; b=Rxn46lvZLm+EFxrdjjoxQv40Wbk2PvTReDiaO80zC+e9D2TtvR/i7NaHoMzQcEEJvA wDBSc/4fKWr+1oPIT8V0QsEPm3xWY8xxe1PloyVtbW54C/3R07jtSQ3DazC62yczr6vg mecqmsGsLM7bfWulHhxzn67CYwYyrtkVrz+BlhE4Igw+gd096TBhAaVln09Gl6oajx7V ebhGB2zsPncfj7//Or7ot4GhP0/y9S/eciFF+ZmesXgzxOKdMmnl+KGkb/6X3UOVmXA2 +IGM5kDu8YAqABI3jMuciP331W8X38g8L+5Hd8agrci1nsD02XDsbwlJMLFtJYQVLNQu sqRQ== X-Gm-Message-State: AOAM532RafM+N7yn1WUdHBMdXNoffdjhxzXWvN3FMI2Hp7rmjZiMoKO8 RVC50cbzbILDflEkaNy2n8QR7AYfPTazftdDzkA= X-Google-Smtp-Source: ABdhPJy/PElucWV6/SM8r2FtPvv6wnk51Oyy4PpU7h+uQJj4LgLa78r8B0dpM1Ss0z6s3HIBgz+voNeljwyJfZBSE0A= X-Received: by 2002:a05:6808:8e1:: with SMTP id d1mr1849669oic.122.1614150058349; Tue, 23 Feb 2021 23:00:58 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200704 Archived-At: --000000000000d7b12005bc0f9856 Content-Type: text/plain; charset="UTF-8" Hello Andrea, by the way, I'm mostly still pursuing it because it keeps flushing out bugs in comp.el :-) I'm attaching another one, though I'm not sure the bug in question can actually be triggered without modifying the byte compiler. On Tue, Feb 23, 2021 at 10:55 PM Andrea Corallo wrote: > Pip Cet writes: > >> >> > We don't have to, let's just not emit an assume about a variable that > >> > we just introduced and that's never read? > >> > >> We disagree :) > > > > We can disagree about the "let's" part (and should, of course), but we > > should agree about the "we don't have to" part, because that's a > > matter of fact, not opinion. > > This new mvar *is* used, actually by an assume. I said it was never read, which I agree is more correct. > And the assume in > discussion is targetting a live variable that will be used by functional > code so I really see no scandal here. Only on one side of the assume. The other side holds a new "temporary" variable which is assumed to be equal to something that it isn't actually equal to, and that seems very scandalous to me. > >> As the byte compiler does not care about propagating types and values it > >> can just clobber the variable, here we aim for more so we need it to > >> keep it live till the assume. > > > > If we decide the variable needs to be kept live, the byte compiler > > should keep it live, not us. > > Again no, any pass in the compiler must have the right to create new > temporaries for whichever purpose it wants, and indeed we can't expect I agree with that part, by the way. We should, at some point in the future when we need it, add the ability to introduce temporary variables (and remove them), in a clean, well-considered fashion. At present, we don't need it, we lack the ability to remove such variables, and I'm afraid the last parts can be disputed, too. --000000000000d7b12005bc0f9856 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-ICE-when-compiling-an-explicit-call-to-single-ar.patch" Content-Disposition: attachment; filename="0001-Fix-ICE-when-compiling-an-explicit-call-to-single-ar.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_klj38la80 RnJvbSBmNzVlODc0ZDUwYTJlMjJhOWZmOWRmMmZjYmZiZjVlNzRkNmJiZmY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBXZWQs IDI0IEZlYiAyMDIxIDA2OjU4OjI0ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRml4IElDRSB3aGVu IGNvbXBpbGluZyBhbiBleHBsaWNpdCBjYWxsIHRvIHNpbmdsZS1hcmd1bWVudAogYC0nCgoqIGxp c3AvZW1hY3MtbGlzcC9jb21wLmVsIChjb21wLWZ3cHJvcC1jYWxsKTogSGFuZGxlCm5lZ2F0aW9u IGFzIHdlbGwgYXMgc3VidHJhY3Rpb24uCi0tLQogbGlzcC9lbWFjcy1saXNwL2NvbXAuZWwgfCAy ICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS9saXNwL2VtYWNzLWxpc3AvY29tcC5lbCBiL2xpc3AvZW1hY3MtbGlzcC9jb21wLmVs CmluZGV4IDYwYzA0MDkyNmU1NGMuLjI5ODA2MDViZjg4MDQgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1h Y3MtbGlzcC9jb21wLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9jb21wLmVsCkBAIC0zMDQwLDcg KzMwNDAsNyBAQCBjb21wLWZ3cHJvcC1jYWxsCiAgICAgICAgICAgICAgIChjb21wLW12YXItbmVn IGx2YWwpIChjb21wLWNzdHItbmVnIGNzdHIpKSkpCiAgICAgKGNsLWNhc2UgZgogICAgICAgKCsg KGNvbXAtY3N0ci1hZGQgbHZhbCBhcmdzKSkKLSAgICAgICgtIChjb21wLWNzdHItc3ViIGx2YWwg YXJncykpCisgICAgICAoLSAoaWYgKGNkciBhcmdzKSAoY29tcC1jc3RyLXN1YiBsdmFsIGFyZ3Mp KSkKICAgICAgICgxKyAoY29tcC1jc3RyLWFkZCBsdmFsIGAoLChjYXIgYXJncykgLGNvbXAtY3N0 ci1vbmUpKSkKICAgICAgICgxLSAoY29tcC1jc3RyLXN1YiBsdmFsIGAoLChjYXIgYXJncykgLGNv bXAtY3N0ci1vbmUpKSkpKSkKIAotLSAKMi4zMC4wCgo= --000000000000d7b12005bc0f9856--