From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36649: 27.0.50; pure space and pdumper Date: Sun, 21 Jul 2019 14:36:41 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000741940058e31e5ff" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="167003"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36649@debbugs.gnu.org, Paul Eggert To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 21 16:38:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpCyV-000hKl-77 for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2019 16:38:07 +0200 Original-Received: from localhost ([::1]:56234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpCyU-000499-2h for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2019 10:38:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34838) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpCyR-00048o-24 for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 10:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpCyQ-0007Sf-1v for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 10:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpCyP-0007SX-SK for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 10:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hpCyP-0001JA-Oc for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 10:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jul 2019 14:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36649 X-GNU-PR-Package: emacs Original-Received: via spool by 36649-submit@debbugs.gnu.org id=B36649.15637198454982 (code B ref 36649); Sun, 21 Jul 2019 14:38:01 +0000 Original-Received: (at 36649) by debbugs.gnu.org; 21 Jul 2019 14:37:25 +0000 Original-Received: from localhost ([127.0.0.1]:59256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpCxp-0001II-5o for submit@debbugs.gnu.org; Sun, 21 Jul 2019 10:37:25 -0400 Original-Received: from mail-oi1-f170.google.com ([209.85.167.170]:44380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpCxn-0001I5-Av for 36649@debbugs.gnu.org; Sun, 21 Jul 2019 10:37:23 -0400 Original-Received: by mail-oi1-f170.google.com with SMTP id e189so27675302oib.11 for <36649@debbugs.gnu.org>; Sun, 21 Jul 2019 07:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=98XvsXihjWDyCXP1fxjvhJTEFQBvjRWO1UUsNpa/zwM=; b=QOxrUWNMBVBFbhlGEVDqkAYxxzwWz+z4hJxyXwVz5BkPjdeyWNTY81I1q6vfFQhVp7 u0NTU35ENmoPHERrzsfKSHHwPvK4jr0rI3TYaSc4rwZYhw5ON0YQC2+vCfIkkMoMp/GY 97gU5vn+8KhEPO943zn/zfSLVRHkEaaWI8bSr9NzuirHhAfBZRqicFNnCD+AAi7ygXRX BDGbmTWqj1HyAU+5SYotJY7KAj6ARhXTM01Fv4L7+sBzyCjonSBJOZZQA8bkFbceic/z biAhUkECs+EGeNu5//pBFKQA09ree60R4NkXxyZq4JjWLGLBno34Dhex3O1EqMYLRPNt /mbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=98XvsXihjWDyCXP1fxjvhJTEFQBvjRWO1UUsNpa/zwM=; b=hnbLMaUYPTnir9HfDiEcEd2UyVacbvb+pYQ12S4hrJTxS2U9y4pdKIJcAc9cMnq/b2 m/yod8QbZeePAcLZDshNE2iLpEAjguGYhQMtoHwpQPhvzk7fCF/BwlUJF+3ZdUoPVQpx JZ1D+4rOD/2QsAS1IBzcXV4hjI3o1amZ1cbkXZRvZWnychu9KvuvbuHPV5Fvagf9KQZU Kx/wPERGLGbXafyd/tVzKGjsmIsfLGlct9FjmmW37TRgQvXhHjPfhZd33swN/NGB8gy6 JqtLmqqeqT0/heSuU9yVngtKGQV/wGN7+nC+p+CZpfHt24OVSMshNRfLPKMe27ldjsat 2q8Q== X-Gm-Message-State: APjAAAWYFPU3bZ77bwTrMZHsqQRnRe0R4HXOjNjwbSGYWuy3Bh3sWMbU 6PkoYj4Ki7sx4U4a1xV/Enxxliprk35bNG96p8Y= X-Google-Smtp-Source: APXvYqyCCJFDpj/GWg659s9hFuZvVOle6wNvQY+PXgP+BClnuuV9+ln0QBUeLqAXQ84kPpyqVfg/c4YcquQps20S/FQ= X-Received: by 2002:a05:6808:313:: with SMTP id i19mr31018355oie.30.1563719837675; Sun, 21 Jul 2019 07:37:17 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163522 Archived-At: --000000000000741940058e31e5ff Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jul 21, 2019 at 1:44 PM Robert Pluim wrote: > >>>>> On Sun, 21 Jul 2019 12:53:21 +0000, Pip Cet said= : > Pip> I think we should do (1) for now, since it simplifies the code e= nough > Pip> to introduce immutable objects "soon"; but until that time, we w= aste > Pip> more space on duplicate objects that we no longer know to be > Pip> immutable, so cannot merge. > > Pip> I'm attaching a first patch that removes pure space, pinned symb= ols, > Pip> pinned objects, but keeps Fpurecopy (for hash consing), and does= n't > Pip> touch the Lisp codebase. > > This doesn=CA=BCt build for me on macOS. After adjusting the parameters t= o > the call to make_hash_table in image.c, it crashes when dumping: Thanks for testing! Indeed, I'd only verified it builds here. My first guess is there's a symbol in the obarray which used to be pinned, but is now collected before it is interned. Can you try with the attached patch relative to the one I'd sent before, and see what the output is? --000000000000741940058e31e5ff Content-Type: text/x-patch; charset="US-ASCII"; name="0001-debugging-changes.patch" Content-Disposition: attachment; filename="0001-debugging-changes.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jyd2e5nt0 RnJvbSA0NWU4ZjdiZGJiYTQzZjYyN2IzOTk1NzM2NmI3MGRjYmRjNjU3NWE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBTdW4s IDIxIEp1bCAyMDE5IDE0OjM1OjA0ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gZGVidWdnaW5nIGNo YW5nZXMKCi0tLQogc3JjL2FsbG9jLmMgfCAzICsrLQogc3JjL2ltYWdlLmMgfCAyICstCiAyIGZp bGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9zcmMvYWxsb2MuYyBiL3NyYy9hbGxvYy5jCmluZGV4IGRmOGIxY2FmNGUuLjFiNTVhZDhjYWIg MTAwNjQ0Ci0tLSBhL3NyYy9hbGxvYy5jCisrKyBiL3NyYy9hbGxvYy5jCkBAIC02NDI4LDYgKzY0 MjgsNyBAQCBzd2VlcF9zeW1ib2xzICh2b2lkKQogICAgICAgICB7CiAgICAgICAgICAgaWYgKCFz eW0tPnUucy5nY21hcmtiaXQpCiAgICAgICAgICAgICB7CisJICAgICAgZnByaW50ZiAoc3RkZXJy LCAiZnJlZWluZyBzeW1ib2wgJXNcbiIsIFNEQVRBIChzeW0tPnUucy5uYW1lKSk7CiAgICAgICAg ICAgICAgIGlmIChzeW0tPnUucy5yZWRpcmVjdCA9PSBTWU1CT0xfTE9DQUxJWkVEKQogCQl7CiAg ICAgICAgICAgICAgICAgICB4ZnJlZSAoU1lNQk9MX0JMViAoc3ltKSk7CkBAIC02NTE5LDEyICs2 NTIwLDEyIEBAIHN3ZWVwX2J1ZmZlcnMgKHZvaWQpCiBzdGF0aWMgdm9pZAogZ2Nfc3dlZXAgKHZv aWQpCiB7CisgIHN3ZWVwX3N5bWJvbHMgKCk7CiAgIHN3ZWVwX3N0cmluZ3MgKCk7CiAgIGNoZWNr X3N0cmluZ19ieXRlcyAoIW5vbmludGVyYWN0aXZlKTsKICAgc3dlZXBfY29uc2VzICgpOwogICBz d2VlcF9mbG9hdHMgKCk7CiAgIHN3ZWVwX2ludGVydmFscyAoKTsKLSAgc3dlZXBfc3ltYm9scyAo KTsKICAgc3dlZXBfYnVmZmVycyAoKTsKICAgc3dlZXBfdmVjdG9ycyAoKTsKICAgcGR1bXBlcl9j bGVhcl9tYXJrcyAoKTsKZGlmZiAtLWdpdCBhL3NyYy9pbWFnZS5jIGIvc3JjL2ltYWdlLmMKaW5k ZXggMzU1Yzg0OTQ5MS4uYjIxZGZmMzRkNCAxMDA2NDQKLS0tIGEvc3JjL2ltYWdlLmMKKysrIGIv c3JjL2ltYWdlLmMKQEAgLTQ1OTYsNyArNDU5Niw3IEBAIHhwbV9tYWtlX2NvbG9yX3RhYmxlX2gg KHZvaWQgKCoqcHV0X2Z1bmMpIChMaXNwX09iamVjdCwgY29uc3QgY2hhciAqLCBpbnQsCiAgICpn ZXRfZnVuYyA9IHhwbV9nZXRfY29sb3JfdGFibGVfaDsKICAgcmV0dXJuIG1ha2VfaGFzaF90YWJs ZSAoaGFzaHRlc3RfZXF1YWwsIERFRkFVTFRfSEFTSF9TSVpFLAogCQkJICBERUZBVUxUX1JFSEFT SF9TSVpFLCBERUZBVUxUX1JFSEFTSF9USFJFU0hPTEQsCi0JCQkgIFFuaWwsIGZhbHNlKTsKKwkJ CSAgUW5pbCk7CiB9CiAKIHN0YXRpYyB2b2lkCi0tIAoyLjIyLjAKCg== --000000000000741940058e31e5ff--