From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#34757: Invalid bytecode from byte compiler Date: Fri, 8 Mar 2019 21:13:37 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000813db605839bb438" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="244873"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34757@debbugs.gnu.org To: chuntaro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 08 22:15:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h2Mpo-0011WA-Tz for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Mar 2019 22:15:17 +0100 Original-Received: from localhost ([127.0.0.1]:50015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Mpn-0005w3-TV for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Mar 2019 16:15:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Mpd-0005s8-Ep for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2019 16:15:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2Mpb-0005RP-DW for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2019 16:15:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51455) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2Mpa-0005Qh-0f for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2019 16:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h2MpZ-0004fg-Qg for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2019 16:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Mar 2019 21:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34757 X-GNU-PR-Package: emacs Original-Received: via spool by 34757-submit@debbugs.gnu.org id=B34757.155207966517897 (code B ref 34757); Fri, 08 Mar 2019 21:15:01 +0000 Original-Received: (at 34757) by debbugs.gnu.org; 8 Mar 2019 21:14:25 +0000 Original-Received: from localhost ([127.0.0.1]:36766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h2Moy-0004eZ-Qo for submit@debbugs.gnu.org; Fri, 08 Mar 2019 16:14:25 -0500 Original-Received: from mail-ot1-f48.google.com ([209.85.210.48]:43480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h2Mou-0004eG-Ra for 34757@debbugs.gnu.org; Fri, 08 Mar 2019 16:14:22 -0500 Original-Received: by mail-ot1-f48.google.com with SMTP id n71so18566685ota.10 for <34757@debbugs.gnu.org>; Fri, 08 Mar 2019 13:14:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Em1deGWKgGAduZCFbinna9ZMIEVr2aTUrUU9sZ7GJd0=; b=UZLBqjYAKKFg8ZCjZa1wQTSVFOLN7NyQpbSi0vHtiTawhewaO2QBQ8Hach1WSpY87e gtzX4taD1SMM6OWzO2lQfs61pvhKY/z6aT0AHpp1H5wZGtrHvbgwLvW9dFU9VS+25asE adER7QDuwWyJA3bypgU+hkwegUF0DleM3nkK3yY70gDOSeUOk2IQDfWaxKMA7FCsWVBk S5rN4LrsZYWgNfN6wfdpbxBdDwQykwGcyt73f3e8u40KmxLFVu2XMrUe1BxWXgUlU4dn Zf3kw1JeUCmqNZinrjQqB6zEsEpapLyZH7gRV05CMJ3LL4Cpy1VTGkGwSIh9i0NlqGQt fDNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Em1deGWKgGAduZCFbinna9ZMIEVr2aTUrUU9sZ7GJd0=; b=sL92FLpP/zWW86kdjx0VoJzNJBD44mTGo3sMh+Vwi42z3iVBn1LU3Rbu+z1RPLMkI5 ytUVREEte3ppFz1Q4JUtDrbQlQh5+jtEL9/Bs2TI33PQAW0Sjk9nObz4T6eQ/YD0KX32 5rOV2t/pealTTVA2HDzON7FzkBX+vBY1D9LTTSDtlBMjpYx1FuZM2o/yoJvfUk32Zykd 0/DnkvLzrA7tT7XdFu2LWIYb9DKTt2msQVrh3w77uGn3zAFfKOxXc5HK4wV6q/R+Vg+I crUgmsNufiLzcMeuV2kZXyAmIWkQ66/MPxBKQMn9z1D2KIz8Las6X3gqFfwTcjYAsG74 H7MA== X-Gm-Message-State: APjAAAVFegzsUgfVSsQTIfQSp1t8AcnpXAztYIQkp1P5GAwJRjQxTJ/f 6JXkPmOkDPOwAE+JOh9hU+jrJHO5QiMvJHqnASsJi4nA X-Google-Smtp-Source: APXvYqw6GrdZhPVR/7uanArjIRD8QRRVS7DF2PB820P7yRETrnTZeFx2s1sGjZ+S2P3EZ1bkQW2FTSlSiZdW/ijCPxA= X-Received: by 2002:a9d:66c8:: with SMTP id t8mr12226694otm.368.1552079655067; Fri, 08 Mar 2019 13:14:15 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156170 Archived-At: --000000000000813db605839bb438 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 5, 2019 at 3:30 PM chuntaro wrote: > > Invalid bytecode is output and error occurs when executed. If I'm looking at this correctly, the problem is that the byte code which is generated in an intermediate step: 0 constant 2 1 constant print 2 constant 1 3 call 1 4 discard 5 constant 3 6 return is considered a "trivial function" by byte-compile-out-toplevel, which assumes that all values on the stack are used by the call. We could fix byte-compile-out-toplevel to properly analyze how many stack arguments the call takes, but this patch simply treats forms like this as nontrivial: diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 0b8f8824b4c..4e54e08ce14 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -3025,6 +3025,7 @@ byte-compile-out-toplevel (or (null (cdr rest)) (and (memq output-type '(file progn t)) (cdr (cdr rest)) + (eql (length body) (cdr (car rest))) (eq (car (nth 1 rest)) 'byte-discard) (progn (setq rest (cdr rest)) t)))) (setq maycall nil) ; Only allow one real function call. --000000000000813db605839bb438 Content-Type: text/x-patch; charset="US-ASCII"; name="emacs-34757.diff" Content-Disposition: attachment; filename="emacs-34757.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jt0k06le0 ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbCBiL2xpc3AvZW1hY3MtbGlz cC9ieXRlY29tcC5lbAppbmRleCAwYjhmODgyNGI0Yy4uNGU1NGUwOGNlMTQgMTAwNjQ0Ci0tLSBh L2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvYnl0ZWNv bXAuZWwKQEAgLTMwMjUsNiArMzAyNSw3IEBAIGJ5dGUtY29tcGlsZS1vdXQtdG9wbGV2ZWwKICAg ICAgICAgICAgICAgICAgICAgICAgKG9yIChudWxsIChjZHIgcmVzdCkpCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoYW5kIChtZW1xIG91dHB1dC10eXBlICcoZmlsZSBwcm9nbiB0KSkKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNkciAoY2RyIHJlc3QpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoZXFsIChsZW5ndGggYm9keSkgKGNkciAoY2FyIHJlc3Qp KSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGVxIChjYXIgKG50aCAxIHJlc3Qp KSAnYnl0ZS1kaXNjYXJkKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvZ24g KHNldHEgcmVzdCAoY2RyIHJlc3QpKSB0KSkpKQogICAgICAgICAgICAgICAgICAgKHNldHEgbWF5 Y2FsbCBuaWwpCTsgT25seSBhbGxvdyBvbmUgcmVhbCBmdW5jdGlvbiBjYWxsLgo= --000000000000813db605839bb438--