From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36609: 27.0.50; Possible race-condition in threading implementation Date: Fri, 12 Jul 2019 12:44:35 +0000 Message-ID: References: <87muhks3b5.fsf@hochschule-trier.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000011070b058d7b485c" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="63352"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36609@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 12 14:46:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hluwK-000GKZ-5P for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 14:46:16 +0200 Original-Received: from localhost ([::1]:49138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hluwJ-0002C0-23 for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 08:46:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41706) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hluwA-0001jS-Th for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 08:46:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hluw8-0007jA-8L for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 08:46:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58770) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hluw5-0007hi-P3 for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 08:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hluw5-00058T-LW for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 08:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jul 2019 12:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36609 X-GNU-PR-Package: emacs Original-Received: via spool by 36609-submit@debbugs.gnu.org id=B36609.156293552119691 (code B ref 36609); Fri, 12 Jul 2019 12:46:01 +0000 Original-Received: (at 36609) by debbugs.gnu.org; 12 Jul 2019 12:45:21 +0000 Original-Received: from localhost ([127.0.0.1]:39358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hluvQ-00057X-Lu for submit@debbugs.gnu.org; Fri, 12 Jul 2019 08:45:20 -0400 Original-Received: from mail-oi1-f172.google.com ([209.85.167.172]:43439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hluvO-00057H-PU for 36609@debbugs.gnu.org; Fri, 12 Jul 2019 08:45:19 -0400 Original-Received: by mail-oi1-f172.google.com with SMTP id w79so7163388oif.10 for <36609@debbugs.gnu.org>; Fri, 12 Jul 2019 05:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W9Fh52n93BAaOZXJPz2/3ms5OSpST+RP++o0J5Lljzg=; b=tnYilC2okzQbS6vZ88wKrfFLlBoT8VL6rswycjoEXe5r+GVyrZQ5NgfKPZSD6t5yzT 3cu87Zbb7lo+dxJrhTd4YksO4jhvfahhRHdDbWqw0bVe7cbHcKEf54jwk8YKCIMfxhY+ D441QqdBPRktnUthN1zSC7pyXJ74ev9rz/wW7wQzMXOvpmfOTvlzjhjIrnUNo8LsHMWm lQOg6LaWOTTYvq/etzqSIO73z4Gy3D434IQW+gvrUElP6oOkyssh4WhmNfmnpyGCpfcP KeEol0PHykVBwSk/dnaNKO1md8fZL5s3Pn9zLWFQmeaLyMlX0byFHPLZYC0U7mMRytDg PLDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W9Fh52n93BAaOZXJPz2/3ms5OSpST+RP++o0J5Lljzg=; b=E/6sY8jYDWmMXh67weRMAYJNhSIZdgT/IyurmPJE/a4dNJZME9g5r2E5fjc8DHXBBF LXz30kx1iEHrBt0umq0zaOWV2xMspA9SaBIcMTDOYpY38xPoLXo7qiwh2yQd/0N9Nk/Q u5E8eZnIiJKqmwCf1nZSysyaCWzzNyQ3NrzUlRod2CNR6iQy8yCiHMTLsivmPv+eQbvc Pypch4LzfxHotoJ9TQqDWUqQzVwqH9S4dmpAnipx9b79ibj94AU5OMYrgi8ujeViHMSn A/NwvE7j4b8925KSEIHc+3q5qmtDHcU6+ojQUwWOI95KF5Qluy7F45Hc15rmbir0Ysv8 kNWQ== X-Gm-Message-State: APjAAAWWV6VpvBSCPusdU+jMZzUl43MFGtsMH7ma9cSioG0puvRpUlWc JueXn/Myk+vz6LJImJtpjEnPotn3wLgz4rAp+s8= X-Google-Smtp-Source: APXvYqwwGkgsiBXtUK7ILtr2AeUfaOD0ArWxcag1Ayb3SUS5SqJb1TZIIYsFOC+vqiqdtdzCd1d9kYfXmmYsG6df/64= X-Received: by 2002:aca:4790:: with SMTP id u138mr6064676oia.44.1562935513113; Fri, 12 Jul 2019 05:45:13 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162761 Archived-At: --00000000000011070b058d7b485c Content-Type: text/plain; charset="UTF-8" On Fri, Jul 12, 2019 at 9:02 AM Pip Cet wrote: > > On Thu, Jul 11, 2019 at 8:52 PM Andreas Politz > wrote: > > I think there is a race-condition in the implementation of threads. I > > tried to find a minimal test-case, without success. Thus, I've attached > > a lengthy source-file. Loading that file should trigger this bug and > > may freeze your session. > > It does here, so I can provide further debugging information if > needed. On first glance, it appears that xgselect returns abnormally > with g_main_context acquired in one thread, and then other threads > fail to acquire it and loop endlessly. Okay, I'm still not sure this is really the problem Andreas was seeing, but this code fails to work with xg_select: (let ((thread (make-thread (lambda () (sleep-for 3))))) (thread-yield) (thread-signal thread 'error nil)) Proposed patch attached. --00000000000011070b058d7b485c Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Protect-against-abnormal-exit-in-xg_select.patch" Content-Disposition: attachment; filename="0001-Protect-against-abnormal-exit-in-xg_select.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jy03fdfy0 RnJvbSAwMTIzNDFhOGE2NzRiMTMwYzMzNWNmZGQ4ZDI0ODg4NDA2ZTk4ZWNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBGcmks IDEyIEp1bCAyMDE5IDEyOjM5OjI5ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gUHJvdGVjdCBhZ2Fp bnN0IGFibm9ybWFsIGV4aXQgaW4gYHhnX3NlbGVjdCcKCiogc3JjL3hnc2VsZWN0LmMgKHJlbGVh c2VfZ19tYWluX2NvbnRleHQpOiBOZXcgZnVuY3Rpb24uCih4Z19zZWxlY3QpOiBVbndpbmQtcHJv dGVjdCByZWxlYXNlIG9mIHRoZSBHTGliIG1haW4gY29udGV4dC4KLS0tCiBzcmMveGdzZWxlY3Qu YyB8IDE4ICsrKysrKysrKysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMo KyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3hnc2VsZWN0LmMgYi9zcmMveGdz ZWxlY3QuYwppbmRleCA5OTgyYTFmMGU5Li5lMzUzMTBiZTM0IDEwMDY0NAotLS0gYS9zcmMveGdz ZWxlY3QuYworKysgYi9zcmMveGdzZWxlY3QuYwpAQCAtMjksNiArMjksMTUgQEAgQ29weXJpZ2h0 IChDKSAyMDA5LTIwMTkgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCiAjaW5jbHVkZSAi YmxvY2tpbnB1dC5oIgogI2luY2x1ZGUgInN5c3RpbWUuaCIKIAorLyogSGVscGVyIGZ1bmN0aW9u IGZvciBgdW53aW5kX3Byb3RlY3QnLiAgKi8KKworc3RhdGljIHZvaWQgcmVsZWFzZV9nX21haW5f Y29udGV4dCAodm9pZCAqcHRyKQoreworICBHTWFpbkNvbnRleHQgKmNvbnRleHQgPSAoR01haW5D b250ZXh0ICopIHB0cjsKKworICBnX21haW5fY29udGV4dF9yZWxlYXNlIChjb250ZXh0KTsKK30K KwogLyogYHhnX3NlbGVjdCcgaXMgYSBgcHNlbGVjdCcgcmVwbGFjZW1lbnQuICBXaHkgZG8gd2Ug bmVlZCBhIHNlcGFyYXRlIGZ1bmN0aW9uPwogICAgMS4gVGltZW91dHMuICBHbGliIGFuZCBHdGsg cmVseSBvbiB0aW1lciBldmVudHMuICBJZiB3ZSBkaWQgcHNlbGVjdAogICAgICAgd2l0aCBhIGdy ZWF0ZXIgdGltZW91dCB0aGVuIHRoZSBvbmUgc2NoZWR1bGVkIGJ5IEdsaWIsIHdlIHdvdWxkCkBA IC01OCw4ICs2NywxMiBAQCB4Z19zZWxlY3QgKGludCBmZHNfbGltLCBmZF9zZXQgKnJmZHMsIGZk X3NldCAqd2ZkcywgZmRfc2V0ICplZmRzLAogICBpbnQgaSwgbmZkcywgdG1vX2luX21pbGxpc2Vj LCBtdXN0X2ZyZWUgPSAwOwogICBib29sIG5lZWRfdG9fZGlzcGF0Y2g7CiAKKyAgcHRyZGlmZl90 IGNvdW50ID0gU1BFQ1BETF9JTkRFWCAoKTsKICAgY29udGV4dCA9IGdfbWFpbl9jb250ZXh0X2Rl ZmF1bHQgKCk7CiAgIGNvbnRleHRfYWNxdWlyZWQgPSBnX21haW5fY29udGV4dF9hY3F1aXJlIChj b250ZXh0KTsKKworICBpZiAoY29udGV4dF9hY3F1aXJlZCkKKyAgICByZWNvcmRfdW53aW5kX3By b3RlY3RfcHRyIChyZWxlYXNlX2dfbWFpbl9jb250ZXh0LCAodm9pZCAqKWNvbnRleHQpOwogICAv KiBGSVhNRTogSWYgd2UgY291bGRuJ3QgYWNxdWlyZSB0aGUgY29udGV4dCwgd2UganVzdCBzaWxl bnRseSBwcm9jZWVkCiAgICAgIGJlY2F1c2UgdGhpcyBmdW5jdGlvbiBoYW5kbGVzIG1vcmUgdGhh biBqdXN0IGdsaWIgZmlsZSBkZXNjcmlwdG9ycy4KICAgICAgTm90ZSB0aGF0LCBhcyBpbXBsZW1l bnRlZCwgdGhpcyBmYWlsdXJlIGlzIGNvbXBsZXRlbHkgc2lsZW50OiB0aGVyZSBpcwpAQCAtMTY0 LDkgKzE3Nyw2IEBAIHhnX3NlbGVjdCAoaW50IGZkc19saW0sIGZkX3NldCAqcmZkcywgZmRfc2V0 ICp3ZmRzLCBmZF9zZXQgKmVmZHMsCiAgICAgICBlcnJubyA9IHBzZWxlY3RfZXJybm87CiAgICAg fQogCi0gIGlmIChjb250ZXh0X2FjcXVpcmVkKQotICAgIGdfbWFpbl9jb250ZXh0X3JlbGVhc2Ug KGNvbnRleHQpOwotCiAgIC8qIFRvIG5vdCBoYXZlIHRvIHJlY2FsY3VsYXRlIHRpbWVvdXQsIHJl dHVybiBsaWtlIHRoaXMuICAqLwogICBpZiAoKG91cl9mZHMgPiAwIHx8IChuZmRzID09IDAgJiYg dG1vcCA9PSAmdG1vKSkgJiYgKHJldHZhbCA9PSAwKSkKICAgICB7CkBAIC0xNzQsNiArMTg0LDgg QEAgeGdfc2VsZWN0IChpbnQgZmRzX2xpbSwgZmRfc2V0ICpyZmRzLCBmZF9zZXQgKndmZHMsIGZk X3NldCAqZWZkcywKICAgICAgIGVycm5vID0gRUlOVFI7CiAgICAgfQogCisgIHVuYmluZF90byAo Y291bnQsIFFuaWwpOworCiAgIHJldHVybiByZXR2YWw7CiB9CiAjZW5kaWYgLyogSEFWRV9HTElC ICovCi0tIAoyLjIwLjEKCg== --00000000000011070b058d7b485c--