From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36447: 27.0.50; New "Unknown keyword" errors Date: Fri, 5 Jul 2019 08:36:57 +0000 Message-ID: References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="158713"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 05 10:47:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjJs4-000fAa-Ni for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 10:47:08 +0200 Original-Received: from localhost ([::1]:50632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjJs3-00056l-J2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 04:47:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58157) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjJjJ-0002wq-Ey for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 04:38:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjJjI-0002mR-AU for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 04:38:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43527) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjJjG-0002it-Bl for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 04:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hjJjG-0004eP-86 for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 04:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2019 08:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36447 X-GNU-PR-Package: emacs Original-Received: via spool by 36447-submit@debbugs.gnu.org id=B36447.156231586517842 (code B ref 36447); Fri, 05 Jul 2019 08:38:02 +0000 Original-Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 08:37:45 +0000 Original-Received: from localhost ([127.0.0.1]:52348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJiy-0004di-SU for submit@debbugs.gnu.org; Fri, 05 Jul 2019 04:37:45 -0400 Original-Received: from mail-oi1-f178.google.com ([209.85.167.178]:39491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjJiu-0004dQ-OG for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 04:37:43 -0400 Original-Received: by mail-oi1-f178.google.com with SMTP id m202so6631564oig.6 for <36447@debbugs.gnu.org>; Fri, 05 Jul 2019 01:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t+I0X1RAwjppP9dmGwdnbIUbwAz9LEVmRtuvj6jNi5s=; b=jzzKSydcfoqM/DI58n7R35FrFWQSoGgC6ozAnj6fAG4bNc3/ot08XAuR0hC7GKiWKZ gEhidc/PsC3+B0EsdkWaC3EYJBSUogS2JI5oIbUXfKNtJGfR3DOhWHBYTfDH6fPfB42h dr9NIH71KsOsInx0ssSzbkYRZ2Kn43j3NKiwmcKvyuzhM7653Blg039ACvICm1Cke9kQ 4sL/U8m4TKHXRsZz7XK0ML0O/9zOM15KIYgy65BIK/g9Z8Fl9uq/vjh5Yr/K2eexFExc FnMDQS7o3BG/Cms2fbvKNb6g+Ixc67a1qncKYc9KPfW19nb/6UGMJrqof4LfuxAarV5e oAKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t+I0X1RAwjppP9dmGwdnbIUbwAz9LEVmRtuvj6jNi5s=; b=Go2Lrq6iUKcXA/CkdnwrCaAFgMyHmgxasQAje+GLRqAHJjZAuAlMD0hzVUmMJUguDd SYm4DhRMhN6P9YePJLmxbjQ7Xyi4Xf5Tj2Kc2iFTIhBMC4ihjApFCLzYL1Kb+a41/Rm6 18LAsbp14CMu5OytRWs15ypfUMrfKEa76LtKPOpPNmSmwTgc9Kk/XoWXFjEwvpXIOldP DNh55JDGfDv1jGBBaoPClTi4BapdNdWjfgwsHL99pQp4SOuaHhYVU8W1mUZ8fgv4c5b6 HEyCRKr/q5lUHAkCpiyrZW2VrZc6x9urQCfMovEInAT0DP2qqNuSE5d77gKZmiWixmd4 xMqg== X-Gm-Message-State: APjAAAUg8PToq1398RcCkI+LrqZIMTikCGPLQIzFpGRM8GorJZIOVYg0 wMfNO/hKCTxDHth5Sf+wAGCdNkxnRWaPo4alsek= X-Google-Smtp-Source: APXvYqy6NUXmGZyH4vyn7/F54y8DfYOWbfGFS0bqg35EKfwuGyKCnqNIrbgPFet67A+4hoMFf2CcBN7V8CuVyGU00uM= X-Received: by 2002:aca:aa93:: with SMTP id t141mr1368862oie.128.1562315854785; Fri, 05 Jul 2019 01:37:34 -0700 (PDT) In-Reply-To: <83tvc0anwi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162110 Archived-At: On Fri, Jul 5, 2019 at 8:25 AM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Fri, 5 Jul 2019 08:12:07 +0000 > > Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > > > > On Fri, Jul 5, 2019 at 7:50 AM Eli Zaretskii wrote: > > > > rwatch -l *(long *)&XHASH_TABLE(obj)->index > > > > watch -l *(long *)XHASH_TABLE(obj)->index > > > > > > I think this is the same as > > > > > > awatch -l *(long *)XHASH_TABLE(obj)->index > > > > Thanks for checking! What I actually meant was > > awatch -l *(long *)&XHASH_TABLE(obj)->index > > But then why do you need the rwatch as well? awatch breaks both on > read accesses and on write accesses. I don't! Just the awatch is fine, thanks again for pointing it out. It's just that the argument needs a & or we're watching the wrong bit of memory. > > With revision 44f199648b0c986a0ac7608f4e9d803c619ae2d6, I can > > reproduce this problem locally, and I can confirm it's as I thought: > > > > y-or-no-p and custom-handle-keyword both generate 7-element hash > > tables. They share a ->next vector. Both try to rehash the hash table, > > and since there are non-builtin symbols in there, the new hash > > collision chains should differ, but can't, since they share a vector. I've since confirmed that this gdb session does not exhibit the bug: b hash_table_rehash Breakpoint 3 at 0x66bbb6: file fns.c, line 4224. (gdb) command 3 Type commands for breakpoint(s) 3, one per line. End with a line saying just "end". >p h->next = Fcopy_sequence(h->next) >c >end (gdb) r (this is on a CFLAGS="-O0 -g3 -ggdb" build, on GNU/Linux) > > I don't think we can sensibly add tests for this bug, but the fix I > > posted earlier still seems valid to me. > > Sorry, I'm not tracking this part of the discussion, as it lost me > long ago. What's the best way of getting this fixed? Current master is pretty unusable due to this bug, once you call `y-or-n-p' and `custom-handle-keyword', one of the two will stop working (unless you reload their bytecode files first, unsharing their collision chains).