From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#41627: 28.0.50; Emacs with cairo build segfault in HELLO file Date: Sun, 31 May 2020 20:45:56 +0000 Message-ID: References: <83a71okvdl.fsf@gnu.org> <0ac5574a-3e61-182c-406a-94500b66cca6@163.com> <83v9kcj9uu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000080c0705a6f7c6c2" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="35990"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41627@debbugs.gnu.org, Zihao Zhu To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 31 22:47:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jfUrf-0009Jb-8T for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 May 2020 22:47:27 +0200 Original-Received: from localhost ([::1]:52570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfUre-00088T-9B for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 May 2020 16:47:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfUrG-0007st-Q0 for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 16:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfUrG-0001TD-Gf for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 16:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jfUrG-0007PN-Fk for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 16:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 May 2020 20:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41627 X-GNU-PR-Package: emacs Original-Received: via spool by 41627-submit@debbugs.gnu.org id=B41627.159095800628447 (code B ref 41627); Sun, 31 May 2020 20:47:02 +0000 Original-Received: (at 41627) by debbugs.gnu.org; 31 May 2020 20:46:46 +0000 Original-Received: from localhost ([127.0.0.1]:33957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfUqu-0007Of-El for submit@debbugs.gnu.org; Sun, 31 May 2020 16:46:46 -0400 Original-Received: from mail-ot1-f54.google.com ([209.85.210.54]:45164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfUqs-0007OS-Ne for 41627@debbugs.gnu.org; Sun, 31 May 2020 16:46:39 -0400 Original-Received: by mail-ot1-f54.google.com with SMTP id m2so4402954otr.12 for <41627@debbugs.gnu.org>; Sun, 31 May 2020 13:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2LDLlP7Rc+X5gKvdpvhfuPvbRudx2PRD6jpfFngC+pg=; b=fOIwcA60EJ/kzyaz/QWWBqCs6cspUdneZVchd3EE2vnuc8ChnRkDfb7cMktwOYKeKe h5u7UQOhuWadsZ16TFu0YAJtaIrUm5tDi87DgsJq4hmCCRR8Cx3YVP20Fqr67kuNclnS p5LsoylRhQSBoNXrvBg4ypc39gIFs81mdcnGEVpi2V32XU7FnlVFJKiFucCMz71xAnIq NMkAT8WjubYPiq32WlEfBSzrpMjzq5nGn3p+235rCPzmyOby/9aPW70f4a/X6qz02WGc 9MgrQB5R6MkBvvZUV5UBgSO5wUuILYNBstmurtyLxOAkMoYHX8g9SqVc1kqP/elkMfhZ VGhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2LDLlP7Rc+X5gKvdpvhfuPvbRudx2PRD6jpfFngC+pg=; b=ifDA7+8AwNGbHQ7SzsSlRhCCpCI9qbh0HtnIjrbRGIt7qXBUXg5N93oQ3KMquDwucP +x7uk5cF6iSnFPk6RBJcQhW7iPOydH4ok4imJ/XhkrWI4F8R30IJ0SwBgW8ksAgOcoYc hwIr47DHULoOE230/4RaEgzdI24QdV16lAh0aRDs+/T6PR6A2/89M71lBJTVmmmpLKTS hg0VcYfbtUStMo6PLGJY+tpAwFcJCxDC0kGO0AnwLxO+ax+t5yh5G455JjhmnialnIqV nYBEfizCdiJ8TTT9NrdPtbrv8skDZIl0YuqCU2GiTZKAtALpyb7IXs/P0ZgAcMWrT95L tlLA== X-Gm-Message-State: AOAM5318Jn5etGFZ/v7Ran/sSl7hneXOBRJuAM3x7W+10N7unQee/yFn p1buLyYE01xIAoKT2vhEAggrQyoCz9qQcewxP0M= X-Google-Smtp-Source: ABdhPJx3cCMyvkElZelGBsNwIXZZU55fAZWhIKtrxPq9Yos/9O/L/o3wbxzX4KoQd6OG+XOjR8COXA+tAVbNrqdaqDo= X-Received: by 2002:a9d:7a50:: with SMTP id z16mr15028473otm.292.1590957993095; Sun, 31 May 2020 13:46:33 -0700 (PDT) In-Reply-To: <83v9kcj9uu.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181322 Archived-At: --000000000000080c0705a6f7c6c2 Content-Type: text/plain; charset="UTF-8" On Sun, May 31, 2020 at 5:24 PM Eli Zaretskii wrote: > Can someone please propose a patch along these lines? I cannot easily > test a Cairo build, so I won't try showing a patch. How about this? (I'm not sure how and whether `match' is supposed to be freed in the success case, or whether it's simply leaked). --000000000000080c0705a6f7c6c2 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Handle-Cairo-errors-in-ftcrfont_open-bug-41627.patch" Content-Disposition: attachment; filename="0001-Handle-Cairo-errors-in-ftcrfont_open-bug-41627.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kavjab7y0 RnJvbSBkZmVlODM4ODA4OTMyNThiYTBkM2M4YmY4YmE0NzM3ZDVmOTliNTg2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBTdW4s IDMxIE1heSAyMDIwIDIwOjQ0OjU3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gSGFuZGxlIENhaXJv IGVycm9ycyBpbiBmdGNyZm9udF9vcGVuIChidWcjNDE2MjcpCgoqIHNyYy9mdGNyZm9udC5jIChm dGNyZm9udF9vcGVuKTogSGFuZGxlIENhaXJvIGVycm9ycy4KLS0tCiBzcmMvZnRjcmZvbnQuYyB8 IDE2ICsrKysrKysrKysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAy IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9mdGNyZm9udC5jIGIvc3JjL2Z0Y3Jmb250 LmMKaW5kZXggNzgzMmQ0ZjVjZS4uODg0NDVjMmE5MCAxMDA2NDQKLS0tIGEvc3JjL2Z0Y3Jmb250 LmMKKysrIGIvc3JjL2Z0Y3Jmb250LmMKQEAgLTEzOSw3ICsxMzksOCBAQCBmdGNyZm9udF9vcGVu IChzdHJ1Y3QgZnJhbWUgKmYsIExpc3BfT2JqZWN0IGVudGl0eSwgaW50IHBpeGVsX3NpemUpCiAK ICAgRmNQYXR0ZXJuRGVzdHJveSAocGF0KTsKICAgZm9udF9mYWNlID0gY2Fpcm9fZnRfZm9udF9m YWNlX2NyZWF0ZV9mb3JfcGF0dGVybiAobWF0Y2gpOwotICBpZiAoIWZvbnRfZmFjZSkKKyAgaWYg KCFmb250X2ZhY2UKKyAgICAgIHx8IGNhaXJvX2ZvbnRfZmFjZV9zdGF0dXMgKGZvbnRfZmFjZSkg IT0gQ0FJUk9fU1RBVFVTX1NVQ0NFU1MpCiAgICAgewogICAgICAgdW5ibG9ja19pbnB1dCAoKTsK ICAgICAgIEZjUGF0dGVybkRlc3Ryb3kgKG1hdGNoKTsKQEAgLTE1NCw2ICsxNTUsMTggQEAgZnRj cmZvbnRfb3BlbiAoc3RydWN0IGZyYW1lICpmLCBMaXNwX09iamVjdCBlbnRpdHksIGludCBwaXhl bF9zaXplKQogICBjYWlyb19mb250X2ZhY2VfZGVzdHJveSAoZm9udF9mYWNlKTsKICAgY2Fpcm9f Zm9udF9vcHRpb25zX2Rlc3Ryb3kgKG9wdGlvbnMpOwogICB1bmJsb2NrX2lucHV0ICgpOworICBp ZiAoIXNjYWxlZF9mb250CisgICAgICB8fCBjYWlyb19zY2FsZWRfZm9udF9zdGF0dXMgKHNjYWxl ZF9mb250KSAhPSBDQUlST19TVEFUVVNfU1VDQ0VTUykKKyAgICB7CisgICAgICBGY1BhdHRlcm5E ZXN0cm95IChtYXRjaCk7CisgICAgICByZXR1cm4gUW5pbDsKKyAgICB9CisgIGZ0X2ZhY2UgPSBj YWlyb19mdF9zY2FsZWRfZm9udF9sb2NrX2ZhY2UgKHNjYWxlZF9mb250KTsKKyAgaWYgKCFmdF9m YWNlKQorICAgIHsKKyAgICAgIEZjUGF0dGVybkRlc3Ryb3kgKG1hdGNoKTsKKyAgICAgIHJldHVy biBRbmlsOworICAgIH0KIAogICBmb250X29iamVjdCA9IGZvbnRfYnVpbGRfb2JqZWN0IChWRUNT SVpFIChzdHJ1Y3QgZm9udF9pbmZvKSwKIAkJCQkgICBBUkVGIChlbnRpdHksIEZPTlRfVFlQRV9J TkRFWCksCkBAIC0yMzEsNyArMjQ0LDYgQEAgZnRjcmZvbnRfb3BlbiAoc3RydWN0IGZyYW1lICpm LCBMaXNwX09iamVjdCBlbnRpdHksIGludCBwaXhlbF9zaXplKQogICAgICAgZm9udC0+ZGVzY2Vu dCA9IGZvbnQtPmhlaWdodCAtIGZvbnQtPmFzY2VudDsKICAgICB9CiAKLSAgZnRfZmFjZSA9IGNh aXJvX2Z0X3NjYWxlZF9mb250X2xvY2tfZmFjZSAoc2NhbGVkX2ZvbnQpOwogICBpZiAoWEZJWE5V TSAoQVJFRiAoZW50aXR5LCBGT05UX1NJWkVfSU5ERVgpKSA9PSAwKQogICAgIHsKICAgICAgIGlu dCB1cEVNID0gZnRfZmFjZS0+dW5pdHNfcGVyX0VNOwotLSAKMi4yNy4wLnJjMAoK --000000000000080c0705a6f7c6c2--