From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#41125: 28.0.50; Fwindow_text_pixel_size uses FETCH_CHAR (charpos) Date: Thu, 7 May 2020 11:55:07 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="65043"; mail-complaints-to="usenet@ciao.gmane.io" To: 41125@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 07 13:56:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWf8L-000Gms-W5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 May 2020 13:56:09 +0200 Original-Received: from localhost ([::1]:33622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWf8L-0005q5-2J for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 May 2020 07:56:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWf8E-0005pm-Sw for bug-gnu-emacs@gnu.org; Thu, 07 May 2020 07:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWf8E-0008WH-K0 for bug-gnu-emacs@gnu.org; Thu, 07 May 2020 07:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jWf8E-0004eY-Ja for bug-gnu-emacs@gnu.org; Thu, 07 May 2020 07:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 May 2020 11:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41125 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158885254717854 (code B ref -1); Thu, 07 May 2020 11:56:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 May 2020 11:55:47 +0000 Original-Received: from localhost ([127.0.0.1]:42313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWf7z-0004dr-BV for submit@debbugs.gnu.org; Thu, 07 May 2020 07:55:47 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWf7x-0004dh-Rg for submit@debbugs.gnu.org; Thu, 07 May 2020 07:55:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWf7x-0005p4-JF for bug-gnu-emacs@gnu.org; Thu, 07 May 2020 07:55:45 -0400 Original-Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:46562) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWf7w-0007fI-V7 for bug-gnu-emacs@gnu.org; Thu, 07 May 2020 07:55:45 -0400 Original-Received: by mail-oi1-x231.google.com with SMTP id c124so4688490oib.13 for ; Thu, 07 May 2020 04:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=6CBWw2AglR7NnqTGpMSxFJInlquqvIrjqG27YaHLgR8=; b=WTNk9xgFgnTC8wh7hQ5cd7fTy+wFieUrFgWLSfYooQ7UmziHaapLTHarhpZ9QsOpr4 K5kKD/x2ST77l7O0hIgouJGn+e7tXIoX8MOsupawqrL7udaXlfZYyt3VNhZnUU2Og5Bq rjymgn35cAmMxMdycTyIJzZOxaE1MiTPAJuLG+KdpJifa/m7Ukd/jEG7ktF6Sz6ZCeUD ML8DDfxEBnEU2TTPsyDWRAtS5JxcNxdNad+Mppsv+JTrAT4Bnqq2+Sb1IdKbqHHfp3As Ns9g3fL2yQoGBWS8H5/rkP6whqNcKZLfaEaSLqlzgRd+PYNNjsKx6TRtITyYTh5tNhDj PymA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=6CBWw2AglR7NnqTGpMSxFJInlquqvIrjqG27YaHLgR8=; b=lYJBET6C82kj/4S/5HQfjSOZiXYKfxrIURDSzprezW9dlVTr1eU8cnLexiU8NcvbVc 1nvpq9GBEunWrv9Y1YW4IKDGkL7RwyOPDeArNlrubxcfEr5dwjP6ZVMlulU4PJS1vBdh xWXcnPfV3CF+oOyV93P9SV+B2ZCyhgTdsEybOHCkcOZpKo87t6/BKYyhtWRVd7TZrR+J gd+PqBvrTEqV/vYL9joe4hKTzRDT1rI/aHPHg+ie8ITGJgkUBq6mxZYAuvDQzL5PsKt8 95w3q0HXhKkOy1TgjZ2uhMvRCGL1wtRm4wlPpLo+Lwjvpxxy3lQKyTYj0LQcKamOKR9p aJ3Q== X-Gm-Message-State: AGi0PubGIp3iKYrs3WllXvZBM/Ior62Lg9FcqALfTB3m5hnYIbsSARFF GfQ5+WAPZG6UKicVXyAv/dlLPVox8Sbq2w/rspBQRY+AHHY= X-Google-Smtp-Source: APiQypK6euTwvaNGMlE9scTEY01iUYnWVjghyUKWftBeZS5rbRJPz/pM2edm0gDTPnp+GmYkVcb9fba1NtgBADpDeWI= X-Received: by 2002:aca:5614:: with SMTP id k20mr6164804oib.30.1588852543566; Thu, 07 May 2020 04:55:43 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::231; envelope-from=pipcet@gmail.com; helo=mail-oi1-x231.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179876 Archived-At: Fwindow_text_pixel_size contains this code: start = pos = BEGV; while ((pos++ < ZV) && (c = FETCH_CHAR (pos)) && (c == ' ' || c == '\t' || c == '\n' || c == '\r')) start = pos; while ((pos-- > BEGV) && (c = FETCH_CHAR (pos)) && (c == ' ' || c == '\t')) start = pos; which cannot possibly be correct: FETCH_CHAR takes a byte position, not a character position, but BEGV and ZV are measured in characters. (I'm familiarizing myself with the xdisp.c code, partly by replacing bytepos/charpos pairs of variables with a combined pos_t type variable. I think that's a good idea partly because it would prevent precisely this kind of bug.)