unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Reuben Thomas <rrt@sc3d.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24901@debbugs.gnu.org
Subject: bug#24901: Patch updated slightly
Date: Fri, 2 Dec 2016 16:09:49 +0000	[thread overview]
Message-ID: <CAOnWdojw3pqS-tvpSn-1wdjir2A_Vi8=tcrFSoNVBEB=o1b=QA@mail.gmail.com> (raw)
In-Reply-To: <83h96mmil2.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]

On 2 December 2016 at 15:55, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Reuben Thomas <rrt@sc3d.org>
> > Date: Fri, 2 Dec 2016 15:40:58 +0000
> > Cc: 24901@debbugs.gnu.org
> >
> > On 2 December 2016 at 15:26, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >  So electric-pair-mode is incompatible with RTL scripts. Too bad.
> >
> > It seems to work for me: if I select a Hebrew keyboard layout, type some
> Hebrew letters, and then use double
> > straight quotes, I get the expected result. If I use curly quotes, I get
> a different result, but perhaps that it
> > because it implicitly changes the writing direction? I didn't get as far
> as trying to configure electric-pair-mode to
> > understand Hebrew quotation marks.
>
> The problem I was thinking about is that in RTL script you would type
> the right quote first, to serve as the opening quote.  That's because
> the quotes are not mirrored by the bidirectional reordering for
> display, like parentheses are.
>

So, if you expect to be able to use the same quote characters without
reconfiguration according to language, then it won't work. Otherwise, you
can simply configure the quotes the other way around, and it should work
(and change the documentation of electric-quote-pairs to mention "open" and
"close" rather than "left" and "right"). But I guess this is a solved
design problem that simply needs integrating into electric-pair-mode…

Change installed.

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 2576 bytes --]

  parent reply	other threads:[~2016-12-02 16:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 12:00 bug#24901: Patch to add support for curly quotes to electric-pair-mode Reuben Thomas
     [not found] ` <handler.24901.B.147860642916617.ack@debbugs.gnu.org>
2016-11-08 17:08   ` bug#24901: Acknowledgement (Patch to add support for curly quotes to electric-pair-mode) Reuben Thomas
2016-11-08 17:52 ` bug#24901: Patch updated slightly Reuben Thomas
2016-11-28 22:24   ` Reuben Thomas
2016-12-02  9:45     ` Eli Zaretskii
2016-12-02 14:42       ` Reuben Thomas
2016-12-02 15:26         ` Eli Zaretskii
2016-12-02 15:40           ` Reuben Thomas
2016-12-02 15:55             ` Eli Zaretskii
2016-12-02 16:04               ` Eli Zaretskii
2016-12-02 16:09               ` Reuben Thomas [this message]
2016-12-03  0:20 ` bug#24901: Reuben Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOnWdojw3pqS-tvpSn-1wdjir2A_Vi8=tcrFSoNVBEB=o1b=QA@mail.gmail.com' \
    --to=rrt@sc3d.org \
    --cc=24901@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).