From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Reuben Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#42248: Problems between Flyspell and Enchant Date: Mon, 7 Sep 2020 00:53:52 +0100 Message-ID: References: <878sfvwbr0.fsf@disroot.org> Reply-To: Reuben Thomas Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000084e5805aeadd1f4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10817"; mail-complaints-to="usenet@ciao.gmane.io" To: 42248@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 01:55:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kF4V8-0002jP-7W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 01:55:14 +0200 Original-Received: from localhost ([::1]:39678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kF4V7-0007aA-Al for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Sep 2020 19:55:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kF4Uw-0007Yv-9L for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 19:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kF4Uw-000371-0A for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 19:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kF4Uv-0000QV-Vm for bug-gnu-emacs@gnu.org; Sun, 06 Sep 2020 19:55:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <878sfvwbr0.fsf@disroot.org> Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Sep 2020 23:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42248 X-GNU-PR-Package: emacs Original-Received: via spool by 42248-submit@debbugs.gnu.org id=B42248.15994364531581 (code B ref 42248); Sun, 06 Sep 2020 23:55:01 +0000 Original-Received: (at 42248) by debbugs.gnu.org; 6 Sep 2020 23:54:13 +0000 Original-Received: from localhost ([127.0.0.1]:47430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF4U8-0000PQ-Go for submit@debbugs.gnu.org; Sun, 06 Sep 2020 19:54:12 -0400 Original-Received: from mail-ot1-f46.google.com ([209.85.210.46]:43596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF4U5-0000PC-7r for 42248@debbugs.gnu.org; Sun, 06 Sep 2020 19:54:10 -0400 Original-Received: by mail-ot1-f46.google.com with SMTP id n61so3245215ota.10 for <42248@debbugs.gnu.org>; Sun, 06 Sep 2020 16:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=aXqXx975pktcDF0PMBGTU8VnBaIDsJBZAu+OnJZV7mo=; b=qdRqzIMAb7OIvusSHO/paMxrrnVpI9Q53AXcPwHXJB0lvJbEG8RNwtDyuU3Zu+WXBB abovNf3kA+Uy5Iul3R21ddENrPS+oAutiRyqtSl0jfczoGN2rOKR/no95rU5xSH2Jhb0 eDx1lZImXQGlWbsAz0yeU1QAkQfMjfDuW7Fhg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=aXqXx975pktcDF0PMBGTU8VnBaIDsJBZAu+OnJZV7mo=; b=dMboSSQZqhnfG0P3xBs1rCQHVR9/Z06ipxQVNsMIlj0EkuTMBUsY1Q/bpC82jLthE8 gglpZP2Dn+cmdO33tgeDq/6g9UAsfNck+ViSNg5ykwFvJonQ3vx/0Ydou8dMlw1UlRvq 0v0REKkBI8DTOpFqQC1rXfIKRP5q073BX+5R9K9gI0yby3/FxImC0N7nwjbPf6Ol3F0e qpT4HMI2O4atX0b+vzIiwizbQWnYy82gIQ6GeVpkbpjAjMezNc7HqbvDMi5CQilBrHwl dXl+OjZmN/IjuxAsHaMgWTgzT/uEhCA5n9tpwYfrd+7eGfDQmJE5oBw0frcEqbCcY6Y9 lNDg== X-Gm-Message-State: AOAM531IbKFy4MtIrmXoURVEyN1hhQ3ZR+ek/5aJRwHXMYeBy6z1NmIF 2UHKGRmhD/zZTwfvzL1MKn909ATN4o3o+Nu6lvLRA/aqvwFKYQ== X-Google-Smtp-Source: ABdhPJxR3hRIyHyXRjovpIXKoXHTNIPGGjjUhLwsOMNh8tCeBGA7SK3K+GlKUczIoDFRZJPQNkAmnD1og4OoTOeQOpA= X-Received: by 2002:a9d:140a:: with SMTP id h10mr12459809oth.46.1599436443107; Sun, 06 Sep 2020 16:54:03 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187402 Archived-At: --000000000000084e5805aeadd1f4 Content-Type: text/plain; charset="UTF-8" [I'm the Enchant maintainer and author of the Enchant support in ispell.el, so it's All My Fault :) Sorry!] I cannot reproduce the problem with numbers being detected as misspellings from the command line with enchant-2 2.2.8 or 2.2.10. (As all the digits are in WORDCHARS, it is expected that numbers should pass spell-checking.) I looked into the matter of "-B". It would be quite tiresome to have to teach ispell.el which spelling checkers accept -B. I notice that hunspell does not support -B, but it does accept it; indeed, it seems to happily accept and discard any unknown option. I think Enchant should silently ignore -B, as it does with -m to work with Emacs. I agree that the en_US dictionary should contain ' in its WORDCHARS. I found another, recent, Debian bug about this, this time on the correct package (the dictionaries): https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964257 I have merged the two bug reports in the hopes that this might help! Note that quotation marks work correctly in the Debian en_GB dictionary, though there is another problem there: WORDCHARS contains only the curly quote. This is because hunspell contains the following special rule: if either the straight or curly single right quote is listed in WORDCHARS, then the other is also allowed. I have implemented this logic in Enchant 2.2.10 in its hunspell backend (recently released). I found a couple of minor bugs in enchant: first, it gives an unhelpful error message when asked for a language it doesn't have; and secondly, at least for me `enchant-lsmod-2 -list-dicts` does not list the en_US dictionary even though it is installed. I will look into those, as the second in particular affects Emacs. I agree with the patch to ispell.el, in all three points, though for me the invocation of enchant-lsmod-2 does not fail with the extra argument (this will be why I didn't notice the problem when I originally wrote the code). I am happy to install this patch if Eli agrees. -- https://rrt.sc3d.org --000000000000084e5805aeadd1f4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
[I'm the Enchant maintainer and aut= hor of the Enchant support in ispell.el, so it's All My Fault :) Sorry!= ]

I cannot reproduce t= he problem with numbers being detected as misspellings from the command lin= e with enchant-2 2.2.8 or 2.2.10. (As all the digits are in WORDCHARS, it i= s expected that numbers should pass spell-checking.)

I looked into the matter of "-B&quo= t;. It would be quite tiresome to have to teach ispell.el which spelling ch= eckers accept -B. I notice that hunspell does not support -B, but it does a= ccept it; indeed, it seems to happily accept and discard any unknown option= . I think Enchant should silently ignore -B, as it does with -m to work wit= h Emacs.
I agree that the = en_US dictionary should contain ' in its WORDCHARS. I found another, re= cent, Debian bug about this, this time on the correct package (the dictiona= ries): https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D964257 I have me= rged the two bug reports in the hopes that this might help!

Note that quotation marks work correc= tly in the Debian en_GB dictionary, though there is another problem there: = WORDCHARS contains only the curly quote. This is because hunspell contains = the following special rule: if either the straight or curly single right qu= ote is listed in WORDCHARS, then the other is also allowed. I have implemen= ted this logic in Enchant 2.2.10 in its hunspell backend (recently released= ).

I found a coupl= e of minor bugs in enchant: first, it gives an unhelpful error message when= asked for a language it doesn't have; and secondly, at least for me `e= nchant-lsmod-2 -list-dicts` does not list the en_US dictionary even though = it is installed. I will look into those, as the second in particular affect= s Emacs.

I agree with the p= atch to ispell.el, in all three points, though for me the invocation of en= chant-lsmod-2 does not fail with the extra argument (this will be why I did= n't notice the problem when I originally wrote the code). I am happy to= install this patch if Eli agrees.

--
--000000000000084e5805aeadd1f4--