From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#24901: Patch updated slightly Date: Fri, 2 Dec 2016 15:40:58 +0000 Message-ID: References: <834m2moeaf.fsf@gnu.org> <83mvgemjxy.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f403045ec30ab6c6340542aec3b7 X-Trace: blaine.gmane.org 1480693336 23117 195.159.176.226 (2 Dec 2016 15:42:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2016 15:42:16 +0000 (UTC) Cc: 24901@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 02 16:42:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpyV-0004mo-Lo for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 16:42:11 +0100 Original-Received: from localhost ([::1]:35198 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCpyW-0002df-Jq for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 10:42:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCpyQ-0002dP-3a for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 10:42:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCpyM-00058y-1v for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 10:42:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCpyL-00058g-Ue for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 10:42:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cCpyL-0008TL-Kx for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 10:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2016 15:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24901 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24901-submit@debbugs.gnu.org id=B24901.148069326632501 (code B ref 24901); Fri, 02 Dec 2016 15:42:01 +0000 Original-Received: (at 24901) by debbugs.gnu.org; 2 Dec 2016 15:41:06 +0000 Original-Received: from localhost ([127.0.0.1]:50481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpxS-0008S9-9J for submit@debbugs.gnu.org; Fri, 02 Dec 2016 10:41:06 -0500 Original-Received: from mail-lf0-f49.google.com ([209.85.215.49]:33615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpxQ-0008RW-Rm for 24901@debbugs.gnu.org; Fri, 02 Dec 2016 10:41:05 -0500 Original-Received: by mail-lf0-f49.google.com with SMTP id c13so197769466lfg.0 for <24901@debbugs.gnu.org>; Fri, 02 Dec 2016 07:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=d/V4A/jkxvEY3Whx3S33hcZxRdIueDbM7eOHkNiVt5M=; b=fkykYCjJ32365hTOicM99w0LORorjE4IDP2m9leIOTBtTFamnt/fyDwHuPO3gieshQ U7q2driyQ1PNh2muaFM5DlF0t2hjFuVXkcayA/JdD9zmjBR6kYrNGKYW8/SFATlEksFx /T4k97WTMDtNiRByN37gkUDLuIir562MX7ts0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=d/V4A/jkxvEY3Whx3S33hcZxRdIueDbM7eOHkNiVt5M=; b=WDdQXDVDJ0yzyhvjhbNXKa9To5zT5xssI3TxxXMfo+bylwvCipzFU4zh8IYJeM/7nO CQC4iFwhbpZ0dDTQK/0R2Lht8po9MzyXfggAZDqq3bb2Z6RhPGGKOYnaH2eWKXtBfvkS 2Rba0iHruRyaZ6R8pcG3mQhbbNH3JppixcBl7PmrM0n3UrdOSwAczC1VaeQ8FRsqbSm/ KbKm/A3c2DoSVP/+C4fT+UBuDU9rCsslp2rRmbtBUWxG9ZKzxQ/yCLhb4Mi0mRkaMgM4 LjQ4/zsZXOnpj9lN/Fg/Ljx7uffcgudnChdZ1U65gKBZl/ciH9/7niFobLIKq5gT/WB+ aXDg== X-Gm-Message-State: AKaTC03A5rrlA5zKDl7mkqhspCnnfD9v7PkmLaQjLw01wQvqcngFNsZgb0hgKI3A8gwdB83+U9bTD6nIMGX+GHSh X-Received: by 10.46.7.9 with SMTP id 9mr16807562ljh.75.1480693258824; Fri, 02 Dec 2016 07:40:58 -0800 (PST) Original-Received: by 10.25.190.2 with HTTP; Fri, 2 Dec 2016 07:40:58 -0800 (PST) In-Reply-To: <83mvgemjxy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126418 Archived-At: --f403045ec30ab6c6340542aec3b7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2 December 2016 at 15:26, Eli Zaretskii wrote: > > I see, thanks. Is it certain that users won't want straight quotes, > but not the curly ones? E.g., in some programming mode, perhaps? > =E2=80=8BI don't think this is a problem, because in that case, the user wo= n't type curly quotes. If the left curly quote (single or double) were widely used on its own in a programming language, that would be a problem, but I don't think it is. The reason I added the curly quotes to electric-pair-pairs as well as electric-pair-text-pairs is because the latter is only used in comments, and so would not be available in text-mode, where curly quotes are useful. > So electric-pair-mode is incompatible with RTL scripts. Too bad. > It seems to work for me: if I select a Hebrew keyboard layout, type some Hebrew letters, and then use double straight quotes, I get the expected result. If I use curly quotes, I get a different result, but perhaps that it because it implicitly changes the writing direction? I didn't get as far as trying to configure electric-pair-mode to understand Hebrew quotation marks. I guess I should have said "open" and "close" rather than "left" and "right". If you're happy with my argument above about programming languages, I'll install the change. --=20 http://rrt.sc3d.org --f403045ec30ab6c6340542aec3b7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 2 December 2016 at 15:26, Eli Zaretskii <eliz@gnu.org> wrote:
=

I see, thanks.=C2=A0 Is it certain that users won't want straigh= t quotes,
but not the curly ones?=C2=A0 E.g., in some programming mode, perhaps?
<= /blockquote>

=E2=80=8BI don't think this is a problem, because in that c= ase, the user won't type curly quotes. If the left curly quote (single = or double) were widely used on its own in a programming language, that woul= d be a problem, but I don't think it is.

The reason I added the curly quotes to electric-pair-p= airs as well as electric-pair-text-pairs is because the latter is only used= in comments, and so would not be available in text-mode, where curly quote= s are useful.
=C2=A0
So= electric-pair-mode is incompatible with RTL scripts.=C2=A0 Too bad.

It seems to work for me: if I select a Hebrew keyboard layout, ty= pe some Hebrew letters, and then use double straight quotes, I get the expe= cted result. If I use curly quotes, I get a different result, but perhaps t= hat it because it implicitly changes the writing direction? I didn't ge= t as far as trying to configure electric-pair-mode to understand Hebrew quo= tation marks.=C2=A0

I gue= ss I should have said "open" and "close" rather than &q= uot;left" and "right".

If you're happy with my argument above about progr= amming languages, I'll install the change.

--=
http://rrt.sc3d.org
--f403045ec30ab6c6340542aec3b7--