From: Reuben Thomas <rrt@sc3d.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18133@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#18133: Suppressing asynchronous command output
Date: Tue, 27 Dec 2016 22:21:11 +0000 [thread overview]
Message-ID: <CAOnWdojJRENcUY08k1f-mKqtow=_GwWP4t-3MCq3nmemWLFUfA@mail.gmail.com> (raw)
In-Reply-To: <83eg0twwje.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]
On 27 December 2016 at 09:28, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Reuben Thomas <rrt@sc3d.org>
> > Date: Tue, 27 Dec 2016 09:01:32 +0000
> > Cc: Juri Linkov <juri@linkov.net>, martin rudalics <rudalics@gmx.at>,
> 18133@debbugs.gnu.org
> >
> > > +(defun comint-make-newly-written-buffer-visible (string process)
> > > + "Make the output buffer visible when output is added to an empty
> buffer.
> > > +Useful in `comint-preoutput-filter-functions'."
> > > + (let ((buffer (process-buffer process)))
> > > + (when (and (= 0 (buffer-size buffer))
> > > + (string-match-p "\\*Async Shell Command\\*"
> > > + (buffer-name buffer)))
> > > + (display-buffer (process-buffer process))))
> > > + string)
> >
> > Why are we hard-coding a certain buffer name in a function that is
> > supposed to be more general, judging by its name and doc string?
> >
> > I found it hard-coded several times in other places, so I hard-coded it
> here. What do you suggest?
>
> I don't see it hard-coded in any context such as this.
>
I'm not quite sure what you mean by "in any context such as this". I see
the string repeated in source code, and never assigned to a variable name.
This seems OK, since strings and symbols are pretty much interchangeable
when of this sort (e.g. not internationalised).
> I think the regexp against which buffer names are matched in
> comint-make-newly-written-buffer-visible should be customizable, with
> "*Async Shell Command*" being (in) the default value.
>
This is already the case.
And another question: where's the user option to turn this feature on
> or off (including the default being off)?
>
M-x customize-variable RET display-buffer-alist RET
You can tick/untick the option for "*Async Shell Command*", and, when it is
ticked, the regexp can be edited.
--
http://rrt.sc3d.org
[-- Attachment #2: Type: text/html, Size: 3368 bytes --]
next prev parent reply other threads:[~2016-12-27 22:21 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 18:47 bug#18133: Suppressing asynchronous command output Reuben Thomas
2014-07-29 23:47 ` Juri Linkov
2014-07-30 9:16 ` Reuben Thomas
2014-07-30 9:48 ` Reuben Thomas
2014-07-30 16:35 ` Juri Linkov
2016-12-19 15:48 ` Reuben Thomas
2016-12-21 17:55 ` Eli Zaretskii
2016-12-21 22:44 ` Reuben Thomas
2016-12-22 16:28 ` Eli Zaretskii
2016-12-22 17:53 ` martin rudalics
2016-12-22 18:32 ` Eli Zaretskii
2016-12-22 19:42 ` Reuben Thomas
2016-12-22 20:15 ` martin rudalics
2016-12-22 20:26 ` Reuben Thomas
2016-12-23 18:59 ` martin rudalics
2016-12-23 19:10 ` Reuben Thomas
2016-12-23 19:55 ` martin rudalics
2016-12-23 21:07 ` Reuben Thomas
2016-12-24 9:16 ` martin rudalics
2016-12-24 11:11 ` Reuben Thomas
2016-12-24 12:06 ` Eli Zaretskii
2016-12-24 13:54 ` martin rudalics
2016-12-24 14:45 ` Reuben Thomas
2016-12-24 16:32 ` martin rudalics
2016-12-24 16:03 ` Eli Zaretskii
2016-12-24 16:33 ` martin rudalics
2016-12-24 16:56 ` Eli Zaretskii
2016-12-24 18:14 ` martin rudalics
2016-12-25 2:23 ` Reuben Thomas
2016-12-26 23:43 ` Reuben Thomas
2016-12-27 7:29 ` martin rudalics
2016-12-26 23:27 ` Juri Linkov
2016-12-27 1:09 ` Reuben Thomas
2016-12-27 1:20 ` Reuben Thomas
2016-12-27 6:23 ` Eli Zaretskii
2016-12-27 9:01 ` Reuben Thomas
2016-12-27 9:28 ` Eli Zaretskii
2016-12-27 22:21 ` Reuben Thomas [this message]
2016-12-28 16:01 ` Eli Zaretskii
2016-12-28 20:58 ` Reuben Thomas
2016-12-29 15:50 ` Eli Zaretskii
2016-12-29 23:08 ` Juri Linkov
2016-12-30 18:28 ` Reuben Thomas
2016-12-30 20:50 ` Eli Zaretskii
2016-12-30 22:33 ` Reuben Thomas
2016-12-30 22:56 ` Juri Linkov
2016-12-31 0:19 ` Reuben Thomas
2016-12-31 8:41 ` Eli Zaretskii
2017-06-28 21:45 ` Reuben Thomas
2017-06-28 21:53 ` Reuben Thomas
2017-06-28 22:05 ` Reuben Thomas
2017-08-07 12:31 ` Reuben Thomas
2017-08-07 16:25 ` Eli Zaretskii
2020-09-18 13:40 ` Lars Ingebrigtsen
2020-09-18 13:51 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-18 14:04 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOnWdojJRENcUY08k1f-mKqtow=_GwWP4t-3MCq3nmemWLFUfA@mail.gmail.com' \
--to=rrt@sc3d.org \
--cc=18133@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).