From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#18229: LIBS vs LIBOBJS in src/Makefile.in Date: Sat, 9 Aug 2014 14:18:52 +0100 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11347352c5a236050032292f X-Trace: ger.gmane.org 1407590416 8710 80.91.229.3 (9 Aug 2014 13:20:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Aug 2014 13:20:16 +0000 (UTC) To: 18229@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 09 15:20:10 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XG6Z7-0002PY-LF for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Aug 2014 15:20:09 +0200 Original-Received: from localhost ([::1]:55971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XG6Z6-0002r0-Nb for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Aug 2014 09:20:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XG6Z2-0002pc-7o for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2014 09:20:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XG6Z1-00066B-0Q for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2014 09:20:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XG6Z0-00065p-Tw for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2014 09:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XG6Z0-0007dY-G4 for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2014 09:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Aug 2014 13:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18229 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.140759034929283 (code B ref -1); Sat, 09 Aug 2014 13:20:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Aug 2014 13:19:09 +0000 Original-Received: from localhost ([127.0.0.1]:36184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XG6Y8-0007cE-TT for submit@debbugs.gnu.org; Sat, 09 Aug 2014 09:19:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43401) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XG6Y6-0007bn-Gx for submit@debbugs.gnu.org; Sat, 09 Aug 2014 09:19:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XG6Y0-0005xQ-7i for submit@debbugs.gnu.org; Sat, 09 Aug 2014 09:19:01 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:43827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XG6Y0-0005xM-4b for submit@debbugs.gnu.org; Sat, 09 Aug 2014 09:19:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XG6Xy-0002kr-RO for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2014 09:18:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XG6Xx-0005xA-Nt for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2014 09:18:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XG6Xx-0005x6-Jx for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2014 09:18:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41042) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1XG6Xx-0003El-Af for bug-emacs@gnu.org; Sat, 09 Aug 2014 09:18:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XG6Xu-0005wn-7V for bug-emacs@gnu.org; Sat, 09 Aug 2014 09:18:57 -0400 Original-Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:56552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XG6Xt-0005wf-Sy for bug-emacs@gnu.org; Sat, 09 Aug 2014 09:18:54 -0400 Original-Received: by mail-la0-f48.google.com with SMTP id gl10so5375355lab.21 for ; Sat, 09 Aug 2014 06:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:date:message-id:subject:from:to:content-type; bh=bXf6fCfW8j0qpSDgtqVUWpDRaBqLMevaODqCGCl6tug=; b=LLzGvuEZK4b1a7zvDjWpUXlaxRxeQAo9rrp5Dsrg9kq05PgU1cpnVhor8OEjWxKdcc HhFxXhVRjoLVh482W+Ovt8zi+EyRXz8KhKDyydeUTjXd8eXK/k7BA/JtV+cfpZZBkKU4 SVVjpavko80+IPDdxc/KEo+xSue2XUSqrZqf4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=bXf6fCfW8j0qpSDgtqVUWpDRaBqLMevaODqCGCl6tug=; b=I1N5NnFKpRq96PXt+qynGmM5lSpMMzcuhbXutCMRrpdC0vo6eiayvN97FbMbcP026y MRWhe7Q/QGGS7Bw58PBMjodO8uESYxdmRFyG0tcEbSCgZiva29zTIZeL8rhnjC51XRYG Bn9aA23b5zYXzq06hboRNQzc3EFcGFDWlUofjlXgI2KzDkElvNSv6Q33lwt9ssNcGlYP vRoIugYqxG0BojXQmX82TavHN3DGVmk68RiuSIn7yJeId24+gRz7/Vs1zuwvMwMVZ4dE RN7kXRapvdoKs9EBJPjE+2j+VrgJ0N9v9hVlz9mvd0zQplX1hggu3EzAtJrQlV4IRgva qYkA== X-Gm-Message-State: ALoCoQmQQGOlOI2SVik2dvZSB9PIGrkGZO20m/py3HPO5Soe2G0hTm5elg4DyZX8S9KDyd2nZl1t X-Received: by 10.153.7.101 with SMTP id db5mr27090330lad.46.1407590332729; Sat, 09 Aug 2014 06:18:52 -0700 (PDT) Original-Received: by 10.152.246.10 with HTTP; Sat, 9 Aug 2014 06:18:52 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92330 Archived-At: --001a11347352c5a236050032292f Content-Type: text/plain; charset=UTF-8 Trying to pass an extra library to configure using LIBS, as configure --help says I can, I found it did nothing, and traced it to src/Makefile.in, which deliberately ignores LIBS. This dates back 14 years, and whatever it was intended to fix no longer seems to be a problem. May I install the following patch? With the patch applied, supplying LIBS on the configure command-line worked exactly as it should. --- src/Makefile.in 2014-07-13 15:50:35 +0000 +++ src/Makefile.in 2014-08-09 11:34:12 +0000 @@ -44,10 +44,7 @@ # BSD doesn't have it as a default. @SET_MAKE@ MKDIR_P = @MKDIR_P@ -# Don't use LIBS. configure puts stuff in it that either shouldn't be -# linked with Emacs or is duplicated by the other stuff below. -# LIBS = @LIBS@ -LIBOBJS = @LIBOBJS@ +LIBS = @LIBS@ lispsource = $(top_srcdir)/lisp lib = ../lib @@ -388,7 +385,7 @@ ## List of object files that make-docfile should not be told about. otherobj= $(TERMCAP_OBJ) $(PRE_ALLOC_OBJ) $(GMALLOC_OBJ) $(RALLOC_OBJ) \ - $(POST_ALLOC_OBJ) $(WIDGET_OBJ) $(LIBOBJS) + $(POST_ALLOC_OBJ) $(WIDGET_OBJ) $(LIBS) ## All object files linked into temacs. $(VMLIMIT_OBJ) should be first. ## (On MinGW, firstfile.o should be before vm-limit.o.) -- http://rrt.sc3d.org --001a11347352c5a236050032292f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Trying to pass an extra library to configure using LIBS, a= s configure --help says I can, I found it did nothing, and traced it to src= /Makefile.in, which deliberately ignores LIBS. This dates back 14 years, an= d whatever it was intended to fix no longer seems to be a problem. May I in= stall the following patch? With the patch applied, supplying LIBS on the co= nfigure command-line worked exactly as it should.

--- src/Makefile.in=C2=A0=C2=A0=C2=A0 2014-07-13 15:50:35 +0000
+++ = src/Makefile.in=C2=A0=C2=A0=C2=A0 2014-08-09 11:34:12 +0000
@@ -44,10 +4= 4,7 @@
=C2=A0# BSD doesn't have it as a default.
=C2=A0@SET_MAKE@=
=C2=A0MKDIR_P =3D @MKDIR_P@
-# Don't use LIBS.=C2=A0 configure p= uts stuff in it that either shouldn't be
-# linked with Emacs or is duplicated by the other stuff below.
-# LIBS = =3D @LIBS@
-LIBOBJS =3D @LIBOBJS@
+LIBS =3D @LIBS@
=C2=A0
=C2= =A0lispsource =3D $(top_srcdir)/lisp
=C2=A0lib =3D ../lib
@@ -388,7 += 385,7 @@
=C2=A0
=C2=A0## List of object files that make-docfile shoul= d not be told about.
=C2=A0otherobj=3D $(TERMCAP_OBJ) $(PRE_ALLOC_OBJ) $(GMALLOC_OBJ) $(RALLOC_O= BJ) \
-=C2=A0 $(POST_ALLOC_OBJ) $(WIDGET_OBJ) $(LIBOBJS)
+=C2=A0 $(PO= ST_ALLOC_OBJ) $(WIDGET_OBJ) $(LIBS)
=C2=A0
=C2=A0## All object files = linked into temacs.=C2=A0 $(VMLIMIT_OBJ) should be first.
=C2=A0## (On MinGW, firstfile.o should be before vm-limit.o.)
--001a11347352c5a236050032292f--