From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Reuben Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72986: Disabling menu-bar-mode changes size of new frames Date: Thu, 5 Sep 2024 20:31:46 +0100 Message-ID: References: <86ttex6iv0.fsf@gnu.org> <062bf084-741b-4d60-b9de-c62d62a79807@gmx.at> <7b6a5b97-fb0c-4eb0-a5b8-78b6ad5002d9@gmx.at> Reply-To: Reuben Thomas Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000173d35062164587b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20871"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Eli Zaretskii , 72986@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 05 21:34:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smIFE-0005L9-Mg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Sep 2024 21:34:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smIEy-0006Kt-D8; Thu, 05 Sep 2024 15:34:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smIEv-0006It-4t for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 15:33:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smIEu-0002XN-N3 for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 15:33:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=f1155JSDHUCl+VkAYRMhiMrbsaCucBzUdPUG/IQHtjI=; b=PjG9y75yBR/v6v1GIUn1PmISHaa2YYhagESFKPQIm1ZiP2IM6EGTYBHdxOeDOKBeAUX8brh8ejy6QPQJB7Axf6tWkBaL3h2cuLAq9Bo6nzAdfkC5qCIKh5bQmO8PF6hHO0BfY/Hu3PfY+4nFdPitm7WA4P0fL5K2ZTUeOvbRtrJN0r6JUR8k2j58U7Rcs/KZE9ZbDbwsJt4i4rVTwRMo70oFil2E8TsU1o4BE2/Tf62ERS2u49krBCYoao6yhMRyS7RRsi1VnayfCFAOg2mtop28Uh1vY9S66j49qP0Yr+fnShH4519k5MVouzht7uCwtaxbUS9j3Ln0wXeY2HO6nw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smIFx-0003ZA-Pc for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 15:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2024 19:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72986 X-GNU-PR-Package: emacs Original-Received: via spool by 72986-submit@debbugs.gnu.org id=B72986.172556485213553 (code B ref 72986); Thu, 05 Sep 2024 19:35:01 +0000 Original-Received: (at 72986) by debbugs.gnu.org; 5 Sep 2024 19:34:12 +0000 Original-Received: from localhost ([127.0.0.1]:38274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smIF9-0003WW-VX for submit@debbugs.gnu.org; Thu, 05 Sep 2024 15:34:12 -0400 Original-Received: from mail-yw1-f180.google.com ([209.85.128.180]:57704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smIF7-0003Vv-Pi for 72986@debbugs.gnu.org; Thu, 05 Sep 2024 15:34:10 -0400 Original-Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-6c130ffa0adso11360207b3.3 for <72986@debbugs.gnu.org>; Thu, 05 Sep 2024 12:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; t=1725564718; x=1726169518; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f1155JSDHUCl+VkAYRMhiMrbsaCucBzUdPUG/IQHtjI=; b=ZkSQn7RymvnVzP+SSYRvrl6ypvhXHKhGsc8M2pnAQuHmRsQ6qxELaPWDF3U79AqL3L 5BSC7i7YeEM6Oe7ZK5wKD1nl2mFxOVMMXm1iXYuPh9Kh8LQGGgl2MQqAXEi56hKiAnWz BJzEnsg8Uh0KE1GpeCWTyLx9zl0ARwUqFzP2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725564718; x=1726169518; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f1155JSDHUCl+VkAYRMhiMrbsaCucBzUdPUG/IQHtjI=; b=PrcQEsSPaKb3IyWECUcWS4tJv4ELqoP6NCTFf6G/bD8gPJgxC4rZA8Z+4nMcmztP9P Fm37+NWpIwfXq62ogwbQx1ntGCook9E24MvC3sJGWpsYmPdpcTw/kCXK/2YeDiGuaruN 2rol9kigrQDzOCxVyprsXkGdumbPpTlzsdtsmCQQmY2GB5NbrKrLbLaoriCsnrLpE5M1 oiGnt/HQqq1FIkOdxAkPASJRPnPE0sthkMcN61s8s1TWfXOUDigCZ7EAlPUUg3yojlmS tT+1K7FQAqxB1AiLQCnwsi1BXdpKvaJJq01Mzp+mpKdYRrNJjFj/d3BAIia8P4N6T308 3h0Q== X-Forwarded-Encrypted: i=1; AJvYcCW5YRba3G41gSjBtD3YNErs2OCyp8Qol6mQy5liEAILYPzZg9dJf9bVzopIRnXf0N/R9N1Nbg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzt4fjUyTB0TwH6N9kTHm4ehR9TXD+staTejHFbne4vvhnbZT8e m+jFc+y9zdcyPEElXbHFg/r2OO1H3HiR3B5wCvhIjoYHLkR9PbI0InWBn0zchef6+1g2hUiEyl4 rKwTkN1gRt90XCiC8JtDEjlC8wKJyaxe6Pn3Tcg== X-Google-Smtp-Source: AGHT+IFI7V6SdCo9vPq/5kKNeE5cxXTPOn7Hu0A/hVOoz3xKmSlDVTUbZ5B9Z9cT72cK8wvpS5yDweesirZea07r+Qw= X-Received: by 2002:a05:690c:6612:b0:6db:3b2f:a188 with SMTP id 00721157ae682-6db4516fb00mr2467537b3.32.1725564718618; Thu, 05 Sep 2024 12:31:58 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291290 Archived-At: --000000000000173d35062164587b Content-Type: text/plain; charset="UTF-8" On Thu, 5 Sept 2024 at 08:49, martin rudalics wrote: > > My bisection suggests the problematic commit is > > 241616831024c9c9fe2b2378b611db0a560b9675 > > Thanks. Please try first setting 'frame-inhibit-implied-resize' to t > which should avoid that a frame gets resized when the menu bar is > enabled or disabled Setting the variable to t does indeed prevent the frame being resized when menu-bar-mode is toggled, but has no effect on the size of the subsequent windows created. If this does not help, please proceed as follows: Try to undo that > commit (I cite it below) I checked out git master HEAD (currently df57e44a08f) and reverted commit 241616831024c9c9fe2b2378b611db0a560b9675 on top of that. and please first run without the commit under > gdb with a breakpoint at the line > > adjust_frame_size (f, -1, -1, 2, 0, Qmenu_bar_lines); > > in xg_update_frame_menubar. Please note all values you see after doing > > p req.height > 50 (before initial frame opens) 50 (after C-x 5 2, before second frame opens) And the second frame opens at the expected size, the same size as the first. Then restore current master and repeat the same steps. When the values > differ, this should tell us something about what happens. > 50 (before initial frame opens) 50 (after C-x 5 2, before second frame opens) But the second frame opens small. --000000000000173d35062164587b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, 5 Sept 2024 at= 08:49, martin rudalics <rudalics@gmx.at> wrote:
=
=C2=A0> My bisection suggests the problematic commit is
=C2=A0> 241616831024c9c9fe2b2378b611db0a560b9675

Thanks.=C2=A0 Please try first setting 'frame-inhibit-implied-resize= 9; to t
which should avoid that a frame gets resized when the menu bar is
enabled or disabled

Sett= ing the variable to t does indeed prevent the frame being resized when menu= -bar-mode is toggled, but has no effect on the size of the subsequent windo= ws created.

If this does not help, please proceed as follows: Try to undo that
commit (I cite it below)

I checked out git master HEAD (currently df57e44a08f) and reverted commit= 241616831024c9c9fe2b2378b611db0a560b9675 on top of that.

and please first run wi= thout the commit under
gdb with a breakpoint at the line

=C2=A0 =C2=A0 =C2=A0 =C2=A0adjust_frame_size (f, -1, -1, 2, 0, Qmenu_bar_li= nes);

in xg_update_frame_menubar.=C2=A0 Please note all values you see after doin= g

p req.height

50 (bef= ore initial frame opens)
50 (after C-x 5 2, bef= ore second frame opens)

And the second frame opens at the expected size, the same size as the fi= rst.

Then restore current = master and repeat the same steps.=C2=A0 When the= values
differ, this should tell us something about what happens.
<= div>
50 (before initial frame opens)
=
50 (after C-x 5 2, before second frame opens)
<= br>
But the second frame opens small.
--000000000000173d35062164587b--