From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#25082: [PATCH] Add support to emacsclient for command-lline options in ALTERNATE_EDITOR/--alternate-editor Date: Fri, 2 Dec 2016 15:31:02 +0000 Message-ID: References: <83y3zymy30.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11411c7635a53e0542aea036 X-Trace: blaine.gmane.org 1480692742 6565 195.159.176.226 (2 Dec 2016 15:32:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2016 15:32:22 +0000 (UTC) Cc: 25082@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 02 16:32:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpou-0000DM-3c for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 16:32:16 +0100 Original-Received: from localhost ([::1]:35153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCpou-0007vB-SQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 10:32:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCpok-0007v5-Pw for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 10:32:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCpog-0000iY-D8 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 10:32:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35077) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCpog-0000iR-9X for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 10:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cCpog-0008Fd-2J for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 10:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2016 15:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25082 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25082-submit@debbugs.gnu.org id=B25082.148069267231655 (code B ref 25082); Fri, 02 Dec 2016 15:32:02 +0000 Original-Received: (at 25082) by debbugs.gnu.org; 2 Dec 2016 15:31:12 +0000 Original-Received: from localhost ([127.0.0.1]:50476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpns-0008EV-41 for submit@debbugs.gnu.org; Fri, 02 Dec 2016 10:31:12 -0500 Original-Received: from mail-lf0-f54.google.com ([209.85.215.54]:36233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpnp-0008EH-5l for 25082@debbugs.gnu.org; Fri, 02 Dec 2016 10:31:10 -0500 Original-Received: by mail-lf0-f54.google.com with SMTP id t196so198164785lff.3 for <25082@debbugs.gnu.org>; Fri, 02 Dec 2016 07:31:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GzFzUBhlPJ8UA/OH8E6pkcFJ1QU6TXULeS4HeTJjRSg=; b=CusRuzuIsJKR3/6q4Ufqb+v5d/sGsRcO0e9cQKopQIIq+wadTnakPXFDybfPY3zawu bDVFIscEvp7RUAecAHgXJ8Kb7p9P7zhVcqh1FPLXzo18ddItGy0jaxvkvO49ftQQdlrw CygmvyZLNL5Zs4EzW7pBvs/wyv/LNtZifaDKU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GzFzUBhlPJ8UA/OH8E6pkcFJ1QU6TXULeS4HeTJjRSg=; b=dA3UhEnn0zVpIy1OVNfqp4NhqTN37rRThIMReMpDKq0vsjY3bz0UBvS/K64rcNh8UN d3zqnoSLsZIAxJD4cvdSB1mGdooMiN/UllU7cL4D2mRReMcZQHJ4cyMhXuvtbB5f0FBc xEoeTk3hpcOS1Dsdc4xHILMdUbye7BLvrujqGJaC+Tt8CQLWzw+o9LqlFVL9QSckAC1i YYLDp68pO24lIoMSWUkEfJ9pnecERtSusKuMRz1BzWxLIZAsH2LTEBWmcj2/Nvu390vg A45wn5OHJZ3aekuwrWCgIxFht2KKDF6VhJLQ3U5aXmalS6GUAHvE8Ce5oZokiGYt2of6 rqJg== X-Gm-Message-State: AKaTC01ET1cX38bCi7lQwmfA2qS7BZ5zSrfkBo5i41x+UMhOEppv3Bke1emHMNAx2NJSB0f+Sbq+A4AQt0v0Uy1x X-Received: by 10.46.71.140 with SMTP id u134mr20510137lja.19.1480692663141; Fri, 02 Dec 2016 07:31:03 -0800 (PST) Original-Received: by 10.25.190.2 with HTTP; Fri, 2 Dec 2016 07:31:02 -0800 (PST) In-Reply-To: <83y3zymy30.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126417 Archived-At: --001a11411c7635a53e0542aea036 Content-Type: multipart/alternative; boundary=001a11411c7635a5270542aea034 --001a11411c7635a5270542aea034 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2 December 2016 at 10:20, Eli Zaretskii wrote: > Does this work if -batch is added to the switches? =E2=80=8BIt depends what you mean by "work". Since, according to the origin= al implementation, only non-option are passed to the ALTERNATE_EDITOR, =E2=80=8Bnothing useful happens (that I can see), because Emacs is run as emacs --batch file1 file2 # etc. and so it starts up and immediately shuts down. If, for example you try to run export ALTERNATE_EDITOR=3D"emacs --batch" emacsclient --eval "(print t)" then the actual process run is: emacs --batch "(print t)" which again does nothing useful. But maybe that's OK, because I am guessing you ask this because: If so, can you add > =E2=80=8B =E2=80=8B > a test for this capability? > =E2=80=8BThere seems to be nothing much to check, other than that it return= s 0, but that is already sufficient, since with the current implementation, export ALTERNATE_EDITOR=3D"emacs --batch" emacsclient foo Gives the error: emacsclient: error executing alternate editor "emacs --batch". =E2=80=8BSo, I tried to write a test. It works fine except that it doesn't = run the right emacsclient binary (instead, it runs the one on my PATH). Since I can't see any other tests that run built executables from the source tree, I'm not sure how I should go about this (modify PATH? Explicitly patch in srcdir somehow?). Hints appreciated. I attach an updated patch with the test so far. --=20 http://rrt.sc3d.org --001a11411c7635a5270542aea034 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 2 December 2016 at 10:20, Eli Zaretskii <eliz@gnu.org> wrote:
=
Does this work if -batch is added to the switches?

=E2=80=8BIt depends what you mean by "work". Since, according= to the original implementation, only non-option are passed to the ALTERNAT= E_EDITOR, =E2=80=8Bnothing useful happens (that I can see), because Emacs i= s run as

emacs --batch fi= le1 file2 # etc.

and so i= t starts up and immediately shuts down. If, for example you try to run

export ALTERNATE_EDITOR= =3D"emacs --batch"
emacsclient --eval "(print t)"

then the actual process run is:

emacs --batch "(print t)"

which again does nothing us= eful. But maybe that's OK, because I am guessing you ask this because:<= /div>

If so, can you add
=E2=80=8B = =E2=80=8B
a test for this capability?

=E2=80=8BThere seems to be nothing much= to check, other than that it returns 0, but that is already sufficient, si= nce with the current implementation,

export ALTERNATE_EDITOR=3D"emacs --batch"
emacsclient foo

Gives the error:

emacsclient: error executing alternate edit= or "emacs --batch".

=E2=80=8BSo, I tried to write a test. It= works fine except that it doesn't run the right emacsclient binary (in= stead, it runs the one on my PATH).

Since I can't see any other tests that run built execu= tables from the source tree, I'm not sure how I should go about this (m= odify PATH? Explicitly patch in srcdir somehow?). Hints appreciated.
<= div class=3D"gmail_default" style=3D"font-size:small">
I attach an updated patch with= the test so far.

--
http://rrt.sc3d.org
--001a11411c7635a5270542aea034-- --001a11411c7635a53e0542aea036 Content-Type: text/x-patch; charset=US-ASCII; name="0005-Add-support-for-arguments-in-ALTERNATE_EDITOR-to-ema.patch" Content-Disposition: attachment; filename="0005-Add-support-for-arguments-in-ALTERNATE_EDITOR-to-ema.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iw7y5y790 RnJvbSAyMGY4YjEyY2I2NjdkOTliZDYyZGRhMzM4NTU4Yzc5N2YyOWY2ODYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFRo dSwgMSBEZWMgMjAxNiAxNToyMTo1NyArMDAwMApTdWJqZWN0OiBbUEFUQ0ggNS81XSBBZGQgc3Vw cG9ydCBmb3IgYXJndW1lbnRzIGluIEFMVEVSTkFURV9FRElUT1IgdG8KIGVtYWNzY2xpZW50Cgoq IGxpYi1zcmMvZW1hY3NjbGllbnQuYyAoZmFpbCk6IFBhcnNlIEFMVEVSTkFURV9FRElUT1IsIG9y CmNvcnJlc3BvbmRpbmcgY29tbWFuZC1saW5lIGFyZ3VtZW50LCBpbnRvIHNwYWNlLXNlcGFyYXRl ZCB0b2tlbnMuCiogZXRjL05FV1M6IERvY3VtZW50LgotLS0KIGV0Yy9ORVdTICAgICAgICAgICAg ICB8ICA0ICsrKwogbGliLXNyYy9lbWFjc2NsaWVudC5jIHwgNzMgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDU5IGlu c2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRj L05FV1MKaW5kZXggMzNiOGE0Mi4uYzRmNDU2OSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIv ZXRjL05FV1MKQEAgLTI2OCw2ICsyNjgsMTAgQEAgdmFyaWFibGUgb2YgdGhpcyBraW5kIHRvIHN3 YXAgbW9kaWZpZXJzIGluIEVtYWNzLgogLS0tCiAqKiBOZXcgaW5wdXQgbWV0aG9kczogJ2N5cmls bGljLXR1dmFuJywgJ3BvbGlzaC1wcmVmaXgnLgogCisrKworKiogZW1hY3NjbGllbnQgbm93IGFj Y2VwdHMgY29tbWFuZC1saW5lIG9wdGlvbnMgaW4gQUxURVJOQVRFX0VESVRPUgorYW5kIC0tYWx0 ZXJuYXRlLWVkaXRvci4gRm9yIGV4YW1wbGUsIEFMVEVSTkFURV9FRElUT1I9ImVtYWNzIC1RIC1u dyIuCisKIAwKICogRWRpdGluZyBDaGFuZ2VzIGluIEVtYWNzIDI2LjEKIApkaWZmIC0tZ2l0IGEv bGliLXNyYy9lbWFjc2NsaWVudC5jIGIvbGliLXNyYy9lbWFjc2NsaWVudC5jCmluZGV4IDI5MDlk NjMuLmI1NjFkYjYgMTAwNjQ0Ci0tLSBhL2xpYi1zcmMvZW1hY3NjbGllbnQuYworKysgYi9saWIt c3JjL2VtYWNzY2xpZW50LmMKQEAgLTEwOSw2ICsxMDksOSBAQCBjaGFyICp3MzJfZ2V0ZW52IChj b25zdCBjaGFyICopOwogLyogTmFtZSB1c2VkIHRvIGludm9rZSB0aGlzIHByb2dyYW0uICAqLwog Y29uc3QgY2hhciAqcHJvZ25hbWU7CiAKKy8qIFRoZSBmaXJzdCBhcmd1bWVudCB0byBtYWluLiAg Ki8KK2ludCBtYWluX2FyZ2M7CisKIC8qIFRoZSBzZWNvbmQgYXJndW1lbnQgdG8gbWFpbi4gICov CiBjaGFyICoqbWFpbl9hcmd2OwogCkBAIC0xOTIsNiArMTk1LDM1IEBAIHhtYWxsb2MgKHNpemVf dCBzaXplKQogICByZXR1cm4gcmVzdWx0OwogfQogCisvKiBMaWtlIHJlYWxsb2MgYnV0IGdldCBm YXRhbCBlcnJvciBpZiBtZW1vcnkgaXMgZXhoYXVzdGVkLiAgKi8KKworc3RhdGljIHZvaWQgKgor eHJlYWxsb2MgKHZvaWQgKnB0ciwgc2l6ZV90IHNpemUpCit7CisgIHZvaWQgKnJlc3VsdCA9IHJl YWxsb2MgKHB0ciwgc2l6ZSk7CisgIGlmIChyZXN1bHQgPT0gTlVMTCkKKyAgICB7CisgICAgICBw ZXJyb3IgKCJyZWFsbG9jIik7CisgICAgICBleGl0IChFWElUX0ZBSUxVUkUpOworICAgIH0KKyAg cmV0dXJuIHJlc3VsdDsKK30KKworLyogTGlrZSBzdHJkdXAgYnV0IGdldCBhIGZhdGFsIGVycm9y IGlmIG1lbW9yeSBpcyBleGhhdXN0ZWQuICovCitjaGFyICp4c3RyZHVwIChjb25zdCBjaGFyICop OworCitjaGFyICoKK3hzdHJkdXAgKGNvbnN0IGNoYXIgKnMpCit7CisgIGNoYXIgKnJlc3VsdCA9 IHN0cmR1cCAocyk7CisgIGlmIChyZXN1bHQgPT0gTlVMTCkKKyAgICB7CisgICAgICBwZXJyb3Ig KCJzdHJkdXAiKTsKKyAgICAgIGV4aXQgKEVYSVRfRkFJTFVSRSk7CisgICAgfQorICByZXR1cm4g cmVzdWx0OworfQorCiAvKiBGcm9tIHN5c2RlcC5jICovCiAjaWYgIWRlZmluZWQgKEhBVkVfR0VU X0NVUlJFTlRfRElSX05BTUUpIHx8IGRlZmluZWQgKEJST0tFTl9HRVRfQ1VSUkVOVF9ESVJfTkFN RSkKIApAQCAtMjU1LDIxICsyODcsNiBAQCBnZXRfY3VycmVudF9kaXJfbmFtZSAodm9pZCkKIAog I2lmZGVmIFdJTkRPV1NOVAogCi0vKiBMaWtlIHN0cmR1cCBidXQgZ2V0IGEgZmF0YWwgZXJyb3Ig aWYgbWVtb3J5IGlzIGV4aGF1c3RlZC4gKi8KLWNoYXIgKnhzdHJkdXAgKGNvbnN0IGNoYXIgKik7 Ci0KLWNoYXIgKgoteHN0cmR1cCAoY29uc3QgY2hhciAqcykKLXsKLSAgY2hhciAqcmVzdWx0ID0g c3RyZHVwIChzKTsKLSAgaWYgKHJlc3VsdCA9PSBOVUxMKQotICAgIHsKLSAgICAgIHBlcnJvciAo InN0cmR1cCIpOwotICAgICAgZXhpdCAoRVhJVF9GQUlMVVJFKTsKLSAgICB9Ci0gIHJldHVybiBy ZXN1bHQ7Ci19Ci0KICNkZWZpbmUgUkVHX1JPT1QgIlNPRlRXQVJFXFxHTlVcXEVtYWNzIgogCiBj aGFyICp3MzJfZ2V0X3Jlc291cmNlIChIS0VZLCBjb25zdCBjaGFyICosIExQRFdPUkQpOwpAQCAt NjUxLDcgKzY2OCw3IEBAIFJlcG9ydCBidWdzIHdpdGggTS14IHJlcG9ydC1lbWFjcy1idWcuXG4i KTsKIH0KIAogLyogVHJ5IHRvIHJ1biBhIGRpZmZlcmVudCBjb21tYW5kLCBvciAtLWlmIG5vIGFs dGVybmF0ZSBlZGl0b3IgaXMKLSAgIGRlZmluZWQtLSBleGl0IHdpdGggYW4gZXJyb3Jjb2RlLgor ICAgZGVmaW5lZC0tIGV4aXQgd2l0aCBhbiBkZWNvZGVyZGUuCiAgICBVc2VzIGFyZ3YsIGJ1dCBn ZXRzIGl0IGZyb20gdGhlIGdsb2JhbCB2YXJpYWJsZSBtYWluX2FyZ3YuICAqLwogCiBzdGF0aWMg X05vcmV0dXJuIHZvaWQKQEAgLTY1OSw5ICs2NzYsMjcgQEAgZmFpbCAodm9pZCkKIHsKICAgaWYg KGFsdGVybmF0ZV9lZGl0b3IpCiAgICAgewotICAgICAgaW50IGkgPSBvcHRpbmQgLSAxOworICAg ICAgc2l6ZV90IGV4dHJhX2FyZ3Nfc2l6ZSA9IChtYWluX2FyZ2MgLSBvcHRpbmQgKyAxKSAqIHNp emVvZiAoY2hhciAqKTsKKyAgICAgIHNpemVfdCBuZXdfYXJndl9zaXplID0gZXh0cmFfYXJnc19z aXplOworICAgICAgY2hhciAqKm5ld19hcmd2ID0gTlVMTDsKKyAgICAgIC8qIE5lZWRlZCBiZWNh dXNlIHN0cnRvayBvdmVyd3JpdGVzIGl0cyBpbnB1dC4gICovCisgICAgICBjaGFyICpzID0geHN0 cmR1cCAoYWx0ZXJuYXRlX2VkaXRvcik7CisgICAgICB1bnNpZ25lZCB0b2tzID0gMDsKKyAgICAg IGNoYXIgKnRvayA9IHN0cnRvayhzLCAiICIpOworCisgICAgICAvKiBVbnBhY2sgYWx0ZXJuYXRl X2VkaXRvcidzIHNwYWNlLXNlcGFyYXRlZCB0b2tlbnMgaW50byBuZXdfYXJndi4gICovCisgICAg ICBkbworICAgICAgICB7CisgICAgICAgICAgdG9rcysrOworICAgICAgICAgIG5ld19hcmd2ID0g eHJlYWxsb2MgKG5ld19hcmd2LCBuZXdfYXJndl9zaXplICsgdG9rcyAqIHNpemVvZiAoY2hhciAq KSk7CisgICAgICAgICAgbmV3X2FyZ3ZbdG9rcyAtIDFdID0gdG9rOworICAgICAgICB9CisgICAg ICB3aGlsZSAoKHRvayA9IHN0cnRvayAoTlVMTCwgIiAiKSkpOworCisgICAgICAvKiBBcHBlbmQg bWFpbl9hcmd2IGFyZ3VtZW50cyB0byBuZXdfYXJndi4gICovCisgICAgICBtZW1jcHkgKCZuZXdf YXJndlt0b2tzXSwgbWFpbl9hcmd2ICsgb3B0aW5kLCBleHRyYV9hcmdzX3NpemUpOwogCi0gICAg ICBleGVjdnAgKGFsdGVybmF0ZV9lZGl0b3IsIG1haW5fYXJndiArIGkpOworICAgICAgZXhlY3Zw IChzLCBuZXdfYXJndik7CiAgICAgICBtZXNzYWdlICh0cnVlLCAiJXM6IGVycm9yIGV4ZWN1dGlu ZyBhbHRlcm5hdGUgZWRpdG9yIFwiJXNcIlxuIiwKIAkgICAgICAgcHJvZ25hbWUsIGFsdGVybmF0 ZV9lZGl0b3IpOwogICAgIH0KQEAgLTY3NCw2ICs3MDksNyBAQCBmYWlsICh2b2lkKQogaW50CiBt YWluIChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiB7CisgIG1haW5fYXJnYyA9IGFyZ2M7CiAgIG1h aW5fYXJndiA9IGFyZ3Y7CiAgIHByb2duYW1lID0gYXJndlswXTsKICAgbWVzc2FnZSAodHJ1ZSwg IiVzOiBTb3JyeSwgdGhlIEVtYWNzIHNlcnZlciBpcyBzdXBwb3J0ZWQgb25seVxuIgpAQCAtMTYw Nyw2ICsxNjQzLDcgQEAgbWFpbiAoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogICBpbnQgc3RhcnRf ZGFlbW9uX2lmX25lZWRlZDsKICAgaW50IGV4aXRfc3RhdHVzID0gRVhJVF9TVUNDRVNTOwogCisg IG1haW5fYXJnYyA9IGFyZ2M7CiAgIG1haW5fYXJndiA9IGFyZ3Y7CiAgIHByb2duYW1lID0gYXJn dlswXTsKIAotLSAKMi43LjQKCg== --001a11411c7635a53e0542aea036--