From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries Date: Tue, 20 Dec 2016 21:45:24 +0000 Message-ID: References: <831sx36g75.fsf@gnu.org> <837f6u4nmx.fsf@gnu.org> <83eg122xzf.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0cc9ac3129b905441df415 X-Trace: blaine.gmane.org 1482270376 14045 195.159.176.226 (20 Dec 2016 21:46:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Dec 2016 21:46:16 +0000 (UTC) Cc: 25230@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 20 22:46:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJSEb-0002dc-0p for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Dec 2016 22:46:09 +0100 Original-Received: from localhost ([::1]:53604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJSEf-00075O-9b for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Dec 2016 16:46:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJSEX-00075E-PC for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 16:46:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJSEU-00038i-NA for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 16:46:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cJSEU-00038Q-Js for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 16:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cJSEU-0006DZ-5h for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 16:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Dec 2016 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25230-submit@debbugs.gnu.org id=B25230.148227033323856 (code B ref 25230); Tue, 20 Dec 2016 21:46:02 +0000 Original-Received: (at 25230) by debbugs.gnu.org; 20 Dec 2016 21:45:33 +0000 Original-Received: from localhost ([127.0.0.1]:49383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJSE0-0006Ch-N3 for submit@debbugs.gnu.org; Tue, 20 Dec 2016 16:45:33 -0500 Original-Received: from mail-qk0-f181.google.com ([209.85.220.181]:33526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJSDy-0006CP-Ik for 25230@debbugs.gnu.org; Tue, 20 Dec 2016 16:45:30 -0500 Original-Received: by mail-qk0-f181.google.com with SMTP id t184so62518406qkd.0 for <25230@debbugs.gnu.org>; Tue, 20 Dec 2016 13:45:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fToIBwyMcBd25fM6tL4hdpLh0nlgq4hMLb94ICKHs8s=; b=s50fgnbaB8rz3QJWWXsz82GUfZcEDHXzHAgxoih9x9X9emn3F2Ps+r9m5TPL1cmMCp /yc+ugJb6VYbsEFZl35y+yfprbXcuQZo9DOV4YzuygqXOu3VhnD1nM20wNDV6onUS4wV I4Yu+7oI4xq+BqWQtgHeXaRcf5GdFuNXsS/k0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fToIBwyMcBd25fM6tL4hdpLh0nlgq4hMLb94ICKHs8s=; b=S2DHv0jZO0IVDB+a6wmssi8bmwudsieph6mjMYYY23Z4EcBwuuEHWB17d5Q8CVaasJ 11sBXqCouHUyRBv+7A4eFWPXg01QFtopeeFaMNtZqvW23RNfVAHTINhBqKF/cqTfJxo5 AC0uRGvGWSMFJ4Vt6KVGVOhY5W/IPwlq2PbcYx2d5NcdTWpAURoOY1GqNzMErScUQ0hO LCKTSt9RaTwzvbLmDRGaVnotQgJ8lEZccFEX2x3UUBX85yIZFXnVGz10P6O7w7RHsVha ja7/hGAVAMsr/cjaBk0d4pcqOhLhN+uOMn+lrJPDavcg0w3xeYgObgbZ58j7tCOzntgD JYcw== X-Gm-Message-State: AIkVDXIubNzckgi57DnRDzNja8QjA/0ZWKl4/0h6QUKJAPT15CMkeT2IFzMTTDTEuuPVIYGM+Borxb9umcyhdG/7 X-Received: by 10.55.220.69 with SMTP id v66mr1681587qki.264.1482270325147; Tue, 20 Dec 2016 13:45:25 -0800 (PST) Original-Received: by 10.140.88.51 with HTTP; Tue, 20 Dec 2016 13:45:24 -0800 (PST) In-Reply-To: <83eg122xzf.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127271 Archived-At: --94eb2c0cc9ac3129b905441df415 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 20 December 2016 at 19:37, Eli Zaretskii wrote: > > From: Reuben Thomas > > Date: Tue, 20 Dec 2016 18:42:05 +0000 > > Cc: 25230@debbugs.gnu.org > > > > > =E2=80=8BNo, because my patch does not change the current behaviour = of the > code. The assumption that > > [:alpha:] is OK to use here instead of A-Za-z is already in the code.= =E2=80=8B > > > > Can you point out where in the code you see that assumption? > > > > The current code in about line 1300 (ispell-set-spellchecker-params) > unconditionally overrides all the built-in > > dictionaries' values for casechars and not-casechars with [:alpha:] in > the loop that starts > > > > (dolist (adict ispell-dictionary-alist) =E2=80=A6) > > That's the place where you suggested to keep the original values. I > thought there were other places, but it's good to know there are none. > =E2=80=8BI believe not, indeed.=E2=80=8B > I think so, but we should make sure the hard-wired values work with > > Aspell, before we make that change. If they don't, we should provide > > something that works for Aspell. > > > > =E2=80=8BI thought the hard-wired values were only for ispell dictionar= ies (for > aspell, the dictionaries are searched for on > > the computer)=E2=80=A6 > > But if we find that an installed dictionary is one of those in the > data base of the hard-wired values, we use those values, right? > =E2=80=8BNo, for aspell, we should only be using aspell dictionaries (found= by ispell-find-aspell-dictionaries).=E2=80=8B > Because AFAIK Aspell provides only one of the 3 character sets we need > in its dictionaries, the other 2 need to be somehow guessed or > provided by the user. > =E2=80=8BThey are guessed as [:alpha:], because we don't have better inform= ation (that I know of). --=20 http://rrt.sc3d.org --94eb2c0cc9ac3129b905441df415 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 20 December 2016 at 19:37, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Tue, 20 Dec 2016 18:42:05 +0000
> Cc: 25230@debbugs.gnu.org=
>
>=C2=A0 > =E2=80=8BNo, because my patch does not change the current b= ehaviour of the code. The assumption that
>=C2=A0 [:alpha:] is OK to use here instead of A-Za-z is already in the = code.=E2=80=8B
>
>=C2=A0 Can you point out where in the code you see that assumption?
>
> The current code in about line 1300 (ispell-set-spellchecker-para= ms) unconditionally overrides all the built-in
> dictionaries' values for casechars and not-casechars with [:alpha:= ] in the loop that starts
>
> (dolist (adict ispell-dictionary-alist)=E2=80=88=E2=80=A6)

That's the place where you suggested to keep the original values= .=C2=A0 I
thought there were other places, but it's good to know there are none.<= br>

=E2=80=8BI believe not, indeed.=E2=80=8B
>=C2=A0 I think so, but we should make sure the hard-wired values work w= ith
>=C2=A0 Aspell, before we make that change. If they don't, we should= provide
>=C2=A0 something that works for Aspell.
>
> =E2=80=8BI thought the hard-wired values were only for ispell dictiona= ries (for aspell, the dictionaries are searched for on
> the computer)=E2=80=A6

But if we find that an installed dictionary is one of those in the data base of the hard-wired values, we use those values, right?

=E2=80=8BNo, for aspell, we should only be using aspell dictionaries (= found by ispell-find-aspell-dictionaries).=E2=80=8B
=C2=A0<= /div>
Because AFAIK Aspell provides only one of the 3 character sets we need
in its dictionaries, the other 2 need to be somehow guessed or
provided by the user.

=E2=80=8BThey are guessed as [:alpha:], because we don't have better= information (that I know of).

--
http://rrt.sc3d.org
--94eb2c0cc9ac3129b905441df415--