From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#32651: flyspell marks doublons when not the same case Date: Thu, 6 Sep 2018 20:37:04 +0100 Message-ID: References: <837ejywhbd.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000eae8b0575390478" X-Trace: blaine.gmane.org 1536262568 7871 195.159.176.226 (6 Sep 2018 19:36:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Sep 2018 19:36:08 +0000 (UTC) Cc: 32651@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 06 21:36:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fy04R-0001vf-MY for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Sep 2018 21:36:03 +0200 Original-Received: from localhost ([::1]:35207 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fy06Y-0000m7-7p for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Sep 2018 15:38:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fy06R-0000ju-8a for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 15:38:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fy06M-0004Vd-NG for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 15:38:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43405) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fy06M-0004VS-Jc for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 15:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fy06M-0006zu-ER for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 15:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Sep 2018 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32651 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32651-submit@debbugs.gnu.org id=B32651.153626263326817 (code B ref 32651); Thu, 06 Sep 2018 19:38:02 +0000 Original-Received: (at 32651) by debbugs.gnu.org; 6 Sep 2018 19:37:13 +0000 Original-Received: from localhost ([127.0.0.1]:48423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fy05Y-0006yT-Pb for submit@debbugs.gnu.org; Thu, 06 Sep 2018 15:37:13 -0400 Original-Received: from mail-oi0-f54.google.com ([209.85.218.54]:42962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fy05X-0006yG-BX for 32651@debbugs.gnu.org; Thu, 06 Sep 2018 15:37:11 -0400 Original-Received: by mail-oi0-f54.google.com with SMTP id v198-v6so5123643oif.9 for <32651@debbugs.gnu.org>; Thu, 06 Sep 2018 12:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EEIB0UD+sICpYjSxQnCCn07bq28bZJaYW6Bx32hGysM=; b=bQYbQD/OM/UnMMsAfZi3G/OpM0BR8+R4t4Sas4usOav91Kq4N2bMGgph3jyt40LNDC niLrmfXnfyCmxWC5nTDWjLIHDIezdyvHGImpkufH41e93lEW5TxCiFRUADxWN7RfWhEH 6MIRJzNjrKopuYtCb30X6n9r0kai9eWZS/vCM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EEIB0UD+sICpYjSxQnCCn07bq28bZJaYW6Bx32hGysM=; b=WKyhq/6vcaQfE3QyK1NS4Y7e7+hAeKHT6s7kWKDEGZjCSJzbSgTjoL+xGdU+nJCrKT IUh7ThmnjUhL0WnJviUBhqx80mqdlhlyo63/wryY9OK59RF+Np3CNUaC8ZSocLW28YAI sr0ySeVhyzC0GdnoWE0nsB4Gm+p8/+GsXpY85heGA/6SiY5bvMxDDlEhXEAKv3J0qcb8 xw1febhWv9ir8iNYW6hqYe/BOiOPlfkdUdWYne9l2dHFLWY1hC15yc4YlnumHtZjdEFe msjGoOZHdwp07boboW+GehBYsF5h7+Q62phqEd+IHbi/bZEN3/hd+uZSZAXyrg6tFtwo Coyw== X-Gm-Message-State: APzg51Cij+ygGcoslrdFualjCnWBBVafFS3kHOWPPA62LCV/QxK+2ogA F7YCPV/BP2v4AfXp4QYldinO4cWLRRFoqJwVcdkxOA== X-Google-Smtp-Source: ANB0VdbKTdXqf7ZBTwPGBmw4Ts1qo1EpXErvLoWrNbC3BzfBBKtQh3K1p9tebju+naxkOrpbtZKscmWyQAo73rv+MoA= X-Received: by 2002:aca:b641:: with SMTP id g62-v6mr4192511oif.71.1536262625205; Thu, 06 Sep 2018 12:37:05 -0700 (PDT) Original-Received: by 2002:a9d:23c8:0:0:0:0:0 with HTTP; Thu, 6 Sep 2018 12:37:04 -0700 (PDT) In-Reply-To: <837ejywhbd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150093 Archived-At: --0000000000000eae8b0575390478 Content-Type: text/plain; charset="UTF-8" On 6 September 2018 at 20:34, Eli Zaretskii wrote: > > From: Reuben Thomas > > Date: Thu, 6 Sep 2018 20:16:10 +0100 > > > > Flyspell marks for example the second "AND" in "an AND split and AND > join" as a duplicate. > > > > This seems to be deliberate: in line 1153 of flyspell.el (on current > emacs-26 branch) > > flyspell-word-search-backward is called with IGNORE-CASE set to t. > > > > I don't understand this: if it's not the same case, it's probably > deliberate, no? > > > > I checked that simply removing this `t' argument makes doublon detection > work as I'd expect: "AND AND", > > "and and" and "And And" are all marked as doublons, but anything that's > not the same case isn't. > > There are valid use cases where the current behavior is what the users > want (e.g., "And and" at the beginning of a sentence). So we could > introduce an option to do what you want, but I don't think we can > change the default behavior unconditionally. > I am suggesting the above example is not a valid use case, because it's unlikely that someone would type that by mistake; rather, it's typing the same identical word twice that is the common error. -- https://rrt.sc3d.org --0000000000000eae8b0575390478 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On 6= September 2018 at 20:34, Eli Zaretskii <eliz@gnu.org> wrote:
=
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Thu, 6 Sep 2018 20:16:10 +0100
>
> Flyspell marks for example the second "AND" in "an AND = split and AND join" as a duplicate.
>
> This seems to be deliberate: in line 1153 of flyspell.el (on current e= macs-26 branch)
> flyspell-word-search-backward is called with IGNORE-CASE set to t.
>
> I don't understand this: if it's not the same case, it's p= robably deliberate, no?
>
> I checked that simply removing this `t' argument makes doublon det= ection work as I'd expect: "AND AND",
> "and and" and "And And" are all marked as doublons= , but anything that's not the same case isn't.

There are valid use cases where the current behavior is what the users
want (e.g., "And and" at the beginning of a sentence).=C2=A0 So w= e could
introduce an option to do what you want, but I don't think we can
change the default behavior unconditionally.

I am suggesting the above example= is not a valid use case, because it's unlikely that someone would type= that by mistake; rather, it's typing the same identical word twice tha= t is the common error.

--
--0000000000000eae8b0575390478--