From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Reuben Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#4422: diff-switches is a bad idea Date: Tue, 1 Oct 2019 14:29:28 +0100 Message-ID: References: <87d0fg7gey.fsf@gnus.org> Reply-To: Reuben Thomas Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002d549b0593d958bb" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="44191"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 4422@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 01 15:31:41 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFIFh-000BKn-Fs for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 15:31:41 +0200 Original-Received: from localhost ([::1]:42184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIFf-00047U-Mm for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 09:31:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57003) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFIE8-0002yt-Or for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 09:30:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFIE6-00045k-M4 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 09:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52280) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFIE6-00044I-Bh for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 09:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFIE6-0007S1-42 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4422 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 4422-submit@debbugs.gnu.org id=B4422.156993659028592 (code B ref 4422); Tue, 01 Oct 2019 13:30:02 +0000 Original-Received: (at 4422) by debbugs.gnu.org; 1 Oct 2019 13:29:50 +0000 Original-Received: from localhost ([127.0.0.1]:32868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFIDt-0007R3-Sd for submit@debbugs.gnu.org; Tue, 01 Oct 2019 09:29:50 -0400 Original-Received: from mail-oi1-f170.google.com ([209.85.167.170]:34018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFIDp-0007Ql-SG for 4422@debbugs.gnu.org; Tue, 01 Oct 2019 09:29:46 -0400 Original-Received: by mail-oi1-f170.google.com with SMTP id 83so14413900oii.1 for <4422@debbugs.gnu.org>; Tue, 01 Oct 2019 06:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I5CGQ5mP95dMbtOd87jVW1yyE7dRZEayblHAk3oMZjc=; b=N1EEWIUdWJrCMgKBLUXpQFxM1jBl5I47MLzy7aVJOiYauuvW04CqytIBAMxBJ5OIYM I4H4shIbs73caV+TT37bt/evgNnC/nzoAjo9VC7Ndu71Ihq3guWEqH5Bb2nZ/2huqwM6 zfRyXBkTOyEjNaoem4kF27KPphJrqIwHbbMoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I5CGQ5mP95dMbtOd87jVW1yyE7dRZEayblHAk3oMZjc=; b=UVPb/9Pe7e8P6uj8qlI8QBQ6E4kRdxP/ThkFQLW7sOtS0SBxkRVfXkz3IIHF9atW2g Q75A17RngpAd2YLS06BIncgbaIjkxeuVE3Ul2e3M4Um8cbJBNlk9wi+oZWd2zoaLBOn/ /J85nHO8qnSWAryRxGdxKEfzJZ2UUTUMuaDSkUlMdoVp4eOWd2QA7i74GiaQiDxcRQ2n 7o2VFh1tV9hb/WpgMGVGRXX4+kx9kyI9NvnEHf0aGQKtKAH2AXpvE4xXoWFbLGcH4bGs 4vXY4/Sgmom+AvIbPB+0hMBRGK/rQBxJVYaMQsJ8uNSfZRIRHnXXDKM+dczhXDjS3KqB g8rQ== X-Gm-Message-State: APjAAAV/FoONn/CdUoHBbm4+tH8F6OEtLEAcN9S2n9qAhnwjBIJ3wEHY XJ2DiaB3jL4eq/vk5D7MokHlmqQ+ppjdHG/fJAsSwg== X-Google-Smtp-Source: APXvYqwUgJZtWlkM0Vg0EdaxFoMNlF4Js+8zbudgdguzYb5jc6iSjmQf6gzJle/DYlTcJ83/Xqn9TLD2leXQAx7nlxM= X-Received: by 2002:aca:d408:: with SMTP id l8mr3732718oig.113.1569936580087; Tue, 01 Oct 2019 06:29:40 -0700 (PDT) In-Reply-To: <87d0fg7gey.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167996 Archived-At: --0000000000002d549b0593d958bb Content-Type: text/plain; charset="UTF-8" On Tue, 1 Oct 2019 at 14:18, Lars Ingebrigtsen wrote: > > I'm not extremely familiar with the vc code, but looking at it in Emacs > 27, at least, the switches for diff in CVS comes from > vc-cvs-diff-switches, if I read the `vc-switches' function correctly. > > So has this problem gone away in the years since this was reported? > Not as far as I can tell. It is still necessary for me to set `vc-diff-switches` explicitly, e.g. to `t`, meaning "no switches". From the docstring for vc-switches: In decreasing order of preference, return the value of: vc-BACKEND-OP-switches (e.g. `vc-cvs-diff-switches'); vc-OP-switches (e.g. `vc-diff-switches'); or, in the case of diff only, `diff-switches'. In other words, `diff-switches` is still used by vc.el, and I still think that's a bad idea. -- https://rrt.sc3d.org --0000000000002d549b0593d958bb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, 1 Oct 2019 at 14:18, Lars Ingebrigtsen <larsi@gnus.org> wrote:

I'm not extremely familiar with the vc code, but looking at it in Emacs=
27, at least, the switches for diff in CVS comes from
vc-cvs-diff-switches, if I read the `vc-switches' function correctly.
So has this problem gone away in the years since this was reported?

Not as far as I can tell. I= t is still necessary for me to set `vc-diff-switches` explicitly, e.g. to `= t`, meaning "no switches". From the docstring for vc-switches:

In decreasing order of p= reference, return the value of:
vc-BACKEND-OP-switches (e.g. `vc-cvs-dif= f-switches');
vc-OP-switches (e.g. `vc-diff-switches'); or, in t= he case of
diff only, `diff-switches'.
=

In other words, `diff-switches= ` is still used by vc.el, and I still think that's a bad idea.

--
--0000000000002d549b0593d958bb--