From: Reuben Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 4422@debbugs.gnu.org
Subject: bug#4422: diff-switches is a bad idea
Date: Tue, 1 Oct 2019 14:29:28 +0100 [thread overview]
Message-ID: <CAOnWdoiNL9i5Td5VWxbUsiy4ypES7d_b4T-HBP8-kyHe1q5-RA@mail.gmail.com> (raw)
In-Reply-To: <87d0fg7gey.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
On Tue, 1 Oct 2019 at 14:18, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> I'm not extremely familiar with the vc code, but looking at it in Emacs
> 27, at least, the switches for diff in CVS comes from
> vc-cvs-diff-switches, if I read the `vc-switches' function correctly.
>
> So has this problem gone away in the years since this was reported?
>
Not as far as I can tell. It is still necessary for me to set
`vc-diff-switches` explicitly, e.g. to `t`, meaning "no switches". From the
docstring for vc-switches:
In decreasing order of preference, return the value of:
vc-BACKEND-OP-switches (e.g. `vc-cvs-diff-switches');
vc-OP-switches (e.g. `vc-diff-switches'); or, in the case of
diff only, `diff-switches'.
In other words, `diff-switches` is still used by vc.el, and I still think
that's a bad idea.
--
https://rrt.sc3d.org
[-- Attachment #2: Type: text/html, Size: 1796 bytes --]
next prev parent reply other threads:[~2019-10-01 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 12:18 bug#4422: diff-switches is a bad idea Reuben Thomas
2019-10-01 13:18 ` Lars Ingebrigtsen
2019-10-01 13:29 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2019-10-01 13:42 ` Eli Zaretskii
2019-10-02 11:47 ` Lars Ingebrigtsen
2019-10-02 15:16 ` Eli Zaretskii
2019-10-03 14:33 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOnWdoiNL9i5Td5VWxbUsiy4ypES7d_b4T-HBP8-kyHe1q5-RA@mail.gmail.com \
--to=bug-gnu-emacs@gnu.org \
--cc=4422@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).