From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#28319: emacsclient tests interfere with running Emacs, hang Date: Fri, 1 Sep 2017 21:37:40 +0100 Message-ID: References: <9swp5iqsmt.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113ce08c79fb84055826bb1d" X-Trace: blaine.gmane.org 1504298307 7356 195.159.176.226 (1 Sep 2017 20:38:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 1 Sep 2017 20:38:27 +0000 (UTC) Cc: 28319@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 01 22:38:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnshh-0001D1-GV for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Sep 2017 22:38:13 +0200 Original-Received: from localhost ([::1]:59471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnsho-0003aV-5f for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Sep 2017 16:38:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnsha-0003Vs-D5 for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2017 16:38:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnshX-0008NL-9r for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2017 16:38:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60197) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnshX-0008NG-68 for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2017 16:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dnshW-0008GI-VL for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2017 16:38:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Sep 2017 20:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28319 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28319-submit@debbugs.gnu.org id=B28319.150429826831724 (code B ref 28319); Fri, 01 Sep 2017 20:38:02 +0000 Original-Received: (at 28319) by debbugs.gnu.org; 1 Sep 2017 20:37:48 +0000 Original-Received: from localhost ([127.0.0.1]:40643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnshI-0008Fc-64 for submit@debbugs.gnu.org; Fri, 01 Sep 2017 16:37:48 -0400 Original-Received: from mail-oi0-f41.google.com ([209.85.218.41]:34504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnshG-0008FP-S5 for 28319@debbugs.gnu.org; Fri, 01 Sep 2017 16:37:47 -0400 Original-Received: by mail-oi0-f41.google.com with SMTP id w10so10727359oie.1 for <28319@debbugs.gnu.org>; Fri, 01 Sep 2017 13:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RZL+wfFQKUEdFAsG5cc5vHZfD+T2WnYnKNUpLUXGTZM=; b=IvMgaPe/ZnsPydV0nwXqoesA6A845kINQ0f615eyJk0wCUoDe3RGO7UbVbBOT9hAWd WgwEoeVTIjEg4Df/z/NEU1KNmQwyAeYKGlehYfgGKbms1uKTJ1va5yyNH0TSkv+emdsi 8S3Nj4V5KZX3MJAJAv/7u2fuM1yCQupVa6LpA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RZL+wfFQKUEdFAsG5cc5vHZfD+T2WnYnKNUpLUXGTZM=; b=WW4a1KfDuCE3WdrImqLqkwXb0tWZCMhuG2zIm0FEZBrBZ2mfOQ2aZyW8lQ7RdglRH5 SZsRpIo6q6NivKAjLdRPId9eKzcCGPIWWj1O9yDedU78LQal6jOhC0z64DqdV1QQxci1 TGY4JmdLBBeyyV4wfpkB0lfIAYlSO+NIfOK9OmQ2k6WFbiCqwG85uKyOMjmu4T9qfPfG AGlkLhZ3w8frOzFuJVtmFzrTXi3UKclTFu4yl0QZuqjXjCgt53eQOQ6Ozx8dJsCzKFog iXO5pjeLXurrTJzER66T4RmtGK+aUqqT5pAxyR2cItD/RRRQvdIOOKoa8Fn5kxKfebhE HGdQ== X-Gm-Message-State: AHPjjUjQHkGgI3HpbyUYYfJFAs3mcEZW7DVFmHlVcr9oCZt5aKhrmlv7 zFfzyB4bH8bpFDlKOxRpcDDNC34jMSwS X-Google-Smtp-Source: ADKCNb4WP2SEkwGDZquVQlUgJnq2Z2OiJfgPiUJra763pi8LvOeLRgJfuXkk4DcDfZ72xA6QHOToLEuDU5PT49tvbyY= X-Received: by 10.202.179.137 with SMTP id c131mr2890268oif.298.1504298260873; Fri, 01 Sep 2017 13:37:40 -0700 (PDT) Original-Received: by 10.157.53.86 with HTTP; Fri, 1 Sep 2017 13:37:40 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136447 Archived-At: --001a113ce08c79fb84055826bb1d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 1 September 2017 at 18:23, Reuben Thomas wrote: > On 1 September 2017 at 17:40, Glenn Morris wrote: > >> Package: emacs >> Version: 26.0.50 >> >> The emacsclient tests added in 98f01a1 fail on hydra, ref eg >> >> https://hydra.nixos.org/build/59905042 >> (wrong-type-argument number-or-marker-p "Profiling timer expired") >> >> On my own desktop machine, they also fail, and interfere with my normal >> editing Emacs: >> >> Have an Emacs session open, with an active server. >> Run make lib-src/emacsclient-tests >> This pops up a "foo" buffer in my desktop Emacs. >> The tests now hang and do not return. >> The emacsclient process is not killed. >> >> The tests should use their own dedicated server, with a timeout. >> > > =E2=80=8BSorry about this, I was aware of the problem while developing th= e tests, > but forgot to address it before committing the patch. > > In fact, the current tests do not require a server: the whole point is to > test the ALTERNATE_EDITOR variable, when the server cannot be contacted. > So, I guess I can fix this by running emacsclient as something like > > emacsclient -f /file/does/not/exist > > ? I can't find any other tests that use emacsclient or run a server (as I > couldn't before when I looked for a model), so I'd appreciate knowing > whether there are any obvious problems with this strategy before I try it= . > Obviously, if more emacsclient tests were written in future which did not > rely on immediate exit, they would need, as you say, a dedicated server. > =E2=80=8BI have pushed 4bc2795 to address this.=E2=80=8B I'll keep an eye o= n how the hydra build turns out. --=20 https://rrt.sc3d.org --001a113ce08c79fb84055826bb1d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On = 1 September 2017 at 18:23, Reuben Thomas <rrt@sc3d.org> wrote:
On 1 September 2017 at 17:40, Glenn Morris &= lt;rgm@gnu.org> wrote:
Package:= emacs
Version: 26.0.50

The emacsclient tests added in 98f01a1 fail on hydra, ref eg

=C2=A0 https://hydra.nixos.org/build/59905042
=C2=A0 (wrong-type-argument number-or-marker-p "Profiling timer expire= d")

On my own desktop machine, they also fail, and interfere with my normal
editing Emacs:

Have an Emacs session open, with an active server.
Run make lib-src/emacsclient-tests
This pops up a "foo" buffer in my desktop Emacs.
The tests now hang and do not return.
The emacsclient process is not killed.

The tests should use their own dedicated server, with a timeout.

=E2=80=8B= Sorry about this, I was aware of the problem while developing the tests, bu= t forgot to address it before committing the patch.

In fact, the current = tests do not require a server: the whole point is to test the ALTERNATE_EDI= TOR variable, when the server cannot be contacted. So, I guess I can fix th= is by running emacsclient as something like

emacsclient -f /file/does/not= /exist

? I can't find any other tests that use emacsclient or run a s= erver (as I couldn't before when I looked for a model), so I'd appr= eciate knowing whether there are any obvious problems with this strategy be= fore I try it. Obviously, if more emacsclient tests were written in future = which did not rely on immediate exit, they would need, as you say, a dedica= ted server.

=E2=80=8BI have pushed 4bc2795 to addr= ess this.=E2=80=8B I'll keep an eye on how the hydra build turns out.

--
--001a113ce08c79fb84055826bb1d--