bug#11944: 24.1.50; newcomment needs comment-normalize-vars in more functions

bug#11944: 24.1.50; newcomment needs comment-normalize-vars in more functions

[Reuben Thomas]

When adding a word to a per-buffer dictionary in an AuCTeX buffer, I get
an error caused by the fact that AuCTeX sets comment-padding to 1, then
calls comment-padright, which assumes comment-padding is a string.

A similar bug report is here:

http://lists.gnu.org/archive/html/bug-auctex/2011-12/msg00000.html

Making comment-padright call comment-normalize-vars fixes this problem;
presumably at least comment-padleft and perhaps other functions need the
same treatment.

(As far as I can see, setting comment-padding to an integer is still
allowed, as per its docstring.)


In GNU Emacs 24.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10)
 of 2012-07-15 on slice
Bzr revision: 109096 dmantipov@yandex.ru-20120715111709-pa3d1hni2gmjdux0
Windowing system distributor `The X.Org Foundation', version 11.0.11103000
Important settings:
  value of $LC_MONETARY: en_GB.UTF-8
  value of $LC_NUMERIC: en_GB.UTF-8
  value of $LC_TIME: en_GB.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: LaTeX/P

Minor modes in effect:
  TeX-PDF-mode: t
  buffer-face-mode: t
  flyspell-mode: t
  smart-quotes-mode: t
  recentf-mode: t
  show-paren-mode: t
  server-mode: t
  savehist-mode: t
  minibuffer-electric-default-mode: t
  iswitchb-mode: t
  icomplete-mode: t
  global-auto-revert-mode: t
  desktop-save-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  visual-line-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
C-x 1 M-x e m a c s - r e p o r t - b u <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> r e p o r t - b u <backspace> <backspace> 
e a c s <backspace> <backspace> <backspace> m a c s 
- b u g <return>

Recent messages:
Loading paren...done
Loading /home/rrt/.recentf...done
Cleaning up the recentf list...done (0 removed)
Loading /home/rrt/.emacs.d/custom.el (source)...done
Starting new Ispell process [/usr/bin/aspell::british+accs] ...
Applying style hooks... done
Wrote /home/rrt/.emacs.desktop.lock
Desktop: 1 buffer restored.
For information about GNU Emacs and the GNU system, type C-h C-a.
delete-backward-char: Text is read-only [7 times]

Load-path shadows:
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/link hides /usr/local/share/emacs/24.1.50/site-lisp/dictionary-el/link
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/dictionary hides /usr/local/share/emacs/24.1.50/site-lisp/dictionary-el/dictionary
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/dictionary-init hides /usr/local/share/emacs/24.1.50/site-lisp/dictionary-el/dictionary-init
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/connection hides /usr/local/share/emacs/24.1.50/site-lisp/dictionary-el/connection
/home/rrt/local/share/emacs/site-lisp/dict hides /usr/local/share/emacs/24.1.50/site-lisp/emacs-goodies-el/dict
/usr/local/share/emacs/24.1.50/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x
/usr/local/share/emacs/24.1.50/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex-fptex hides /usr/share/emacs/site-lisp/auctex/tex-fptex
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf
/usr/local/share/emacs/24.1.50/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar
/usr/local/share/emacs/24.1.50/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt
/usr/local/share/emacs/24.1.50/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex
/usr/local/share/emacs/24.1.50/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex
/usr/local/share/emacs/24.1.50/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context
/usr/local/share/emacs/24.1.50/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl
/usr/local/share/emacs/24.1.50/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en
/usr/local/share/emacs/24.1.50/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils flymake compile comint ansi-color ring preview
prv-emacs byte-opt tex-buf noutline outline font-latex warnings bytecomp
byte-compile cconv latex tex-style tex face-remap flyspell smart-quotes
auto-dictionary-autoloads c-eldoc-autoloads dictionary-autoloads
diff-git-autoloads dired-isearch-autoloads full-ack-autoloads
guess-style-autoloads kill-ring-search-autoloads magit-autoloads
mv-shell-autoloads tumble-autoloads http-post-simple-autoloads package
completing-help recentf tree-widget wid-edit uniquify paren server
savehist minibuf-eldef iswitchb icomplete autorevert desktop cus-start
cus-load ropemacs pymacs go-mode-load ispell advice advice-preload
yasnippet help-fns derived edmacro kmacro cl-macs gv easymenu assoc cl
cl-lib macroexp emacs-goodies-el emacs-goodies-custom
emacs-goodies-loaddefs easy-mmode preview-latex tex-site auto-loads
user-site-loaddefs time-date tooltip ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces
cus-face files text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget hashtable-print-readable backquote
make-network-process dbusbind dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

-- 
http://rrt.sc3d.org/

bug#11944: 24.1.50; newcomment needs comment-normalize-vars in more functions

[Lars Ingebrigtsen]

Reuben Thomas <rrt@sc3d.org> writes:

> When adding a word to a per-buffer dictionary in an AuCTeX buffer, I get
> an error caused by the fact that AuCTeX sets comment-padding to 1, then
> calls comment-padright, which assumes comment-padding is a string.
>
> A similar bug report is here:
>
> http://lists.gnu.org/archive/html/bug-auctex/2011-12/msg00000.html
>
> Making comment-padright call comment-normalize-vars fixes this problem;
> presumably at least comment-padleft and perhaps other functions need the
> same treatment.
>
> (As far as I can see, setting comment-padding to an integer is still
> allowed, as per its docstring.)

(I'm going through old bug reports that have unfortunately gotten no
responses yet.)

The doc in newcomment.el specifies that any command that calls the
newcomment functions should call `comment-normalize-vars' first, so I
don't think this is a bug in newcomment.el.  (All the commands in that
file do this.)

So this sounds like a bug in AuCTeX.  Are you still seeing this bug, and
if so, do you have a backtrace that'll show where AuCTeX is bugging out?
The referenced URL is just somebody calling `commend-padright' directly,
which isn't allowed.

(I'll add that to the doc string of that function.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#11944: 24.1.50; newcomment needs comment-normalize-vars in more functions

[Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Sat, 17 Aug 2019 at 22:50, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Reuben Thomas <rrt@sc3d.org> writes:
>
> So this sounds like a bug in AuCTeX.  Are you still seeing this bug, and
> if so, do you have a backtrace that'll show where AuCTeX is bugging out?
> The referenced URL is just somebody calling `commend-padright' directly,
> which isn't allowed.
>

I think this bug is fixed. AuCTeX 12.1.2 doesn't call `comment-padright`,
and does call `comment-normalize-vars`, so you can close this bug; thanks!

-- 
https://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 1263 bytes --]

bug#11944: 24.1.50; newcomment needs comment-normalize-vars in more functions

[Lars Ingebrigtsen]

Reuben Thomas <rrt@sc3d.org> writes:

> I think this bug is fixed. AuCTeX 12.1.2 doesn't call `comment-padright`, and
> does call `comment-normalize-vars`, so you can close this bug; thanks!

Thanks for checking; closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no