From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#24901: Patch updated slightly Date: Fri, 2 Dec 2016 14:42:24 +0000 Message-ID: References: <834m2moeaf.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f403045ea68a3e33040542adf2c5 X-Trace: blaine.gmane.org 1480689802 23164 195.159.176.226 (2 Dec 2016 14:43:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2016 14:43:22 +0000 (UTC) Cc: 24901@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 02 15:43:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCp3S-00054n-IZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 15:43:15 +0100 Original-Received: from localhost ([::1]:34901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCp3W-0006s4-9F for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 09:43:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCp3N-0006pu-7p for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 09:43:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCp3H-0007D5-18 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 09:43:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34259) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCp3G-0007Cz-UD for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 09:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cCp3G-0006vr-Hd for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 09:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2016 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24901 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24901-submit@debbugs.gnu.org id=B24901.148068975326610 (code B ref 24901); Fri, 02 Dec 2016 14:43:02 +0000 Original-Received: (at 24901) by debbugs.gnu.org; 2 Dec 2016 14:42:33 +0000 Original-Received: from localhost ([127.0.0.1]:49658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCp2n-0006v8-CB for submit@debbugs.gnu.org; Fri, 02 Dec 2016 09:42:33 -0500 Original-Received: from mail-lf0-f44.google.com ([209.85.215.44]:33043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCp2k-0006uu-QS for 24901@debbugs.gnu.org; Fri, 02 Dec 2016 09:42:32 -0500 Original-Received: by mail-lf0-f44.google.com with SMTP id c13so196518753lfg.0 for <24901@debbugs.gnu.org>; Fri, 02 Dec 2016 06:42:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9FnpUGgKVd88vCpkn+5ZVyWJ8xjMweO+mjCnU3e3sXg=; b=ddz8asdb6Flzr7/zgJQivfSTxjRD8MItvZINOm6fwrkAIWeIGg0opK5v58XaYmbUka EX+yp2mi8/2qjWNXYFIt9hxH9lTVSJlbnw0RLAnjhhUU7mZ8Ow8YZNeTkI3Cv4qII9kg NaBx/MpRXzbI9dNyKYwXeYB5No33CWJFgfuus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9FnpUGgKVd88vCpkn+5ZVyWJ8xjMweO+mjCnU3e3sXg=; b=EIUTULZOsc71WqlTuPc2shd/b8GsMK5+Sl/6l+R0vOXfWZpJOkrHPlsxUwMNfU3VFO 84NKwNr93JMB4GKXgtxj0Zw0fHB7PRrQt5uyIbsINoIvM4ol2KGBuj2eD1nIvkCdZsJv FiRICjplVGIw51QnIIQkGUknxdcPOWT5AGUXgVZOxz1/XAO54yvpi2w0dQzjyoq9L0S1 LlnuH7sYxU50ED30VKd99F58tNj6l4o+zsxlWrvCePeY9f22U4TimQC1mz7UjAoHop8s 2uepoKjqbLgmRXlz7C5eCIyY84ofNqOqy5OKJJsfyFHBVZl4bv+1LKamu0J9/+wq4RPp qQ+g== X-Gm-Message-State: AKaTC020ckyHpiVU/D0XagwPQyNIcyIgVFBYzhMUwcTE+Y0RLtTJcFNlqrTxIh/3JimQdtXBpGilMGWSRBJuCf48 X-Received: by 10.25.56.65 with SMTP id d1mr16594750lfj.171.1480689744481; Fri, 02 Dec 2016 06:42:24 -0800 (PST) Original-Received: by 10.25.190.2 with HTTP; Fri, 2 Dec 2016 06:42:24 -0800 (PST) In-Reply-To: <834m2moeaf.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126413 Archived-At: --f403045ea68a3e33040542adf2c5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2 December 2016 at 09:45, Eli Zaretskii wrote: > > From: Reuben Thomas > > Date: Mon, 28 Nov 2016 22:24:39 +0000 > > > > From 4a04639203dca2d5903fd943e5fb2e4ccc7b995f Mon Sep 17 00:00:00 2001 > > From: Reuben Thomas > > Date: Tue, 8 Nov 2016 11:53:20 +0000 > > Subject: [PATCH 1/4] Add support for curly quotation marks to > > electric-pair-mode > > > > * lisp/elec-pair.el (electric-pair-pairs, electric-pair-text-pairs): Ad= d > > entries for left/right single/double quotation marks, from > > electric-quote-chars. Note that this is safe for single quotation marks= , > > unlike with the ASCII apostrophe, since, although the right quotation > > mark can be used as an apostrophe, it is the left quotation mark that i= s > > typed to get a pair (Bug#24901). > > Can you tell more about this? The original bug report doesn't include > any rationale, so it's hard for me to make up my mind about this > change. > =E2=80=8BRationale: electric-pair-mode already has support for straight double-quote pairs, so it is logical to add support for curly double-quote pairs. As with straight double quotes, it's logical that these be supported everywhere. The same goes for straight single quotes, which are generally used for the same purpose as curly double and single double quotes, that is, quoting (in human language). The use of electric-quote-chars means that electric-pair-mode will automatically use whatever the user has configured for single and double quotes. In particular, I don't understand the last sentence of the log > message; can you elaborate? > =E2=80=8Belectric-pair-mode does not by default produce pairs of straight s= ingle quote (apostrophe). This is because it does not always make sense: a single apostrophe is often used on its own. However, with curly single quotes, it makes sense for electric-pair-mode to make typing a left curly quote automatically add a corresponding right quote, as left curly quotes are not normally used on their own. (Right single curly quotes can be used on their own, as an apostrophe, but this is irrelevant here, as electric-pair-mode acts when the left-hand mark is typed, not the right-hand mark). --=20 http://rrt.sc3d.org --f403045ea68a3e33040542adf2c5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 2 December 2016 at 09:45, Eli Zaretskii <eliz@gnu.org> wrote:
=
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Mon, 28 Nov 2016 22:24:39 +0000
>
> From 4a04639203dca2d5903fd943e5fb2e4ccc7b995f Mon Sep 17 00:00:00= 2001
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Tue, 8 Nov 2016 11:53:20 +0000
> Subject: [PATCH 1/4] Add support for curly quotation marks to
>=C2=A0 electric-pair-mode
>
> * lisp/elec-pair.el (electric-pair-pairs, electric-pair-text-pairs): A= dd
> entries for left/right single/double quotation marks, from
> electric-quote-chars. Note that this is safe for single quotation mark= s,
> unlike with the ASCII apostrophe, since, although the right quotation<= br> > mark can be used as an apostrophe, it is the left quotation mark that = is
> typed to get a pair (Bug#24901).

Can you tell more about this?=C2=A0 The original bug report doesn't inc= lude
any rationale, so it's hard for me to make up my mind about this
change.

In particular,= I don't understand the last sentence of the log
message; can you elaborate?

=E2=80= =8Belectric-pair-mode does not by default produce pairs of straight single = quote (apostrophe). This is because it does not always make sense: a single= apostrophe is often used on its own. However, with curly single quotes, it= makes sense for electric-pair-mode to make typing a left curly quote autom= atically add a corresponding right quote, as left curly quotes are not norm= ally used on their own. (Right single curly quotes can be used on their own= , as an apostrophe, but this is irrelevant here, as electric-pair-mode acts= when the left-hand mark is typed, not the right-hand mark).
--
http://rrt.sc3d.org
--f403045ea68a3e33040542adf2c5--