From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#19547: Patch for this bug Date: Tue, 8 Nov 2016 18:28:28 +0000 Message-ID: References: <874ms03qj1.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113fbc4498bcf90540ce4ec1 X-Trace: blaine.gmane.org 1478629782 25530 195.159.176.226 (8 Nov 2016 18:29:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 Nov 2016 18:29:42 +0000 (UTC) To: 19547@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 08 19:29:36 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4B8x-0002R0-2m for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Nov 2016 19:29:11 +0100 Original-Received: from localhost ([::1]:34828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4B8z-0003U2-Ae for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Nov 2016 13:29:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4B8t-0003PH-4S for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2016 13:29:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4B8o-00046z-9A for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2016 13:29:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34533) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4B8n-00046j-VV for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2016 13:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c4B8n-000094-NH for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2016 13:29:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <874ms03qj1.fsf@web.de> Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2016 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19547-submit@debbugs.gnu.org id=B19547.1478629718522 (code B ref 19547); Tue, 08 Nov 2016 18:29:01 +0000 Original-Received: (at 19547) by debbugs.gnu.org; 8 Nov 2016 18:28:38 +0000 Original-Received: from localhost ([127.0.0.1]:49932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4B8P-00008D-P3 for submit@debbugs.gnu.org; Tue, 08 Nov 2016 13:28:37 -0500 Original-Received: from mail-lf0-f50.google.com ([209.85.215.50]:33708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4B8N-00007x-TN for 19547@debbugs.gnu.org; Tue, 08 Nov 2016 13:28:36 -0500 Original-Received: by mail-lf0-f50.google.com with SMTP id c13so146260334lfg.0 for <19547@debbugs.gnu.org>; Tue, 08 Nov 2016 10:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=Xy5WIHYLNQgIPRXQKpVydzQyB+wESjb7jXRwer4iZx8=; b=m6+rW9FwCG3MZ7eUAjQx4fYp9RbvKYH5sJzqYZ6c2R2vcYs3mACR2ARmK51DTjhhOO SI/ai0FDwqaOudRq0QbtLQRvPraajpJHL/STsHKeUS153zq4WRVLfmQd8VucJt90zv3x d+ny4X/WaKbBt+kjFvTtKTuNuJwRpp47HACac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Xy5WIHYLNQgIPRXQKpVydzQyB+wESjb7jXRwer4iZx8=; b=VYoe+gHwZ7yLNiJ4rpr7eanRDQvJqC0PnEogZt3h+g37bnP834OYAKcSPBuPXDKhbO nA5OZg00HBOK8lSRDDPUE8vPMmOr5E9M8VExJMaxXoGzlpXe9e9e1wriSsvM1CwdUsa2 8iNLBk6mHaMwcuGDQqRcp9FkkB4yBWGQIqa1ArEbjz8Xt4FmPQ1AaKKv3mRPazmuH5iJ eADULNGhaNGvLm52puhLEQu7/0/LBZzeey2kyKlRm2z6G4W8rWeA/YXDZ2lv1RVy31JS b02P2Vx0hjYYN5MRvcpX9T9o4WrfmQPZTNXD3VcBj/9OQ9bjNm5AnoErJPatJaQMySh+ bMSQ== X-Gm-Message-State: ABUngveOBxgegen0nR2+aM0Ny/3HbaazClNx+d1VOgLnAilrfQG8jotFF6LiGAlG7/OkICSpanhMdMIShITYqs7f X-Received: by 10.25.135.130 with SMTP id j124mr8397397lfd.88.1478629709610; Tue, 08 Nov 2016 10:28:29 -0800 (PST) Original-Received: by 10.25.212.211 with HTTP; Tue, 8 Nov 2016 10:28:28 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125480 Archived-At: --001a113fbc4498bcf90540ce4ec1 Content-Type: multipart/alternative; boundary=001a113fbc4498bcf50540ce4ebf --001a113fbc4498bcf50540ce4ebf Content-Type: text/plain; charset=UTF-8 I attach a patch for this bug that takes the simple approach of adding SELECTION_REQUEST_EVENT to the list of events to ignore in kbd_buffer_store_buffered_event. This seems simple and safe (it's not something one would normally consider an input event). Further, at present it would not help helm to implement Eli's suggestion of a list of events for input-pending-p to ignore, as Helm currently does not use that (it has a custom version of while-no-input that does not call input-pending-p). As a helm user with an external clipboard manager, I was experiencing this bug. I'm using Emacs with this patch currently; it seems fine, and I don't have the Helm problem any more. -- http://rrt.sc3d.org --001a113fbc4498bcf50540ce4ebf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I a= ttach a patch for this bug that takes the simple approach of adding SELECTI= ON_REQUEST_EVENT to the list of events to ignore in kbd_buffer_store_buffer= ed_event.
=
This seems= simple and safe (it's not something one would normally consider an inp= ut event).

=
Further, at pr= esent it would not help helm to implement Eli's suggestion of a list of= events for input-pending-p to ignore, as Helm currently does not use that = (it has a custom version of while-no-input that does not call input-pending= -p).

=
As a helm user with = an external clipboard manager, I was experiencing this bug. I'm using E= macs with this patch currently; it seems fine, and I don't have the Hel= m problem any more.

--
http://rrt.sc3d.org
--001a113fbc4498bcf50540ce4ebf-- --001a113fbc4498bcf90540ce4ec1 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Ignore-SELECTION_REQUEST_EVENT-in-while-no-input.patch" Content-Disposition: attachment; filename="0001-Ignore-SELECTION_REQUEST_EVENT-in-while-no-input.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iv9t4kkl0 RnJvbSA2NDBkZmM0YjYxNjViNWIxOTY4YjNiODRmMWM5OWNjNzM1MTM3N2EzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFR1 ZSwgOCBOb3YgMjAxNiAxODowMTozNyArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIElnbm9yZSBTRUxF Q1RJT05fUkVRVUVTVF9FVkVOVCBpbiB3aGlsZS1uby1pbnB1dAoKKiBzcmMva2V5Ym9hcmQuYyAo a2JkX2J1ZmZlcl9zdG9yZV9idWZmZXJlZF9ldmVudCk6IERvIG5vdCB0cmVhdApTRUxFQ1RJT05f UkVRVUVTVF9FVkVOVCBhcyBhbiBpbnB1dCBldmVudCAoQnVnIzE5NTQ3KS4KLS0tCiBzcmMva2V5 Ym9hcmQuYyB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2tleWJvYXJkLmMgYi9zcmMva2V5Ym9hcmQuYwppbmRl eCBmMjRkODZlLi5hMWNmNjc3IDEwMDY0NAotLS0gYS9zcmMva2V5Ym9hcmQuYworKysgYi9zcmMv a2V5Ym9hcmQuYwpAQCAtMzU1OSw3ICszNTU5LDggQEAga2JkX2J1ZmZlcl9zdG9yZV9idWZmZXJl ZF9ldmVudCAodW5pb24gYnVmZmVyZWRfaW5wdXRfZXZlbnQgKmV2ZW50LAogICAgICAgJiYgZXZl bnQtPmtpbmQgIT0gRk9DVVNfT1VUX0VWRU5UCiAgICAgICAmJiBldmVudC0+a2luZCAhPSBIRUxQ X0VWRU5UCiAgICAgICAmJiBldmVudC0+a2luZCAhPSBJQ09OSUZZX0VWRU5UCi0gICAgICAmJiBl dmVudC0+a2luZCAhPSBERUlDT05JRllfRVZFTlQpCisgICAgICAmJiBldmVudC0+a2luZCAhPSBE RUlDT05JRllfRVZFTlQKKyAgICAgICYmIGV2ZW50LT5raW5kICE9IFNFTEVDVElPTl9SRVFVRVNU X0VWRU5UKQogICAgIHsKICAgICAgIFZxdWl0X2ZsYWcgPSBWdGhyb3dfb25faW5wdXQ7CiAgICAg ICAvKiBJZiB3ZSdyZSBpbnNpZGUgYSBmdW5jdGlvbiB0aGF0IHdhbnRzIGltbWVkaWF0ZSBxdWl0 cywKLS0gCjIuNy40Cgo= --001a113fbc4498bcf90540ce4ec1--