unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Reuben Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 43191@debbugs.gnu.org
Subject: bug#43191: [PATCH] Add enchant-2 to list of default spelling checker programs
Date: Fri, 4 Sep 2020 02:07:51 +0100	[thread overview]
Message-ID: <CAOnWdogtGQhkq-rXgenMUFH_ZOUpz4i5Jsu6JVZ6eRjFV65LLA@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 621 bytes --]

(As I've not been active for a while, I'd appreciate a review of this
admittedly trivial patch; I plan to make another few patches to ispell.el.)

I attach a patch to fix an XXX and add "enchant-2" to the list of spelling
checker programs checked by default. The XXX comment noted that enchant >=
2.1.0 is required by ispell.el; the good news is that enchant is now
commonly installed under the name "enchant-2", which is likely to be a
suitable version (2.0.x releases were not widely adopted), so rather than
look for "enchant" (perhaps that will come later), we can now look for
"enchant-2".

-- 
https://rrt.sc3d.org

[-- Attachment #1.2: Type: text/html, Size: 1187 bytes --]

[-- Attachment #2: 0001-Add-enchant-2-to-list-of-default-spelling-checker-pr.patch --]
[-- Type: text/x-patch, Size: 1351 bytes --]

From 90a0a5ec364efb8207c1b4e1b9b539634135cf3e Mon Sep 17 00:00:00 2001
From: Reuben Thomas <rrt@sc3d.org>
Date: Fri, 4 Sep 2020 01:58:04 +0100
Subject: [PATCH] Add enchant-2 to list of default spelling checker programs

* lisp/textmodes/ispell.el (ispell-program-name): Check `enchant-2',
as it is likely to be a suitable version. Enchant 2 seems to be
commonly installed under this name, so we don't have to worry about
checking `enchant'.
---
 lisp/textmodes/ispell.el | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
index 86452ff1e8..8281f1d6bd 100644
--- a/lisp/textmodes/ispell.el
+++ b/lisp/textmodes/ispell.el
@@ -198,14 +198,11 @@ ispell-choices-win-default-height
   :type 'integer
   :group 'ispell)
 
-;; XXX Add enchant to this list once enchant >= 2.1.0 is widespread.
-;; Before that, adding it is useless, as if it is found, it will just
-;; cause an error; and one of the other spelling engines below is
-;; almost certainly installed in any case, for enchant to use.
 (defcustom ispell-program-name
   (or (executable-find "aspell")
       (executable-find "ispell")
       (executable-find "hunspell")
+      (executable-find "enchant-2")
       "ispell")
   "Program invoked by \\[ispell-word] and \\[ispell-region] commands."
   :type 'string
-- 
2.25.1


             reply	other threads:[~2020-09-04  1:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04  1:07 Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-09-04  1:46 ` bug#43191: [PATCH] Add enchant-2 to list of default spelling checker programs Lars Ingebrigtsen
2020-09-04  1:51 ` Noam Postavsky
2020-09-05  6:48   ` Eli Zaretskii
2020-09-06 22:25     ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-04  7:27 ` Eli Zaretskii
2020-09-04 13:30   ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOnWdogtGQhkq-rXgenMUFH_ZOUpz4i5Jsu6JVZ6eRjFV65LLA@mail.gmail.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=43191@debbugs.gnu.org \
    --cc=rrt@sc3d.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).