From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Reuben Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49245: Enchant dictionaries list not being correctly set, and other minor fixes Date: Mon, 28 Jun 2021 13:31:01 +0100 Message-ID: References: <83a6nap4ot.fsf@gnu.org> Reply-To: Reuben Thomas Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002c942505c5d2aae2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39776"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49245@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 28 14:38:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxqX3-000AB7-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Jun 2021 14:38:33 +0200 Original-Received: from localhost ([::1]:57736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxqX2-0002kZ-Ea for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Jun 2021 08:38:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxqQl-0006kr-PL for bug-gnu-emacs@gnu.org; Mon, 28 Jun 2021 08:32:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39669) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxqQk-00036B-EB for bug-gnu-emacs@gnu.org; Mon, 28 Jun 2021 08:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lxqQj-0005hm-Uv for bug-gnu-emacs@gnu.org; Mon, 28 Jun 2021 08:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jun 2021 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49245 X-GNU-PR-Package: emacs Original-Received: via spool by 49245-submit@debbugs.gnu.org id=B49245.162488348021876 (code B ref 49245); Mon, 28 Jun 2021 12:32:01 +0000 Original-Received: (at 49245) by debbugs.gnu.org; 28 Jun 2021 12:31:20 +0000 Original-Received: from localhost ([127.0.0.1]:51215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxqQ4-0005gm-Fa for submit@debbugs.gnu.org; Mon, 28 Jun 2021 08:31:20 -0400 Original-Received: from mail-ot1-f48.google.com ([209.85.210.48]:33705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxqQ2-0005gY-55 for 49245@debbugs.gnu.org; Mon, 28 Jun 2021 08:31:19 -0400 Original-Received: by mail-ot1-f48.google.com with SMTP id o17-20020a9d76510000b02903eabfc221a9so18623242otl.0 for <49245@debbugs.gnu.org>; Mon, 28 Jun 2021 05:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MPGdA9g9iPDzuwAQYdwpNhq0pEgQ9uqxzhgD6wl6zqI=; b=anJ5tH0OeShIX0OT76Ba1R+wAUJsaV5epC5hfzoNjSCDPjGdSYIEWqKmdd+EUyqhGi VkSjZp9jAI0ZPxTSEX1ZvR1slwOPf4rKOB4f7Hc5VgLfNNn/ny6Z8/rW8a7SPUGGvFsK Ncy7LSJTkFa2AhAPtCprCWwPedV0V2n9ERd60= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MPGdA9g9iPDzuwAQYdwpNhq0pEgQ9uqxzhgD6wl6zqI=; b=Twhf8K0NUGcpUXw6DPbqVtDR4ntOkC0n3uCXHGufjrUfjSuKL2RgGEiSflSp9pLEbK UE1j1+kyew86Vel7HyipWZ6Y3uT0Ex3hVOeB8CpSDeVMdwAR9gEHccEqAJkvmrhbj8Wx THMafYfKsijeOkddvUTPMbC9kDz8emPyMsAyPI1/7cXPyg3OYGYhvUdUVS92ThQW9fR9 nXlcAoVitb28imCNdGUXRbnegAyqteEWG26vN2pPm+z5f7j6nYFOkmf3InD9LNQIkqQQ nVgJjMi1gsMsWKTSboy2vIGMvWvt7BxKl7iJsQ+yZdXPuCY5oM4zVij2K5kHd64Gbat+ ibEg== X-Gm-Message-State: AOAM533L8I/XfjWkbDeg0wShPmAH1dUdSrRLWAv2mWSF9aLJRQU8cBsO AiXUs3M5EOsYyNl1RygctIBIrU9nqyRqdKSJiQAxIQ== X-Google-Smtp-Source: ABdhPJxfCjLj+L77mK8hOnR9KB8gSCBzQikP6oyoxaPMMGwQgAEmkhKncayMlKEyhRejY5+osaLRw3C3ivrvItqvCbk= X-Received: by 2002:a05:6830:1643:: with SMTP id h3mr21567494otr.76.1624883472400; Mon, 28 Jun 2021 05:31:12 -0700 (PDT) In-Reply-To: <83a6nap4ot.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209056 Archived-At: --0000000000002c942505c5d2aae2 Content-Type: text/plain; charset="UTF-8" On Mon, 28 Jun 2021 at 13:13, Eli Zaretskii wrote: > OK for the first 2 patches, Thanks for the review. > but please don't remove that comment, it > explains something important, and there's no reason to remove it (or > many other similar comments we have throughout our code). > In that case, please can you explain it, and I can rewrite it so that its significance is more evident. As I said, it explains why something was changed in the past (which is useful information in a commit message) rather than how or why the current code does something that may not be obvious just from reading the code (which would be suitable for a comment). Commit f0a1f8bdb5, which introduces it, has the message "Do not ignore short words". The current code does not have to *do* anything to check short words; that commit simply removed a check. I do not see anything in the current code that raises any questions that need answering by a comment. On the contrary, the comment raises a question: "is there some setting for minimum word length that I need to be aware of?". So I feel I've missed something here that a rewording of the comment could fix. -- https://rrt.sc3d.org --0000000000002c942505c5d2aae2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, 28 Jun 2021 = at 13:13, Eli Zaretskii <eliz@gnu.org> wrote:
OK for the first 2 patches,

Thanks for the review.
=C2=A0
but please don't= remove that comment, it
explains something important, and there's no reason to remove it (or many other similar comments we have throughout our code).
<= div>
In that case, please can you explain it, a= nd I can rewrite it so that its significance is more evident. As I said, it= explains why something was changed in the past (which is useful informatio= n in a commit message) rather than how or why the current code does somethi= ng that may not be obvious just from reading the code (which would be suita= ble for a comment). Commit f0a1f8bdb5, which introduces it, has the message= "Do not ignore short words". The current code does not have to *= do* anything to check short words; that commit simply removed a check. I do= not see anything in the current code that raises any questions that need a= nswering by a comment. On the contrary, the comment raises a question: &quo= t;is there some setting for minimum word length that I need to be aware of?= ". So I feel I've missed something here that a rewording of the co= mment could fix.

--
<= /div> --0000000000002c942505c5d2aae2--