On 1 September 2017 at 17:40, Glenn Morris wrote: > Package: emacs > Version: 26.0.50 > > The emacsclient tests added in 98f01a1 fail on hydra, ref eg > > https://hydra.nixos.org/build/59905042 > (wrong-type-argument number-or-marker-p "Profiling timer expired") > > On my own desktop machine, they also fail, and interfere with my normal > editing Emacs: > > Have an Emacs session open, with an active server. > Run make lib-src/emacsclient-tests > This pops up a "foo" buffer in my desktop Emacs. > The tests now hang and do not return. > The emacsclient process is not killed. > > The tests should use their own dedicated server, with a timeout. > ​Sorry about this, I was aware of the problem while developing the tests, but forgot to address it before committing the patch. In fact, the current tests do not require a server: the whole point is to test the ALTERNATE_EDITOR variable, when the server cannot be contacted. So, I guess I can fix this by running emacsclient as something like emacsclient -f /file/does/not/exist ? I can't find any other tests that use emacsclient or run a server (as I couldn't before when I looked for a model), so I'd appreciate knowing whether there are any obvious problems with this strategy before I try it. Obviously, if more emacsclient tests were written in future which did not rely on immediate exit, they would need, as you say, a dedicated server. -- https://rrt.sc3d.org