From: Reuben Thomas <rrt@sc3d.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 28319@debbugs.gnu.org
Subject: bug#28319: emacsclient tests interfere with running Emacs, hang
Date: Fri, 1 Sep 2017 18:23:48 +0100 [thread overview]
Message-ID: <CAOnWdogUQH8dL2E=ywRJSHzY0TN2fwecu7TzEr812Ho0BofPOg@mail.gmail.com> (raw)
In-Reply-To: <9swp5iqsmt.fsf@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
On 1 September 2017 at 17:40, Glenn Morris <rgm@gnu.org> wrote:
> Package: emacs
> Version: 26.0.50
>
> The emacsclient tests added in 98f01a1 fail on hydra, ref eg
>
> https://hydra.nixos.org/build/59905042
> (wrong-type-argument number-or-marker-p "Profiling timer expired")
>
> On my own desktop machine, they also fail, and interfere with my normal
> editing Emacs:
>
> Have an Emacs session open, with an active server.
> Run make lib-src/emacsclient-tests
> This pops up a "foo" buffer in my desktop Emacs.
> The tests now hang and do not return.
> The emacsclient process is not killed.
>
> The tests should use their own dedicated server, with a timeout.
>
Sorry about this, I was aware of the problem while developing the tests,
but forgot to address it before committing the patch.
In fact, the current tests do not require a server: the whole point is to
test the ALTERNATE_EDITOR variable, when the server cannot be contacted.
So, I guess I can fix this by running emacsclient as something like
emacsclient -f /file/does/not/exist
? I can't find any other tests that use emacsclient or run a server (as I
couldn't before when I looked for a model), so I'd appreciate knowing
whether there are any obvious problems with this strategy before I try it.
Obviously, if more emacsclient tests were written in future which did not
rely on immediate exit, they would need, as you say, a dedicated server.
--
https://rrt.sc3d.org <http://rrt.sc3d.org>
[-- Attachment #2: Type: text/html, Size: 2541 bytes --]
next prev parent reply other threads:[~2017-09-01 17:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 16:40 bug#28319: emacsclient tests interfere with running Emacs, hang Glenn Morris
2017-09-01 17:23 ` Reuben Thomas [this message]
2017-09-01 20:37 ` Reuben Thomas
2017-09-01 22:19 ` Glenn Morris
2017-09-01 22:44 ` Reuben Thomas
2017-09-05 19:55 ` Glenn Morris
2017-09-05 21:11 ` Reuben Thomas
2017-09-05 22:24 ` Glenn Morris
2017-09-06 1:14 ` Glenn Morris
2017-09-06 16:02 ` Eli Zaretskii
2017-09-07 23:10 ` Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOnWdogUQH8dL2E=ywRJSHzY0TN2fwecu7TzEr812Ho0BofPOg@mail.gmail.com' \
--to=rrt@sc3d.org \
--cc=28319@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).