From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#18238: Fix for DOS build when using more accurate config[.h].in Date: Sun, 10 Aug 2014 19:20:48 +0100 Message-ID: References: <83lhqwjk4i.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113422aa64d31b05004a7fbd X-Trace: ger.gmane.org 1407694880 9954 80.91.229.3 (10 Aug 2014 18:21:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Aug 2014 18:21:20 +0000 (UTC) Cc: 18238@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 10 20:21:14 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XGXk2-00072k-9K for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Aug 2014 20:21:14 +0200 Original-Received: from localhost ([::1]:60609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGXk1-0005TF-Rh for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Aug 2014 14:21:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGXjv-0005T8-09 for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 14:21:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGXjq-0001av-OT for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 14:21:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGXjq-0001ar-LO for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 14:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XGXjq-0001Zj-6H for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2014 14:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Aug 2014 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18238 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18238-submit@debbugs.gnu.org id=B18238.14076948586032 (code B ref 18238); Sun, 10 Aug 2014 18:21:02 +0000 Original-Received: (at 18238) by debbugs.gnu.org; 10 Aug 2014 18:20:58 +0000 Original-Received: from localhost ([127.0.0.1]:37955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXjl-0001ZC-Fg for submit@debbugs.gnu.org; Sun, 10 Aug 2014 14:20:57 -0400 Original-Received: from mail-la0-f52.google.com ([209.85.215.52]:46723) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XGXji-0001Yy-GJ for 18238@debbugs.gnu.org; Sun, 10 Aug 2014 14:20:55 -0400 Original-Received: by mail-la0-f52.google.com with SMTP id b17so4884252lan.25 for <18238@debbugs.gnu.org>; Sun, 10 Aug 2014 11:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=NNIwK9o9n0Bk3ljrojLvkvrEezNdGPDYzv6r6kBXU/o=; b=wiMrwLa3vXE8tdAZEYgkv2j+M75eTWtd2HtIMFNeenUlhahHfTD7KLMyPPf0UOrdJX JewHViGvLlviV+dbzcSCD+CrfHiEBh6NLsBcrVw1mylYDETL1k0DcK34tsSzTeEAiSzH cBb2mV/pHgJqyjkbdrLoTshPpJX1c9UvGAGxY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=NNIwK9o9n0Bk3ljrojLvkvrEezNdGPDYzv6r6kBXU/o=; b=Kh0tKXNqsJ0xRsU9yvnDHjbux9mdauKDCmFaZGN2uXgWhB3QG6oyusDSqNlJ9/wD1i AQxMKAx7c1A+/qrndZYslsf1c1xRz6uh5XBad5CxCXKLGr+FpsYsOajmK/9gXuquMhrL 5/eyHefr+b3nwGMEba0iqqiyTjfmAnbbjwM7GLDGOC6+Il37ZljU9I/v7hApPaQEb5cu IB9rRenUrzuRvgWMzUM09te2mZFbW+QH+aw0Th8qYvwP+CPLX5Hs6n/LakXtZ7i9A2aJ qYt7g3J3ac0h4xu11iF2/VWza1GUYbcOmWUB6chUSBhIfUneyk7kA/9qOasPMcC9CUi+ hIqg== X-Gm-Message-State: ALoCoQnUd7yzHGzydFKsDLvnZ190YrY3m6DdvsSunbq70VqrVKGDJU2EKUYLEdg9BZ6e9u9HXvW1 X-Received: by 10.152.234.71 with SMTP id uc7mr33978533lac.22.1407694848440; Sun, 10 Aug 2014 11:20:48 -0700 (PDT) Original-Received: by 10.152.246.10 with HTTP; Sun, 10 Aug 2014 11:20:48 -0700 (PDT) In-Reply-To: <83lhqwjk4i.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92387 Archived-At: --001a113422aa64d31b05004a7fbd Content-Type: text/plain; charset=UTF-8 On 10 August 2014 19:05, Eli Zaretskii wrote: > > Date: Sun, 10 Aug 2014 17:47:11 +0100 > > From: Reuben Thomas > > > > DJGPP does actually have getrlimit. The special config[.h].in for MSDOS > > lies and says it hasn't. However, this is a white lie, because getrlimit > on > > DJGPP doesn't support RLIMIT_AS/RLIMIT_DATA, which is what we want, so we > > still want the workaround code. The following patch simply reverses the > > order of a couple of tests in vm-limit.c so that being on MSDOS overrides > > HAVE_GETRLIMIT. > > > > Is it OK to install? > > I don't see why the suggested code is better than the existing one. > HAVE_GETRLIMIT means more than its name says, as you point out, so > DJGPP is correct in not defining one. > I think I was unclear, sorry: DJGPP does define getrlimit. It is only the MSDOS config.in that says it is not defined. If you run ./configure, then it detects getrlimit, and defines HAVE_GETRLIMIT. -- http://rrt.sc3d.org --001a113422aa64d31b05004a7fbd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 1= 0 August 2014 19:05, Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Sun, 10 Aug 2014 17:47:11 +0100
> From: Reuben Thomas <rrt@sc3d.org>
>
> DJGPP does actually have getrlimit. The special config[.h].in for MSDO= S
> lies and says it hasn't. However, this is a white lie, because get= rlimit on
> DJGPP doesn't support RLIMIT_AS/RLIMIT_DATA, which is what we want= , so we
> still want the workaround code. The following patch simply reverses th= e
> order of a couple of tests in vm-limit.c so that being on MSDOS overri= des
> HAVE_GETRLIMIT.
>
> Is it OK to install?

I don't see why the suggested code is better than the existing one.
HAVE_GETRLIMIT means more than its name says, as you point out, so
DJGPP is correct in not defining one.

I think I was uncle= ar, sorry: DJGPP does define getrlimit. It is only the MSDOS config.in that says it is not defined. If you run ./conf= igure, then it detects getrlimit, and defines HAVE_GETRLIMIT.

--
http://rrt.sc3d.org
--001a113422aa64d31b05004a7fbd--