From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Mastro Newsgroups: gmane.emacs.bugs Subject: bug#26317: 26.0.50; Small incompatibility in ibuffer.el (ibuffer-compile-format) Date: Thu, 30 Mar 2017 16:15:16 -0700 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1146eb8aee68d7054bfade3a X-Trace: blaine.gmane.org 1490915787 12894 195.159.176.226 (30 Mar 2017 23:16:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 30 Mar 2017 23:16:27 +0000 (UTC) To: 26317@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 31 01:16:20 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctjIY-0001yM-8Z for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Mar 2017 01:16:10 +0200 Original-Received: from localhost ([::1]:38053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctjId-0006Hz-TG for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Mar 2017 19:16:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctjIV-0006GU-1N for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 19:16:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctjIQ-0006me-1K for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 19:16:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctjIP-0006mN-Tb for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 19:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ctjIP-0001r9-Lr for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 19:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Mastro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Mar 2017 23:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26317-submit@debbugs.gnu.org id=B26317.14909157447111 (code B ref 26317); Thu, 30 Mar 2017 23:16:01 +0000 Original-Received: (at 26317) by debbugs.gnu.org; 30 Mar 2017 23:15:44 +0000 Original-Received: from localhost ([127.0.0.1]:53291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctjI8-0001qd-K1 for submit@debbugs.gnu.org; Thu, 30 Mar 2017 19:15:44 -0400 Original-Received: from mail-qt0-f181.google.com ([209.85.216.181]:35444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctjI7-0001qQ-GP for 26317@debbugs.gnu.org; Thu, 30 Mar 2017 19:15:43 -0400 Original-Received: by mail-qt0-f181.google.com with SMTP id x35so52547322qtc.2 for <26317@debbugs.gnu.org>; Thu, 30 Mar 2017 16:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=3YGqJFd6V4DvkQObcc3hAk98xTDkyWRiQL4zx2XEMv8=; b=czFflLn7JNrLk/zXMIwMzVZwbTX4jW3ycG0RVtxvrwnfIkqke31UPFPpqgSf69qNML D7pz76C2jtXZFdlsXWpm5HrY9SUzEJ9Bwrhzq2GaCVkcKX33z32hjnnGqYphyRmwapDT UPtAsy39hIrNPYbQgl7iD4X8OCd+uFpCry95lEnE9vOAO8vvQWYO4OeMvznoD85XBeb7 jyGmrQd753zz/VoRg5ZxXrQR+cIJRd7o/jlQwKAIMrBajoCEPrDaS8CM1wnjLPC6IZH7 /TUYFjExcyZDyoB8wT+O0wdryTZm22sZn74Y9ShY50YgeuMMJM2tpxIlOoixta4IbMif ry0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=3YGqJFd6V4DvkQObcc3hAk98xTDkyWRiQL4zx2XEMv8=; b=YoOLUw1Zyecfeaz9idKqnAgXsenbl61BsGb9J+Q9+GFczlA8s+agqxvmEYX1SVjYxB zfdyat/sl+SXdNhqqIo05YiBPOx/XeJOfGCa6NQlxl8Lx4E1hsNaq8+dSElj/G4WCISR hERfwJGDkO2o/38df5QPcjzzuh33DUrzjeer2sNmahR8kbWDQgFToEWfxzIdlsYPhHv+ AapA/eAMV4+S0s+2wQF+4JmYOkqcSwXXejgFKg0dSWJFaGq+LjMpvSeL5wQ6A8NWA++y jCqVZ+51mHHE7CB4LwsUfajO3pPXvIcXKPH7QCogdv9gLPYma/KZVZVsMbBnBM3own+x EJuw== X-Gm-Message-State: AFeK/H3KAumaLeM1KUd53jv15H0ZqILEwpY4V6jkc/nkO8zBlJ3mCWPSz4QseOq1K3MwSsiBfBdSXKgQagf/mg== X-Received: by 10.237.63.89 with SMTP id q25mr2238523qtf.253.1490915737616; Thu, 30 Mar 2017 16:15:37 -0700 (PDT) Original-Received: by 10.237.49.162 with HTTP; Thu, 30 Mar 2017 16:15:16 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131113 Archived-At: --001a1146eb8aee68d7054bfade3a Content-Type: text/plain; charset=UTF-8 John Mastro wrote: > In commit 7e2a8b1, ibuffer.el was change to use `string-width' in a couple > places where it previously used `length'. The result is that custom columns > which can return nil, which worked in Emacs 25, will now cause an error. I've attached a patch that fixes this. Rather than touching the calls to `string-width' directly, it translates nil to the empty string. Either way restores compatibility with Emacs 25, but translating nil to the empty string seems preferable in that it saves later code from caring. Even though it's a tiny change, I'm not a regular contributor or particularly familiar with ibuffer's implementation, so any review is appreciated. My copyright assignment is on file. John --001a1146eb8aee68d7054bfade3a Content-Type: application/octet-stream; name="0001-Fix-a-small-incompatibility-in-ibuffer.patch" Content-Disposition: attachment; filename="0001-Fix-a-small-incompatibility-in-ibuffer.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j0x0pvil0 RnJvbSA4MWMwM2IzZjM3Mjc0ZWYyMjQ3OTAzNDY3Y2NiYjdjODk3MGZmOTc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2huIE1hc3RybyA8am9obi5iLm1hc3Ryb0BnbWFpbC5jb20+ CkRhdGU6IFRodSwgMzAgTWFyIDIwMTcgMTY6MDE6NDEgLTA3MDAKU3ViamVjdDogW1BBVENIXSBG aXggYSBzbWFsbCBpbmNvbXBhdGliaWxpdHkgaW4gaWJ1ZmZlcgoKVHJhbnNsYXRlIG5pbCB2YWx1 ZXMgZnJvbSBjb2x1bW4gZnVuY3Rpb25zIHRvIHRoZSBlbXB0eSBzdHJpbmcsIHNvIHRoYXQKc3Vi c2VxdWVudCBjYWxscyB0byBzdHJpbmctd2lkdGggZG9uJ3Qgc2lnbmFsIGFuIGVycm9yIChCdWcj MjYzMTcpLgoqIGxpc3AvaWJ1ZmZlci5lbCAoaWJ1ZmZlci1jb21waWxlLWZvcm1hdCk6IElmIGEg Y29sdW1uIGZ1bmN0aW9uIHJldHVybnMKbmlsLCB0cmVhdCBpdCBsaWtlIHRoZSBlbXB0eSBzdHJp bmcuCi0tLQogbGlzcC9pYnVmZmVyLmVsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9pYnVmZmVyLmVsIGIvbGlz cC9pYnVmZmVyLmVsCmluZGV4IDY2OTE2YjIuLmM4M2MyMTMgMTAwNjQ0Ci0tLSBhL2xpc3AvaWJ1 ZmZlci5lbAorKysgYi9saXNwL2lidWZmZXIuZWwKQEAgLTE2ODksNyArMTY4OSw3IEBAIGlidWZm ZXItY29tcGlsZS1mb3JtYXQKIAkJICAgIDs7IGdlbmVyYXRlIGEgY2FsbCB0byB0aGUgY29sdW1u IGZ1bmN0aW9uLgogCQkgICAgKGlidWZmZXItYWlmIChhc3NxIHN5bSBpYnVmZmVyLWlubGluZS1j b2x1bW5zKQogCQkJKG50aCAxIGl0KQotCQkgICAgICBgKCxzeW0gYnVmZmVyIG1hcmspKSkKKwkJ ICAgICAgYChvciAoLHN5bSBidWZmZXIgbWFyaykgIiIpKSkKIAkJICAgOzsgWW91J3JlIG5vdCBl eHBlY3RlZCB0byB1bmRlcnN0YW5kIHRoaXMuICBIZWxsLCBJCiAJCSAgIDs7IGRvbid0IGV2ZW4g dW5kZXJzdGFuZCBpdCwgYW5kIEkgd3JvdGUgaXQgZml2ZQogCQkgICA7OyBtaW51dGVzIGFnby4K LS0gCjIuMTAuMgoK --001a1146eb8aee68d7054bfade3a--