From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filippo Argiolas Newsgroups: gmane.emacs.bugs Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Date: Tue, 22 Aug 2023 09:09:28 +0200 Message-ID: References: <87edjw6wtz.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22018"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65418@debbugs.gnu.org, Philip Kaludercic , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 22 09:41:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYM0q-0005Yo-BG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Aug 2023 09:41:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYM0d-0004MU-TV; Tue, 22 Aug 2023 03:41:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYM0a-0004KF-H9 for bug-gnu-emacs@gnu.org; Tue, 22 Aug 2023 03:41:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYM0Z-00012Z-Ss for bug-gnu-emacs@gnu.org; Tue, 22 Aug 2023 03:41:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYM0c-0000oj-Gx for bug-gnu-emacs@gnu.org; Tue, 22 Aug 2023 03:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Filippo Argiolas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Aug 2023 07:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65418 X-GNU-PR-Package: emacs Original-Received: via spool by 65418-submit@debbugs.gnu.org id=B65418.16926900323093 (code B ref 65418); Tue, 22 Aug 2023 07:41:02 +0000 Original-Received: (at 65418) by debbugs.gnu.org; 22 Aug 2023 07:40:32 +0000 Original-Received: from localhost ([127.0.0.1]:58491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYM07-0000no-GJ for submit@debbugs.gnu.org; Tue, 22 Aug 2023 03:40:32 -0400 Original-Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:59455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYLWP-0005t1-3n for 65418@debbugs.gnu.org; Tue, 22 Aug 2023 03:09:49 -0400 Original-Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-56a8794b5adso1554171a12.2 for <65418@debbugs.gnu.org>; Tue, 22 Aug 2023 00:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692688180; x=1693292980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/0i7qF6qiyGosQY7r/AoBlCe4mjS/w5MTSq1F83VXlg=; b=NJGpM+FvJ0T0trp7JDQAxz2Hz8wXWURSDGONH1Mh8y/v7/9ym9JrT7qRASTEMgvsWO MVfKFNaHJh31Ej6ZcF2OtSF5GqCJHGmW4A6iI22fJ/1GqtG+DX/isdr1XnRYVu70CFiV TemkjBDtK+EDGtBqfxAOn/FJ66fEHh5/TLGyknopFRbrZFY29L6EqPZpa4+OLK3fwMfY S4wlWg4Ka5RkxFIJQBPakRHF4JCG4fUfUem4vQKvUm2+2/46osGA+Mi4RvYLq+b7+r7s lwPvGDFAbjcaE/cTib4CQAjjFrbG2UpKsEOCJSD6atdpoeSnab3khQCLPV1TnKmahXHb +F3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692688180; x=1693292980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/0i7qF6qiyGosQY7r/AoBlCe4mjS/w5MTSq1F83VXlg=; b=leeiuq2msCVtjv9ZWuECv3Lz4TQ4Xts4jbpwv6vbVcAER65KKxgoxnhy2ib/wvNN03 uMuVEkU4pKbPw58bv1dUc5DaJGi1sia+22G3iZwH4Ctty2Ju6fnxralcav0dFh3gYQ0j 2Ice4hL7sLz/Uoqb1zDrYCO6Cj0e8D2VbYwVp0+L9EzxrocRGk1xSzmi2mrGvc6JGfq3 JVOqdG/h7jmNTttQYLeCIFiDWFbjedL1X8dR2So25AalTRpaqs1jwghcfm5DOHRs3OcZ 1/ooh0ntd9WwFNr1wsaIogpvHFvGWYdZKUYtZTFuSz3RyJXjL6vScIzkA5J6REqS0yB/ dYIg== X-Gm-Message-State: AOJu0YzLvOi65Luyd4sxCZ4NWz27gAT4KrLNBBQQxE0L0/RQYfSkHLOS /vXIJwLQUnu4jnFZop4kg/wt3d84Tga8kxyPFa3KHyHs4z8= X-Google-Smtp-Source: AGHT+IHOlnPR0b5flxpIIYsQ5aliw3GyGVdp9PAJcu404NuWQ3wW7cCX3UNU9hdsJ99WEyX9KsFwirGYNThSFoADVS4= X-Received: by 2002:a17:90b:4f4d:b0:26b:e2b:6c8d with SMTP id pj13-20020a17090b4f4d00b0026b0e2b6c8dmr8043718pjb.41.1692688180603; Tue, 22 Aug 2023 00:09:40 -0700 (PDT) In-Reply-To: <87edjw6wtz.fsf@betli.tmit.bme.hu> X-Mailman-Approved-At: Tue, 22 Aug 2023 03:40:30 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268151 Archived-At: On Mon, Aug 21, 2023 at 9:04=E2=80=AFPM Felician Nemeth wrote: > > Filippo Argiolas writes: > > > [...] This was maybe possibile until now with clangd with semantic > > tokens but they've recently introduced a new protocol extension that > > should solve this problem in a much easier to implement way. > > In the past, Jo=C3=A3o wasn't keen on supporting non-standard features in > Eglot. I Cc'd him anyway as he is the maintainer of Eglot. Let's wait for feedback from Jo=C3=A3o then. I'd say this could warrant an exception on the basis that disabling code with the preprocessor is something specific enough to C/C++. It makes sense to have it as a server extension. Also this IMHO would solve quite an important problem with C development, not sure if it's worth waiting while we could solve it now with the extension and move to the standard protocol if and once the LSP spec will support this. > > Not sure UI-wise what would be the best approach, vscode patch reduces > > the opacity of the inactive regions but rendering them as comment > > would also be nice at first. > > Maybe hide-ifdef-mode is good for providing inspiration. No idea how easy that would be and if that makes sense but we could maybe follow the eglot philosophy of working with existing components and just forward inactive regions to hide-ifdef-mode? Filippo