unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Filippo Argiolas <filippo.argiolas@gmail.com>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: 65418@debbugs.gnu.org, "Philip Kaludercic" <philipk@posteo.net>,
	"João Távora" <joaotavora@gmail.com>
Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension
Date: Tue, 22 Aug 2023 09:09:28 +0200	[thread overview]
Message-ID: <CAOdrLGLxxH3Uqh2LfsZc-afB4hXajg8s=nQZy71=mZzVmiB+Dw@mail.gmail.com> (raw)
In-Reply-To: <87edjw6wtz.fsf@betli.tmit.bme.hu>

On Mon, Aug 21, 2023 at 9:04 PM Felician Nemeth
<felician.nemeth@gmail.com> wrote:
>
> Filippo Argiolas <filippo.argiolas@gmail.com> writes:
>
> > [...] This was maybe possibile until now with clangd with semantic
> > tokens but they've recently introduced a new protocol extension that
> > should solve this problem in a much easier to implement way.
>
> In the past, João wasn't keen on supporting non-standard features in
> Eglot.  I Cc'd him anyway as he is the maintainer of Eglot.

Let's wait for feedback from João then. I'd say this could warrant an
exception on the basis that disabling code with the preprocessor is
something specific enough to C/C++. It makes sense to have it as a
server extension.

Also this IMHO would solve quite an important problem with C
development, not sure if it's worth waiting while we could solve it
now with the extension and move to the standard protocol if and once
the LSP spec will support this.

> > Not sure UI-wise what would be the best approach, vscode patch reduces
> > the opacity of the inactive regions but rendering them as comment
> > would also be nice at first.
>
> Maybe hide-ifdef-mode is good for providing inspiration.

No idea how easy that would be and if that makes sense but we could
maybe follow the eglot philosophy of working with existing components
and just forward inactive regions to hide-ifdef-mode?

Filippo





  reply	other threads:[~2023-08-22  7:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21  8:41 bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Filippo Argiolas
2023-08-21 16:57 ` Philip Kaludercic
2023-08-21 19:04 ` Felician Nemeth
2023-08-22  7:09   ` Filippo Argiolas [this message]
2023-08-22  8:56     ` João Távora
2023-08-22 11:02       ` Filippo Argiolas
2023-08-25 12:18         ` João Távora
2023-08-27 10:52           ` Filippo Argiolas
2023-08-27 14:01             ` João Távora
2023-08-31 17:28               ` Filippo Argiolas
2023-09-04  1:05                 ` João Távora
2023-09-04  1:08                   ` João Távora
2023-09-04  3:59                     ` Filippo Argiolas
2023-09-04  4:09                       ` Filippo Argiolas
2023-09-04 10:51                         ` João Távora
2023-09-04 12:44                           ` Eli Zaretskii
2023-09-04 12:49                             ` João Távora
2023-09-04 16:17                               ` Eli Zaretskii
2023-09-04 20:37                                 ` João Távora
2023-09-04 11:41                     ` Eli Zaretskii
2023-09-02  8:14               ` Filippo Argiolas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOdrLGLxxH3Uqh2LfsZc-afB4hXajg8s=nQZy71=mZzVmiB+Dw@mail.gmail.com' \
    --to=filippo.argiolas@gmail.com \
    --cc=65418@debbugs.gnu.org \
    --cc=felician.nemeth@gmail.com \
    --cc=joaotavora@gmail.com \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).