From: Filippo Argiolas <filippo.argiolas@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: 65418@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Felician Nemeth <felician.nemeth@gmail.com>,
Philip Kaludercic <philipk@posteo.net>
Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension
Date: Mon, 4 Sep 2023 05:59:54 +0200 [thread overview]
Message-ID: <CAOdrLGJiC6L_cTrx+BkhEGFi1+opKtaSRhiCAkU7MOOOUFixeA@mail.gmail.com> (raw)
In-Reply-To: <CALDnm53=1OaMZCjhckXFimdY9AEmEre+JqYS4s-=6Th3n1mAbA@mail.gmail.com>
On Mon, Sep 4, 2023 at 3:06 AM João Távora <joaotavora@gmail.com> wrote:
>
> On Mon, Sep 4, 2023 at 2:05 AM João Távora <joaotavora@gmail.com> wrote:
> >
> > On Thu, Aug 31, 2023 at 6:28 PM Filippo Argiolas
> > <filippo.argiolas@gmail.com> wrote:
> > >
> > > On Sun, Aug 27, 2023 at 3:58 PM João Távora <joaotavora@gmail.com> wrote:
> > > > Glad to help. You're lucky I'm not some kind of wine connoisseur ;-)
> > > > Make a patch for that (and remember to also include the exportation of
> > > > the '--' symbols).
> > > >
> > >
> > > Many thanks again! That code definitely made this work week more enjoyable ;-)
> > >
> > > Sorry for the delay with the patch, little time left these days for
> > > side projects or even trivial contributions like this.
> > > See if the attached patches could do!
> >
> > They were very helpful. I just pushed heavily edited versions of
> > them to master. I used them as a starting point and credited you as
> > co-author (I could have done the other way round, crediting myself
> > as co-author, but the changes I did were a bit too extensive for
> > that).
No problem for me, edit as much as you want! just glad to help.
I'd be just as happy if you just thanked me in the commit message.
> Drats, I just noticed a very significant detail. I should have
> checked first, but you don't seem to have a FSF Copyright Assignment
> for Emacs. So I think I'll have to revert these two commits until we
> get one from you.
>
> I'm assuming you don't have a problem with that, else, we'll have to
> find another solution. Eli, can we send Filippo a CA request form?
I believe this contribution is trivial enough to not deserve any legal
paperwork.
It's just code written by yourself with a very few lines of docs you
used as a starting point to write your own.
I think it can be safely committed without issues, thanking me in the commit.
I don't think I have any problem with CA but I never saw the actual
forms, a bit skeptical if I'll have to involve my employer.
I'd say we consider this one as trivial enough and I could still sign
them to have them ready if I ever contribute something more
meaningful.
Filippo
next prev parent reply other threads:[~2023-09-04 3:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 8:41 bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Filippo Argiolas
2023-08-21 16:57 ` Philip Kaludercic
2023-08-21 19:04 ` Felician Nemeth
2023-08-22 7:09 ` Filippo Argiolas
2023-08-22 8:56 ` João Távora
2023-08-22 11:02 ` Filippo Argiolas
2023-08-25 12:18 ` João Távora
2023-08-27 10:52 ` Filippo Argiolas
2023-08-27 14:01 ` João Távora
2023-08-31 17:28 ` Filippo Argiolas
2023-09-04 1:05 ` João Távora
2023-09-04 1:08 ` João Távora
2023-09-04 3:59 ` Filippo Argiolas [this message]
2023-09-04 4:09 ` Filippo Argiolas
2023-09-04 10:51 ` João Távora
2023-09-04 12:44 ` Eli Zaretskii
2023-09-04 12:49 ` João Távora
2023-09-04 16:17 ` Eli Zaretskii
2023-09-04 20:37 ` João Távora
2023-09-04 11:41 ` Eli Zaretskii
2023-09-02 8:14 ` Filippo Argiolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOdrLGJiC6L_cTrx+BkhEGFi1+opKtaSRhiCAkU7MOOOUFixeA@mail.gmail.com \
--to=filippo.argiolas@gmail.com \
--cc=65418@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=joaotavora@gmail.com \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).