From: Troels Nielsen <bn.troels@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: Tobias Bading <tbading@web.de>, 11567@debbugs.gnu.org
Subject: bug#11567: 24.0.97; WTF? ROFL! (hilarious bug)
Date: Tue, 29 May 2012 00:49:20 +0200 [thread overview]
Message-ID: <CAOdE5WTNMK49+yEYuvgkNVfza_Egf3BAW4i3HTxSbqKES2Gb6w@mail.gmail.com> (raw)
In-Reply-To: <4FC3C1A2.7050800@gmx.at>
> Then maybe we should use `quit-window' in the first place. Attached
> find a patch for those who would give it a try (I hardly ever see the
> completions buffer).
Yes, it works nicely, as far as I can see when there is only one
frame. When anymore, the problem occurs just as before.
I suppose Stefan earlier hinted at something like this patch, which
together with your earlier simplification sort of fixes the problem.
Regards
Troels
=== modified file 'lisp/window.el'
--- lisp/window.el 2012-05-04 23:16:47 +0000
+++ lisp/window.el 2012-05-28 22:35:25 +0000
@@ -2371,7 +2371,10 @@ (defun window-deletable-p (&optional win
((frame-root-window-p window)
;; WINDOW's frame can be deleted only if there are other frames
;; on the same terminal.
- (unless (eq frame (next-frame frame 0))
+ (unless (or (eq frame (next-frame frame 0))
+ ;; Don't delete frame if its minibuffer is active.
+ (let ((minibuf (active-minibuffer-window)))
+ (and minibuf (eq frame (window-frame minibuf)))))
'frame))
((or ignore-window-parameters
(not (eq (window-parameter window 'window-side) 'none))
next prev parent reply other threads:[~2012-05-28 22:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 14:59 bug#11567: 24.0.97; WTF? ROFL! (hilarious bug) Tobias Bading
2012-05-27 22:33 ` Troels Nielsen
2012-05-28 10:26 ` martin rudalics
2012-05-28 14:14 ` Stefan Monnier
2012-05-28 18:19 ` martin rudalics
2012-05-28 22:49 ` Troels Nielsen [this message]
2012-05-29 9:42 ` martin rudalics
2012-05-29 12:23 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOdE5WTNMK49+yEYuvgkNVfza_Egf3BAW4i3HTxSbqKES2Gb6w@mail.gmail.com \
--to=bn.troels@gmail.com \
--cc=11567@debbugs.gnu.org \
--cc=rudalics@gmx.at \
--cc=tbading@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).