From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ernesto Alfonso Newsgroups: gmane.emacs.bugs Subject: bug#34193: 26.1; make-network-proces :host 'local fails with ipv6 Date: Sat, 26 Jan 2019 03:06:12 -0800 Message-ID: References: <87lg39xvsj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003f4dc505805a6fc2" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="128941"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34193@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 26 12:07:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnLnr-000XQz-CB for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2019 12:07:11 +0100 Original-Received: from localhost ([127.0.0.1]:57987 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnLnq-00043v-C3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2019 06:07:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnLnj-00043a-G9 for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2019 06:07:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gnLni-0003bU-Ob for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2019 06:07:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46580) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gnLni-0003bM-K4 for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2019 06:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gnLni-0000pX-EX for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2019 06:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ernesto Alfonso Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Jan 2019 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34193 X-GNU-PR-Package: emacs Original-Received: via spool by 34193-submit@debbugs.gnu.org id=B34193.15485007943156 (code B ref 34193); Sat, 26 Jan 2019 11:07:02 +0000 Original-Received: (at 34193) by debbugs.gnu.org; 26 Jan 2019 11:06:34 +0000 Original-Received: from localhost ([127.0.0.1]:45861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gnLnF-0000op-Mz for submit@debbugs.gnu.org; Sat, 26 Jan 2019 06:06:34 -0500 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:35012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gnLnD-0000oX-CQ for 34193@debbugs.gnu.org; Sat, 26 Jan 2019 06:06:31 -0500 Original-Received: by mail-wr1-f48.google.com with SMTP id 96so12866869wrb.2 for <34193@debbugs.gnu.org>; Sat, 26 Jan 2019 03:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pINOcC0owIr/qJFBrPFElNluDANz8SqCto3obhh2X0U=; b=Zrm+4y/Zrr7Lb+1k/xSugeAuo4TJ/BmMxVCsaa600KY/D0FEkjkEQl6yPiaXKA3/Sc opQoMdMCOMqs8MM0CtHglkCfd8X4MvcOAzebhc28lpVwTvOxc9zf8hy934LamdPjzO/g S3tZtd5F/7aqb4FUFp01Iw6FrTyFnG/5ltKPjSMazYlXDjbXby4T+TeVuDBeYB8YBStN l3nlhwX/bnZKmRbNeLUITAF3yAi0lhLi21NyUTBqzSWxu+XJu0iLOICOg92iYVNaGNJl ojYPJ611t6vdc5REkcOE/3yToZdjcKApXnkOgqryCwYBWzt6ljsapvY6mzRvBY2xPzQt /qBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pINOcC0owIr/qJFBrPFElNluDANz8SqCto3obhh2X0U=; b=Am2N+bc5AZ5bD8zkg7d2XEkaBM3DM/QEmjCRinTFq/mzZR3fZ9Ho5WXSr9IswarV7d XZ+TQBYDC52DLPVKs77AB8My39eN8n3MSAUNy3iQOoONWJGwNpzRW+E23AOnd65fahUM i377Oitl4ZBahzMPGwiDR3Z+jiamykyhwqcWV0Liydph49oI8p2WO6kJoWnyJS8DrHGh IqdshS5P2XCOZ8LPd8ygnK9BksxZxazzALsgqQ6AME5C4wL5nnPtD8QgLdxsCJNvbxPm rtgAUMkfe9Xq1UPf3bZEnGeziOQbzk6m/d74Fqdvo/pPC/wsKKh54hIRgT1hisxacnDg qm2w== X-Gm-Message-State: AJcUukeKc5U0X77HYEevTO8OOCiQUQ1Ar9bIwvjCxonCb00Kxpw3Xilu 0SSFgdLIc09fCNtguF0A7RVo1bM2JrRWlMu2VgBLGw== X-Google-Smtp-Source: ALg8bN7wPVcipd6B92/w4Hp9rhbgkCsTdjRH73LiuE+dXNE/hhknMBI/Yf1yjTv2YNQDHV3y3WlJMBRRZcmPJTS/+Qo= X-Received: by 2002:adf:8228:: with SMTP id 37mr14431291wrb.160.1548500785382; Sat, 26 Jan 2019 03:06:25 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154794 Archived-At: --0000000000003f4dc505805a6fc2 Content-Type: text/plain; charset="UTF-8" Thanks for looking into this. Ernesto On Sat, Jan 26, 2019, 3:04 AM Robert Pluim Robert Pluim writes: > > > Perhaps the minimal change would be to use "::1" when specifying > > :family 'ipv6? > > That would be this patch, which fixes this particular use case, and > shouldn't break anything else. > > diff --git i/src/process.c w/src/process.c > index c0741403b5..72351db3e6 100644 > --- i/src/process.c > +++ w/src/process.c > @@ -3983,14 +3983,24 @@ usage: (make-network-process &rest ARGS) */) > #ifdef HAVE_LOCAL_SOCKETS > if (family != AF_LOCAL) > #endif > - host = build_string ("127.0.0.1"); > + { > + if (family == AF_INET6) > + host = build_string ("::1"); > + else > + host = build_string ("127.0.0.1"); > + } > } > else > { > if (EQ (host, Qlocal)) > + { > /* Depending on setup, "localhost" may map to different IPv4 and/or > IPv6 addresses, so it's better to be explicit (Bug#6781). */ > - host = build_string ("127.0.0.1"); > + if (family == AF_INET6) > + host = build_string ("::1"); > + else > + host = build_string ("127.0.0.1"); > + } > CHECK_STRING (host); > } > > > > --0000000000003f4dc505805a6fc2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for looking into this.

=
Ernesto

On Sat, Jan 26, 2019, 3:04 AM Robert Pluim <rpluim@gmail.com wrote:
Robert Pluim <rpluim@gmail.com> writes:

> Perhaps the minimal change would be to use "::1" when specif= ying
> :family 'ipv6?

That would be this patch, which fixes this particular use case, and
shouldn't break anything else.

diff --git i/src/process.c w/src/process.c
index c0741403b5..72351db3e6 100644
--- i/src/process.c
+++ w/src/process.c
@@ -3983,14 +3983,24 @@ usage: (make-network-process &rest ARGS)=C2=A0 = */)
=C2=A0#ifdef HAVE_LOCAL_SOCKETS
=C2=A0 =C2=A0 =C2=A0 =C2=A0if (family !=3D AF_LOCAL)
=C2=A0#endif
-=C2=A0 =C2=A0 =C2=A0 =C2=A0host =3D build_string ("127.0.0.1");<= br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (family =3D=3D AF_INET6)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 host =3D build_string ("::1")= ;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 else
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 host =3D build_string ("127.0.0.1&= quot;);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0}
=C2=A0 =C2=A0else
=C2=A0 =C2=A0 =C2=A0{
=C2=A0 =C2=A0 =C2=A0 =C2=A0if (EQ (host, Qlocal))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Depending on setup, "localhost" ma= y map to different IPv4 and/or
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0IPv6 addresses, so it's better= to be explicit (Bug#6781).=C2=A0 */
-=C2=A0 =C2=A0 =C2=A0 =C2=A0host =3D build_string ("127.0.0.1");<= br> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (family =3D=3D AF_INET6)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 host =3D build_string ("::1")= ;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 else
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 host =3D build_string ("127.0.0.1&= quot;);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0CHECK_STRING (host);
=C2=A0 =C2=A0 =C2=A0}



--0000000000003f4dc505805a6fc2--