From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.bugs Subject: bug#50576: 28.0.50; display-buffer-in-previous-window no longer accepts window value for previous-window Date: Tue, 14 Sep 2021 08:37:17 -0500 Message-ID: References: <87wnnju1gr.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50576@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 14 15:44:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ8jR-0002AY-H3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 15:44:17 +0200 Original-Received: from localhost ([::1]:34456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ8jQ-00076r-CA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 09:44:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ8ig-0006vA-4Z for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 09:43:30 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ8dP-00071C-2T for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 09:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ8dO-0003Pf-Uo for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 09:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Adam Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2021 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50576 X-GNU-PR-Package: emacs Original-Received: via spool by 50576-submit@debbugs.gnu.org id=B50576.163162665613078 (code B ref 50576); Tue, 14 Sep 2021 13:38:02 +0000 Original-Received: (at 50576) by debbugs.gnu.org; 14 Sep 2021 13:37:36 +0000 Original-Received: from localhost ([127.0.0.1]:48035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ8cy-0003Os-Da for submit@debbugs.gnu.org; Tue, 14 Sep 2021 09:37:36 -0400 Original-Received: from mail-lf1-f45.google.com ([209.85.167.45]:42734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ8cx-0003Of-2F for 50576@debbugs.gnu.org; Tue, 14 Sep 2021 09:37:35 -0400 Original-Received: by mail-lf1-f45.google.com with SMTP id bq5so28890264lfb.9 for <50576@debbugs.gnu.org>; Tue, 14 Sep 2021 06:37:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zik7JyFdpNyGHOXQGZPBvbkClV2k6kbKk2NUrKtr48o=; b=vlmx8NU0NhGnzyt695B9ohJ1YXIYspehTh/1w0QtHmVYiQ6PFFPHT+urWPgDFTb375 ioknJUxVRg0ttC/mVu0tSv8gG1jW39B9skbgqntUyKFmlSEaDbbXXWz7UlNekeJ6KPnS FbYO9eLeiAKRVOGGXVAF3t8ANooYTtuGmp/K09X7M7iKt6JvR/a7VUTZc6UcTV8MwObT uTbhB6naV6irNPmdsPx9CCYjjgKnjNPMg4gr7HT8PQcX9P2HWoIYsf0YuCWqkA3hW66T uhYG/DmYBC2ttSubl0fcX9zaXlToRHy6g2xzh4crepqbPsWkv5qRVTprsikMDMvhMlDh oc6w== X-Gm-Message-State: AOAM533TM/YJZGbP8EUZIBUo94VKN8QsEKz0f1KqrOHXxfgcDhs/o9nc Dyyr7qI9wNJhRZucCFKSTEuUQ5Ijko2We1YT8gPR6D7xMGo= X-Google-Smtp-Source: ABdhPJzGut1y79W3QR70SY8h9OkqGQfa/9sH10M4tA92qhwaC3dKysw9DQ/kEMvUxwSkXP+qSbbGI/Z4fZpv1rhXB+M= X-Received: by 2002:ac2:4ecf:: with SMTP id p15mr13005681lfr.2.1631626649011; Tue, 14 Sep 2021 06:37:29 -0700 (PDT) In-Reply-To: <87wnnju1gr.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214310 Archived-At: Hi Juri, On Tue, Sep 14, 2021 at 1:44 AM Juri Linkov wrote: > Sorry, this was a wrong assumption. Does this patch correctly fix it? > > diff --git a/lisp/window.el b/lisp/window.el > index 2960384e15..1c795cf684 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -8363,7 +8363,7 @@ display-buffer-in-previous-window > (throw 'best t))))) > ;; When ALIST has a `previous-window' entry, that entry may override > ;; anything we found so far. > - (when (and previous-window (boundp previous-window)) > + (when (and previous-window (symbolp previous-window) (boundp previous-window)) > (setq previous-window (symbol-value previous-window))) > (when (and (setq window previous-window) > (window-live-p window) Yes, that seems to work. Thanks.