From: Adam Porter <adam@alphapapa.net>
To: Juri Linkov <juri@linkov.net>
Cc: 50576@debbugs.gnu.org
Subject: bug#50576: 28.0.50; display-buffer-in-previous-window no longer accepts window value for previous-window
Date: Tue, 14 Sep 2021 08:37:17 -0500 [thread overview]
Message-ID: <CAO_b3FXncAyzcbWOS1Ogd9Fwb+nvGGMXyPy1o-jQq6YquPuVXA@mail.gmail.com> (raw)
In-Reply-To: <87wnnju1gr.fsf@mail.linkov.net>
Hi Juri,
On Tue, Sep 14, 2021 at 1:44 AM Juri Linkov <juri@linkov.net> wrote:
> Sorry, this was a wrong assumption. Does this patch correctly fix it?
>
> diff --git a/lisp/window.el b/lisp/window.el
> index 2960384e15..1c795cf684 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -8363,7 +8363,7 @@ display-buffer-in-previous-window
> (throw 'best t)))))
> ;; When ALIST has a `previous-window' entry, that entry may override
> ;; anything we found so far.
> - (when (and previous-window (boundp previous-window))
> + (when (and previous-window (symbolp previous-window) (boundp previous-window))
> (setq previous-window (symbol-value previous-window)))
> (when (and (setq window previous-window)
> (window-live-p window)
Yes, that seems to work. Thanks.
next prev parent reply other threads:[~2021-09-14 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 0:43 bug#50576: 28.0.50; display-buffer-in-previous-window no longer accepts window value for previous-window Adam Porter
2021-09-14 6:35 ` Juri Linkov
2021-09-14 13:37 ` Adam Porter [this message]
2021-09-15 6:48 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO_b3FXncAyzcbWOS1Ogd9Fwb+nvGGMXyPy1o-jQq6YquPuVXA@mail.gmail.com \
--to=adam@alphapapa.net \
--cc=50576@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).