From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.bugs Subject: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild Date: Thu, 26 Aug 2021 11:47:09 -0500 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17736"; mail-complaints-to="usenet@ciao.gmane.io" To: 50214@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 26 18:48:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJIXx-0004Qn-Q0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 18:48:09 +0200 Original-Received: from localhost ([::1]:53504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJIXw-0003dF-BS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 12:48:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJIXq-0003cr-7E for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJIXp-0006GH-VT for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJIXp-0008IT-Tx for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Adam Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Aug 2021 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50214 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162999644830824 (code B ref -1); Thu, 26 Aug 2021 16:48:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Aug 2021 16:47:28 +0000 Original-Received: from localhost ([127.0.0.1]:50266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJIXH-00080n-V9 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 12:47:28 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:56872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJIXF-0007zA-V3 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 12:47:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJIXF-0003bE-Mb for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:47:25 -0400 Original-Received: from mail-lf1-f46.google.com ([209.85.167.46]:40777) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJIXD-0005rB-Sv for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:47:25 -0400 Original-Received: by mail-lf1-f46.google.com with SMTP id bq28so8182773lfb.7 for ; Thu, 26 Aug 2021 09:47:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=T+SMzDdJb4KVdmGg8AwvJAIDkHD8kmUP7VL1hbSgtwc=; b=Kc2l5VVvYUDVMpfhuIPp1FWP2Y+qKsSRMliW7bBwVjGfaqXJQSM1wTQRRiYcZfLvdh W7K/RN3evhrq5fvBqv9OrD6TiwbsQZ2ly9fYWbCXtWZ31IpoSNsh1faGfS2SlbWYLsJL hnoCkiq1bBZZGKQ1srGaSYC/SVbQztKcuXJN+g4OwxGsAjQpKCaQMo+PVPSboZMSIMgK 452TRB+evO4phbLhg5EcCfrTdU+LGZc59kF/WmY7djRq4BHn8IkbPlwMHCdcaZYau2dM To5s0Z7HZ9ZEl14P2J5y1k5WsVmR7VFwUPsS9Kdik5N8c771oDNCXI+3oL1qufCR9XME Ajcw== X-Gm-Message-State: AOAM532VgTS2bXqoTD1NLdOUYSAtDLzVuHn08xyDmX8Zp02u1s2w0Y3T Nfqh9T6vleRjsv6kKDhN6llf6Epak+zaU2nLd6fjzERq9Ns= X-Google-Smtp-Source: ABdhPJwvWvX6O90iJtIPKmOwssDC0CYjRyOFfpr3n6akTAH/cUe53EvoI1Mxufpg56U+A/zkUH+77QlKdF5xP2M3ZNg= X-Received: by 2002:a05:6512:398b:: with SMTP id j11mr3528799lfu.102.1629996440689; Thu, 26 Aug 2021 09:47:20 -0700 (PDT) Received-SPF: pass client-ip=209.85.167.46; envelope-from=alphadeltapapa@gmail.com; helo=mail-lf1-f46.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212731 Archived-At: Hi, A helpful user of my ts.el package discovered a change in Emacs 28 that breaks it: https://github.com/alphapapa/ts.el/issues/18 Specifically, this commit changes the internal struct constructor from a plist to an alist: https://github.com/emacs-mirror/emacs/commit/3788d2237d4c65b67b95e33d1aca8d8b41780429 For example: ;; Emacs 28.0.50 (nth 1 (cl-struct-slot-info 'ts)) ;; => ;; (hour ;; nil ;; :type integer ;; (:accessor-init string-to-number ;; (format-time-string ;; "%H" ;; (ts-unix struct))) ;; (:aliases H) ;; (:constructor . "%H")) ;; Emacs 27.2.50 (nth 1 (cl-struct-slot-info 'ts)) ;; => ;; (hour ;; nil ;; :type integer ;; :accessor-init (string-to-number ;; (format-time-string ;; "%H" ;; (ts-unix struct))) ;; :aliases (H) ;; :constructor "%H") Unfortunately this breaks how ts.el works. Of course, that can be worked around with a version check, but that means that users who upgrade to Emacs 28 without upgrading ts.el will encounter failures. I don't know if this is something you'd want to reconsider. I guess there was a good reason for the changes being made. And maybe what ts.el is doing is considered unsupported, which would seem like a not-unreasonable position. Anyway, I'm reporting this so the issue is officially documented and any decisions can be made accordingly. Thanks, Adam