From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.bugs Subject: bug#47368: 28.0.50; map-elt returns nil without "deprecated" TESTFN Date: Wed, 21 Jul 2021 10:34:14 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30410"; mail-complaints-to="usenet@ciao.gmane.io" To: 47368@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 21 17:35:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6EFZ-0007mY-PQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 17:35:09 +0200 Original-Received: from localhost ([::1]:57694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6EFY-0007J4-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 11:35:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6EFS-0007Is-Fe for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 11:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6EFS-00014H-83 for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 11:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6EFS-0000JP-2i for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 11:35:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Adam Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jul 2021 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47368 X-GNU-PR-Package: emacs Original-Received: via spool by 47368-submit@debbugs.gnu.org id=B47368.16268816731153 (code B ref 47368); Wed, 21 Jul 2021 15:35:02 +0000 Original-Received: (at 47368) by debbugs.gnu.org; 21 Jul 2021 15:34:33 +0000 Original-Received: from localhost ([127.0.0.1]:38322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6EEz-0000IX-2i for submit@debbugs.gnu.org; Wed, 21 Jul 2021 11:34:33 -0400 Original-Received: from mail-lj1-f182.google.com ([209.85.208.182]:41932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6EEx-0000IK-If for 47368@debbugs.gnu.org; Wed, 21 Jul 2021 11:34:31 -0400 Original-Received: by mail-lj1-f182.google.com with SMTP id c23so3517229ljr.8 for <47368@debbugs.gnu.org>; Wed, 21 Jul 2021 08:34:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=I2HSF5FWDVaNslZFkM7BCwLCEWnRM8aNrnNspWBrICI=; b=QzTqq74DBrS8FfL1Yt8jNp4n1fwvJOn5+W46pwF2rBW6JMrc+WuWZiyD55r+mljQab +6Mq6WEqTy7elprsEEVBNnVu25d5MOaknxpOqT8Huua7RUXgu6VgKM5BVT7Zm7IAGeD7 i+UYqkXE+iNsiIklF5b7ycn5PUFh1MByZecDv7ora0bimIjsd46lC71zQrbYfN1cJ/kU sbQFx7VAK3bTE7d3US2OsrMrGXes61TyXl0L5uHkQgIaTEicgiTDwnSXtzyZH1U4zWhB V0AoosyLMUf9/heEolUfh8UJ1Bf848bJQyLcsqS4KhoejSja93Fcp7/HaL7UF5RwAMt6 BOvg== X-Gm-Message-State: AOAM532O+cEtmQoOf2iV34k5CbcDEGmzAGU1SrHgw96A4U3i1wQgXKPw jsk08zMn9PxW4dpa0RoDJCN8rlpZt/L+wfl7wzD97USstlA= X-Google-Smtp-Source: ABdhPJwcgfkxCIoGijUvEipxZ4F/awuyl5y1/nFN7eOjrfJ9Urdpz9c7DlLWf164T2LhXEMeB5GLHSPvNd3KBDnu/nA= X-Received: by 2002:a2e:8690:: with SMTP id l16mr10110093lji.202.1626881665454; Wed, 21 Jul 2021 08:34:25 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210458 Archived-At: Hi, If I may chime in here, I'd like for map-elt to be usable with alists having string keys. It may not generally be very common in Elisp to use alists with string keys, but in certain contexts, like preparing JSON maps for encoding, it is. In one of my packages, I came up with this workaround, which may be tolerable when only used once in the whole package, but wouldn't be nice to use more often: (cl-letf (((symbol-function 'alist-get) (lambda (key alist &optional _default _remove _testfn) (cdr (assoc-string key alist))))) (let ((alist (list (cons "foo" "FOO") (cons "bar" "BAR")))) (map-elt alist "foo"))) ;;=> "FOO" In one of my other packages, I would have to use it more often, so I guess I'll use alist-get for now. In general, I think that using `equal' is a good solution. It seems like map-elt is intended to abstract over some Lisp implementation details (to some extent, anyway), so using `equal' instead of `eq' seems sensible, since I think it will usually DWIM. If I really need to compare Lisp object identity rather than equality, I'll probably know how, and I probably won't need to do that as often, anyway. Could this change be made for Emacs 28 and tagged for a 3.1 release of map.el? Thanks, Adam