From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.bugs Subject: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild Date: Thu, 26 Aug 2021 15:52:30 -0500 Message-ID: References: <87y28ot2u8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23285"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50214@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 26 22:53:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJMN5-0005mB-7d for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 22:53:11 +0200 Original-Received: from localhost ([::1]:59062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJMN3-0001R0-6P for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 16:53:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJMMw-0001Oy-9s for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 16:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39059) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJMMw-00022D-2Q for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 16:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJMMv-0000Dk-Oo for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 16:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Adam Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Aug 2021 20:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50214 X-GNU-PR-Package: emacs Original-Received: via spool by 50214-submit@debbugs.gnu.org id=B50214.1630011170831 (code B ref 50214); Thu, 26 Aug 2021 20:53:01 +0000 Original-Received: (at 50214) by debbugs.gnu.org; 26 Aug 2021 20:52:50 +0000 Original-Received: from localhost ([127.0.0.1]:50605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJMMk-0000DL-93 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 16:52:50 -0400 Original-Received: from mail-lf1-f54.google.com ([209.85.167.54]:45820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJMMh-0000D3-Om for 50214@debbugs.gnu.org; Thu, 26 Aug 2021 16:52:48 -0400 Original-Received: by mail-lf1-f54.google.com with SMTP id g13so9561311lfj.12 for <50214@debbugs.gnu.org>; Thu, 26 Aug 2021 13:52:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i9SYoKokJAt4KDXmdwBf/GmmPujPgiRkj5srJV1y06g=; b=YOq6iy6+W1eFicXnDCHxFbwczyHkBcHAHsKDKOu4/ZusYiCM5+uI8VkjuBgVuA1LSx D38PDQnHgFSD6EK61fKHGbJFOPfNqutVeyogI81bDY23MKGHcqxXHE0kYoZJQNL4B7pI xVNBmBu2RPvHqFlpNxKGr3dkfM5oQueEJ6dP29IMhBU2qnb0WvOcNNnxEJGW/uZAGMPg OuWQfWFDJeEkjxPqiOxxmsNkvNpl4TtGYrNVg39NOkwGk+lMRhQd/zda1NB7nO1lqSKB BML3K1mPEAejP9OjMn5/5kStMzIGv+xUt+OlPsRVuU+Llok4TAwVPToxuOVRfAMtqo6n dYJg== X-Gm-Message-State: AOAM533C56L4daVJ9WyThuBCEYI3v3K15lTi1yUtQotQf5qw1Wv2iPC6 QhcP6jj0G9wDOV2ZBhkpgFvcwGMQVEPmlEG5x5Q= X-Google-Smtp-Source: ABdhPJzB3suDBFjhZFp/3spMtU56Yy62pQxrp4HHYfu0hzqEkEgC7pAtbz3cp4lrh5p3yrfE9Ry7YqCqWmQQRjG94Dc= X-Received: by 2002:ac2:4146:: with SMTP id c6mr4464868lfi.305.1630011161368; Thu, 26 Aug 2021 13:52:41 -0700 (PDT) In-Reply-To: <87y28ot2u8.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212763 Archived-At: On Thu, Aug 26, 2021 at 2:37 PM Lars Ingebrigtsen wrote: > > I'm not very familiar with the internals of cl-struct, but if I > understand correctly, I think this is... well... an internal thing > that package writers should expect to change, so they shouldn't rely on > things like this. Unfortunately, I know of no other way to implement what ts.el does without modifying the accessors, which requires accessing the internal struct details after it is defined. Unless I've missed something, or something has changed, of course. Regardless, the library's been working well for the almost 3 years since I wrote it, and it's used in various packages now, even including a few not my own. :) Anyway, if I have to add an Emacs-version check, that's not a big deal. I'll just have to answer the inevitable "I upgraded to Emacs 28 and your package doesn't work anymore" reports.