From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
To: Yuan Fu <casouri@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 72863@debbugs.gnu.org, mail@ssbb.me
Subject: bug#72863: 30.0.50; tree-sitter elixir-ts-mode hangs and memory leak on some elixir and heex code
Date: Mon, 16 Sep 2024 08:58:48 +0200 [thread overview]
Message-ID: <CAOS0-37D61jvdcTpOHKX5PJ497QQECKE31e_7rTDs2=eDra+Mw@mail.gmail.com> (raw)
In-Reply-To: <6E186236-8610-4240-9441-0CAA666FB03F@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2680 bytes --]
Thanks Yuan, and thanks for the improvements on elixir-ts-mode.
Kind regards,
Wilhelm
On Thu, Sep 12, 2024 at 9:47 AM Yuan Fu <casouri@gmail.com> wrote:
>
>
> > On Sep 11, 2024, at 12:22 PM, mail@ssbb.me wrote:
> >
> > Wow, thank you so much for diving into this issue! I'll keep track of it
> in tree-sitter repo from now on.
>
> My pleasure ;-)
>
> > It seems like other integrations somehow manage to avoid hanging or
> crashing the main process, so it doesn't affect them?
> > I just checked in the Zed editor again to confirm. When I type a={, it
> fails to highlight the rest of the embedded HEEX (but only within the
> current function) though.
>
> I know a couple editors uses async parsing, Zed probably also uses async
> parsing.
>
> Yuan
>
>
> >> On Sep 11, 2024, at 7:45 AM, Yuan Fu <casouri@gmail.com> wrote:
> >>
> >>
> >>
> >>> On Sep 8, 2024, at 12:48 AM, Yuan Fu <casouri@gmail.com> wrote:
> >>>
> >>>
> >>>
> >>>> On Sep 8, 2024, at 12:02 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >>>>
> >>>>> From: Yuan Fu <casouri@gmail.com>
> >>>>> Date: Sat, 7 Sep 2024 22:57:29 -0700
> >>>>> Cc: mail@ssbb.me,
> >>>>> wkirschbaum@gmail.com,
> >>>>> 72863@debbugs.gnu.org
> >>>>>
> >>>>>
> >>>>>
> >>>>>> On Sep 7, 2024, at 10:54 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> >>>>>>
> >>>>>>> From: Yuan Fu <casouri@gmail.com>
> >>>>>>> Date: Sat, 7 Sep 2024 22:44:53 -0700
> >>>>>>> Cc: Wilhelm Kirschbaum <wkirschbaum@gmail.com>,
> >>>>>>> Eli Zaretskii <eliz@gnu.org>,
> >>>>>>> 72863@debbugs.gnu.org
> >>>>>>>
> >>>>>>> Meanwhile, I want to push the fix for the other bug I discovered
> to emacs-30. Eli, I wrote a debugging function that prints parser states,
> naturally this function isn’t called anywhere so there’ll be a compiler
> warning, what should I do in this case?
> >>>>>>
> >>>>>> Why would there be a compiler warning? What kind of warning?
> >>>>>
> >>>>> A function-not-used warning. Maybe it’s an lldb thing?
> >>>>
> >>>> If the function is not static, there should be no such warning.
> >>>
> >>> Ah, you’re right, I marked it static. Thanks!
> >>>
> >>> Yuan
> >>
> >> Good news: not an Emacs bug. Bad news: a tree-sitter bug. Turns out I
> made an error in my test program, which is the reason why Emacs hangs but
> the test program doesn’t. Once I fixed the error, the test program hangs
> too. I submitted a bug report to tree-sitter:
> https://github.com/tree-sitter/tree-sitter/issues/3620
> >>
> >> I can finally sleep soundly at night now; and I guess tree-sitter dev
> will start having sleepless nights :-)
> >>
> >> Yuan
> >>
> >
>
>
[-- Attachment #2: Type: text/html, Size: 4556 bytes --]
prev parent reply other threads:[~2024-09-16 6:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 2:57 bug#72863: 30.0.50; tree-sitter elixir-ts-mode hangs and memory leak on some elixir and heex code mail
2024-08-29 5:09 ` Eli Zaretskii
2024-08-29 6:13 ` Wilhelm Kirschbaum
2024-08-29 6:14 ` Yuan Fu
2024-09-04 6:39 ` Wilhelm Kirschbaum
2024-09-04 7:42 ` mail
2024-09-05 4:32 ` Yuan Fu
2024-09-08 5:44 ` Yuan Fu
2024-09-08 5:54 ` Eli Zaretskii
2024-09-08 5:57 ` Yuan Fu
2024-09-08 7:02 ` Eli Zaretskii
2024-09-08 7:48 ` Yuan Fu
2024-09-11 3:45 ` Yuan Fu
2024-09-11 19:22 ` mail
2024-09-12 7:47 ` Yuan Fu
2024-09-16 6:58 ` Wilhelm Kirschbaum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOS0-37D61jvdcTpOHKX5PJ497QQECKE31e_7rTDs2=eDra+Mw@mail.gmail.com' \
--to=wkirschbaum@gmail.com \
--cc=72863@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=mail@ssbb.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).