From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Wilhelm Kirschbaum Newsgroups: gmane.emacs.bugs Subject: bug#67246: 30.0.50; elixir-ts-mode uses faces inconsistently Date: Fri, 24 Nov 2023 20:56:41 +0200 Message-ID: References: <87y1ewgnn7.fsf@gmail.com> <4f4e3d4c-e162-4007-a9b5-8210ea2f044b@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000eccd34060aea8380" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10146"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67246@debbugs.gnu.org, Dmitry Gutov To: Andrey Listopadov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 24 19:58:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6bNP-0002M5-CF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Nov 2023 19:58:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6bNI-0005wy-Tt; Fri, 24 Nov 2023 13:58:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6bNG-0005sG-4Q for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2023 13:57:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6bNF-0000pz-BQ for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2023 13:57:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6bNJ-0007hV-UW for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2023 13:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Wilhelm Kirschbaum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Nov 2023 18:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67246 X-GNU-PR-Package: emacs Original-Received: via spool by 67246-submit@debbugs.gnu.org id=B67246.170085222529529 (code B ref 67246); Fri, 24 Nov 2023 18:58:01 +0000 Original-Received: (at 67246) by debbugs.gnu.org; 24 Nov 2023 18:57:05 +0000 Original-Received: from localhost ([127.0.0.1]:37289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6bMO-0007gC-Rb for submit@debbugs.gnu.org; Fri, 24 Nov 2023 13:57:05 -0500 Original-Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]:49256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6bMM-0007fa-Po for 67246@debbugs.gnu.org; Fri, 24 Nov 2023 13:57:03 -0500 Original-Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1ef36a04931so1337625fac.2 for <67246@debbugs.gnu.org>; Fri, 24 Nov 2023 10:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700852212; x=1701457012; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CIyPNZZhHbrnqroR7MjOJAiTi/cUGN6B2z7KXQdiUXU=; b=iuiPDrlNrtqQzKm+bjLGlF4ZwIIimdKD8IvIfHJNz0XbliG5gMpnW3DpNXnehtfz6G +sJBvPLVZu9iYmaR5eeIrVVy6PyoMArLUCF76DVC+NkWe7Z2G7lR7+ulWWdsaOQjxkZB ehjKPL5T9E5AWYZlrCJ6/6juYC7KWI3FK7EUeHwjB7NeLCxRS470uQccoDWainJNz5z/ Na2Gnm9ljlT/4dY5TYoHTaQEUOnSIhAYwBc4fpEVMUzMikqZsxemXxy/99CCLXZieOIU DYjLH3njrzXkMmgy1Oa4qecJOYp5pfmZjk0y57UC1tXP9vYdGbWir+4DLN6TZM6MmF2p upTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700852212; x=1701457012; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CIyPNZZhHbrnqroR7MjOJAiTi/cUGN6B2z7KXQdiUXU=; b=KFp4lHh0ixuUbS06NPoI14h6k38yQyEp/wikdYHzfkDhgZy9uJxh96WN0oU7rJCmAC eKwv6a27rNC3XZPhg+tAa8hodrTbM5XaKLZarcy6RLl27PuEVCe/ll1TxMwDiXDQlxSA e3TX1yNuV8/LfooqFQgwRz/t+vmiQHQ3SWde+OX1abfs6hGLNWdU+ii8YfylG32XELNn GZqrz99e8XEmKPLpTxsSLy5IVYWY9dBsEpLk9aeowQKI86Ihqsfbr8upWpqxoAtcK8Nc KFJPU3Hei1sFFnbgTUyFJ30IWeb2M3GzLKjWF3JSJvGWWLmPH+MsYkZZs9b6wZId7gjG CSNA== X-Gm-Message-State: AOJu0YwhOZnmqBpIf2nbiKxo03yV/3d8Zmvsu86Z+sPaUD0QcGbnr/E8 cZykZE13rjgzbFKSvucmOXdyXgyBZ9IprHR7SM8= X-Google-Smtp-Source: AGHT+IENlX7v6Gmc/Gy4H0g/cRtmiFnThRx4l4xmKw0ThJymP/t1BIHdY6obNuUkIAGIIB2UMubK8G7iyF57uNygWoY= X-Received: by 2002:a05:6870:b10:b0:1eb:4805:30d9 with SMTP id lh16-20020a0568700b1000b001eb480530d9mr4676943oab.49.1700852212221; Fri, 24 Nov 2023 10:56:52 -0800 (PST) In-Reply-To: <4f4e3d4c-e162-4007-a9b5-8210ea2f044b@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274884 Archived-At: --000000000000eccd34060aea8380 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry for the late response. On Mon, Nov 20, 2023 at 12:00=E2=80=AFPM Andrey Listopadov wrote: > Nov 20, 2023 04:50:27 Dmitry Gutov : > > > I guess I expected that if the mode has been added to the core then the > > development is led here too. And modes maintained externally live more > > easily in ELPA. Anyway, we are where we are. > I agree, but not sure how to deal with the users already using it on emacs 29.1 with the MELPA package. When I wanted to submit the package, I remember there being an email saying we should not add packages to ELPA yet, so now I am stuck with the github repository and MELPA. Once 30 drops it should be easier to redirect conversations here, not sure how this works. The packages are slightly different and I regret my earlier decisions. > > I thought the same thing. I wonder if there are other modes that continue > development on melpa first, and what is the proper way to set up the > override in my init.el. I'll have to look into that, I guess. > There is no need to set an override if you use a conventional method of loading the package as far as I know. > > > I haven't done too much testing myself. Perhaps Andrey will take the > > upstream version for a spin. Or we'll wait for the changes to be merged > > here and continue. > > I have pulled the melpa package, and at level 2 the font locking now > seems to be correct (I grew to expect syntax highlights to highlight > important parts of the code, so level 2 seems the most appropriate to me > personally). Thanks for the changes! However, I don't know how exactly > tree sitter mode should be organizedm so I can't give a proper review on > the changes - if there's a guide or a manual for that, I'd like to read > it. > Thanks for checking. Any feedback will be very helpful, I will prep the patch in the next day or two. Wilhelm --000000000000eccd34060aea8380 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry for the late response.

On Mon, Nov 20, 2023 at 12:00=E2=80=AFPM Andr= ey Listopadov <andreyorst@gmail.= com> wrote:
Nov 20, 2023 04:50:27 Dmitry Gutov <dmitry@gutov.dev>:

> I guess I expected that if the mode has been added to the core then th= e
> development is led here too. And modes maintained externally live more=
> easily in ELPA. Anyway, we are where we are.

=
I agree, but not sure how to deal with the users already us= ing it on emacs 29.1 with the MELPA package.=C2=A0=C2=A0
When I wanted to submit the package, I remember there being an email saying=20 we should not add packages to ELPA yet, so now I am stuck with the=20 github repository and MELPA.
Once 30 drops it should be easi= er to redirect conversations here, not sure how this works.=C2=A0 The packa= ges are slightly different and I regret my earlier decisions.
=C2=A0

I thought the same thing. I wonder if there are other modes that continue <= br> development on melpa first, and what is the proper way to set up the
override in my init.el. I'll have to look into that, I guess.

There is no need to set an override if you use a= conventional method of loading the package as far as I know.
=C2=A0

> I haven't done too much testing myself. Perhaps Andrey will take t= he
> upstream version for a spin. Or we'll wait for the changes to be m= erged
> here and continue.

I have pulled the melpa package, and at level 2 the font locking now
seems to be correct (I grew to expect syntax highlights to highlight
important parts of the code, so level 2 seems the most appropriate to me personally).=C2=A0 Thanks for the changes!=C2=A0 However, I don't know = how exactly
tree sitter mode should be organizedm so I can't give a proper review o= n
the changes - if there's a guide or a manual for that, I'd like to = read
it.

Thanks for checking.=C2=A0 Any feed= back will be very helpful, I will prep the patch in the next day or two.

Wilhelm
--000000000000eccd34060aea8380--