From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Wilhelm Kirschbaum Newsgroups: gmane.emacs.bugs Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Date: Thu, 2 Jan 2025 10:56:35 +0200 Message-ID: References: <86zfk9k3xr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000008705e4062ab55765" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9838"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 75192@debbugs.gnu.org, casouri@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 09:57:14 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTH10-0002Pu-4u for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 09:57:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTH0u-0001ti-V1; Thu, 02 Jan 2025 03:57:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTH0t-0001tM-LZ for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 03:57:07 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTH0o-00025b-3C for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 03:57:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=9ymt10bLaq5hPftWF+ztTwGXkwZWgXLus/sgOLcggIk=; b=txLHWFHQVxkYvC5zDpqTgNAEkwAYx9tLyjk9tCw9uUHY1MFzUy+vhO75DdNe/HUS5nEYGYjv4HBb/OTntTaexQeunDYqO7Yis+0B5AdM5mR6luTOwjzYg3NXVJq0Jby/aR9sslsWVftagf5/KGlgkji78aXXM/5ttnr7VSmnCgiNmMft93xv6X6OJyePManZVKIeqazNBMx3KF0gbVIemRPkHKq1If4TNHhPDuUP4fur0IJ8V64LayT8RPh0Pfr/nQl5wC/l9/jNaM5hMt6EMgoMRYY4860vIdlj1Yg0ZvpNFimHIEOO5nX+ogmmVWecD5thvtNS/ZKXGZXbod1nIA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTH0n-0005FF-Sv for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 03:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Wilhelm Kirschbaum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 08:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75192 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75192-submit@debbugs.gnu.org id=B75192.173580820820142 (code B ref 75192); Thu, 02 Jan 2025 08:57:01 +0000 Original-Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 08:56:48 +0000 Original-Received: from localhost ([127.0.0.1]:42733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTH0a-0005En-E9 for submit@debbugs.gnu.org; Thu, 02 Jan 2025 03:56:48 -0500 Original-Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:61707) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTH0Y-0005Eg-TL for 75192@debbugs.gnu.org; Thu, 02 Jan 2025 03:56:47 -0500 Original-Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-7b702c3c021so978818985a.3 for <75192@debbugs.gnu.org>; Thu, 02 Jan 2025 00:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735808206; x=1736413006; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9ymt10bLaq5hPftWF+ztTwGXkwZWgXLus/sgOLcggIk=; b=L4Zp9yp45FtohaBH3mlO24YWGPF/yFcfW9gwzask9USQZ2W4UR7P9+psB97lE+yDeZ JO1qdnEEh67RdzFbq29dJIUzgR8o26wCUnE1ug996TmV9kYdP9cuTlgJZhtxPghvrWJ/ lF3PvlTiQQW3idq3MhLaGjnmlREX+bh6aVzlr+hhrIBNH7jNRk0JNtsqnhF0GOx3GPPn 3ZU5ua6aNXVDPwSWun2LBHXrBEuEaY3RikUYjl8lTqMfosOCaT2zuveYerWsoLSxxwEo u0F3bUGsx+bgTERer6tbJcdETMXD4GCp1yueceCn3vWN2pqX18rgw3NYs8sxjIPBuiIq DGZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735808206; x=1736413006; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9ymt10bLaq5hPftWF+ztTwGXkwZWgXLus/sgOLcggIk=; b=EXspGf08GGt14LiHz3ZCFjyszaLghLqxzb8DntFBa7A3j+a2/aHJ3D5jubgnVVtEjU 5OMfwf62C+fdcB66Wq/trUUoKZVqt7vHJbW2aJh8uNfI2Z4Nl+PyA4R5k57pW4X+o0DE X9gI5CRQxpomCvuk4Tgl4rowJWBw0nO6ezdCcfbG54gMsg+DJiIva/ZDQMBHBkjEO7lE P9f3566MCZc+5W/Hv2dw0yPZJnydKKKMu9w4Y15XXGGVnTijkB325Oa4iTa0Eqq3Vhc2 HNafdpQBNau5Ozpqdw/wliKSjNEGqYnagjhUINKglURE0DKsdbLXy+UI53bfjCo3V/v6 Z7jQ== X-Forwarded-Encrypted: i=1; AJvYcCUS2ZwCSVw+1CGJU5F7aO48B5A1liwYXftT+5JnbrsX2OHCF86q8n/E/REvr8JZW0NcbdUK0g==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxlb6C1NslGE8ChNsVj8SDVUDvk/NPzS0GH+Q08uZzhXVVikfvS 0incrPOosjd04ajUOezTprEj/LrxzdgX9wxknesK1+vVhv2hd6nqqFy7/mRI26wJ/+PTwwd5DQT ijyH4JxHcT8lC4raK9cjiYSwUEIw= X-Gm-Gg: ASbGnct7QGsN2KOqaq4wDcuHN0U0uZHmXZyU7dAuniPmlI6uAxP4O+fjSoA10OtcftT KeVndAQczBYtLfsU3z/e8xmZYmmBfaGLFYOiNkmQ= X-Google-Smtp-Source: AGHT+IHAPqGWR5Mdh0GRVcBaFLC2T7IT+ukr2NApPK7SOSFEqqZ+p3N2TGnjH0B+5q3xdqGzgyAgzbOoJVIh5OnT750= X-Received: by 2002:a05:620a:2901:b0:7b6:dd9c:fabe with SMTP id af79cd13be357-7b9ba74f084mr7726444085a.19.1735808206176; Thu, 02 Jan 2025 00:56:46 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298153 Archived-At: --0000000000008705e4062ab55765 Content-Type: text/plain; charset="UTF-8" > > > >> > This updates heex-ts-mode to use font-lock-string-face to be > consistent > >> > with html-ts-mode on attribute values. > >> > >> Should we install this change on master or emacs-30? Eli, Yuan, WDYT? > > > > Are we all in agreement with the change itself? Why should an > > attribute be highlighted as a string? > It's the value of an attribute as in
. It matches html-ts-mode which I believe is more correct. --0000000000008705e4062ab55765 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

>> > This updates heex-ts-mode to use font-lock-string-face to be = consistent
>> > with html-ts-mode on attribute values.
>>
>> Should we install this change on master or emacs-30?=C2=A0 Eli, Yu= an, WDYT?
>
> Are we all in agreement with the change itself?=C2=A0 Why should an > attribute be highlighted as a string?

<= div>It's the value of an attribute as in <div attribute=3D"attr= ibute_value">.=C2=A0 It matches html-ts-mode which I believe is mor= e correct.
=C2=A0
--0000000000008705e4062ab55765--