From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Wilhelm Kirschbaum Newsgroups: gmane.emacs.bugs Subject: bug#67246: 30.0.50; elixir-ts-mode uses faces inconsistently Date: Fri, 23 Feb 2024 17:05:06 +0200 Message-ID: References: <87y1ewgnn7.fsf@gmail.com> <9ae8eb33-fd8b-f8d6-dd7f-79f8d4464a51@gutov.dev> <87a5r2p4pq.fsf@gmail.com> <87bkbfkr1h.fsf@gmail.com> <22ea1559-f44e-933d-e60a-9caa62b376a8@gutov.dev> <878r69vow6.fsf@gmail.com> <95509dbc-7c71-4996-84f5-d37976e2661f@gutov.dev> <0d483c86-7e70-433c-8cea-15ac9238983c@gutov.dev> <627331b9-5759-43b1-a319-712c11ead2f6@gmail.com> <557bf51e-be4c-46c5-b2c5-8d06d28b7943@gmail.com> <2af6bb1e-8b14-4023-85a6-45dfba8be724@gutov.dev> <8bfeee68-44ce-49f8-a790-0a30457bed9d@gutov.dev> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004f662206120de34c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13538"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrey Listopadov , 67246@debbugs.gnu.org, Stefan Kangas To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 23 16:38:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdXcm-0003J4-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Feb 2024 16:38:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdXcH-0002YP-LZ; Fri, 23 Feb 2024 10:37:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdXQg-0007ND-He for bug-gnu-emacs@gnu.org; Fri, 23 Feb 2024 10:25:38 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdXQg-0003A0-97 for bug-gnu-emacs@gnu.org; Fri, 23 Feb 2024 10:25:38 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdXR3-0000vK-Q3 for bug-gnu-emacs@gnu.org; Fri, 23 Feb 2024 10:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Wilhelm Kirschbaum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Feb 2024 15:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67246 X-GNU-PR-Package: emacs Original-Received: via spool by 67246-submit@debbugs.gnu.org id=B67246.17087019223464 (code B ref 67246); Fri, 23 Feb 2024 15:26:01 +0000 Original-Received: (at 67246) by debbugs.gnu.org; 23 Feb 2024 15:25:22 +0000 Original-Received: from localhost ([127.0.0.1]:47790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdXQO-0000tg-F8 for submit@debbugs.gnu.org; Fri, 23 Feb 2024 10:25:22 -0500 Original-Received: from mail-qk1-f178.google.com ([209.85.222.178]:60600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdX8R-0008TX-B6 for 67246@debbugs.gnu.org; Fri, 23 Feb 2024 10:06:47 -0500 Original-Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-787b958b3f8so26435485a.0 for <67246@debbugs.gnu.org>; Fri, 23 Feb 2024 07:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708700718; x=1709305518; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QEaQjD1XfVZfzhRYuf3Z4UgxraqLLmVMq9/xY/MHGZ0=; b=GKkFnclObfbJIqsit6YLI2H0XjW8st/JVvux0++OguIuKC2M10tsv9jNKxrqofT93l xWHSwisj0k7g70q/v077Yh0MGMACDxRbNCk3LqSCnqwfg0ro22YSkRk8kR2oSFo1apem ZqOuJ7l+yu6D9mbGl4/ILiBfx4c6LTTitm4tti4DNF7EthuuMYhqXtcyjNitvjIhu2td zDw89HCA0fn7o6qzqMzK2IyLcMsca/HrRb6ZY3/AyOMe2ZBN76LAwMsdSJa3TZqaSds8 uZra6utSyFToj5tOy7j+Vu/dUkeYr10l7QbKt6+VYL6Eucl4p6FT9q+laP63t4B8mapi TaYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708700718; x=1709305518; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QEaQjD1XfVZfzhRYuf3Z4UgxraqLLmVMq9/xY/MHGZ0=; b=dEaJiETq4RychbVyW29ot9eMpuu0RC8AzBJLq46i021xTGNtkPaGTwyHOiVe0x/EqY FJr0BxJHyYnA4Mwq8LlweMEsRHywdh/9A2LjhHaYJhkNOtJyW0ZI+26Uo/APUvdac5m3 9pWEW751A9DB7O6yIBXWlzlzPKYLEIO35acLpoMPnE28CqlDaOZitENFbR8fytKA+wgm uUHrMqD5fDbVHdb2ZSuKG44y/P7Cf3Knx+e4P7M7F675fkFaJS8R7hV1CysnOS30o1z9 l84qHl+JvurxtVHlONTM3ckz5tdSEZy/Had3Ndc4ZRuk63o85FgClJYsrHk+J73tnm/k KBiQ== X-Forwarded-Encrypted: i=1; AJvYcCUNmtWimI8X9U1O4mJctCxhOUIQQm9F7mzJ9DSDaergm1L6U+XQOmZJVxUTtfdY6o7WBaXCeB3mgk9e51Exj8sLyfrGi+o= X-Gm-Message-State: AOJu0Yyf0750p+d211RkvFSJVUvz6DxeL005JTXnnCmwMbnfqwhf0wbr wL5MR78G/27HTYO1Do6URFiaceOINRxfZp3a4SI7fzTUzafHeySDnlYXMWppyRDl83cOom75t35 eK6QIB7u7Ix+UaFh2xXoReuWI7os= X-Google-Smtp-Source: AGHT+IEsLrU0k08QF+Rv60Z3RLxb63xfV9oULvPJYuvfcBygjkOt8Kpek9d0gfa2j22XaDMiWSTVkv5XSyxrRDSktmY= X-Received: by 2002:a05:620a:1652:b0:787:93a2:5b88 with SMTP id c18-20020a05620a165200b0078793a25b88mr83264qko.44.1708700717768; Fri, 23 Feb 2024 07:05:17 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280498 Archived-At: --0000000000004f662206120de34c Content-Type: text/plain; charset="UTF-8" > On 05/02/2024 22:51, Dmitry Gutov wrote: > > On 05/02/2024 19:47, Wilhelm Kirschbaum wrote: > >>> Could you give an example of problematic highlighting, though? So I > >>> can keep it mind when installing both changes. > >> Of course, sorry: > >> > >> def boo(:one), do: :boo > >> > >> highlighted boo as function-call-face, not function-name-face. Same with > >> > >> > >> def foo("boo") do > >> > >> end > >> > >> > >> and variants. > > > > Thanks! Now I get it. > > I've now pushed the two your patches and one of mine. > Thank you > > Not closing the report yet because you said some problem with function > calls remains, right? > Yes, one more with function calls and one issue with else blocks, where the wrong font gets applied. I will attempt a patch next week. --0000000000004f662206120de34c Content-Type: text/html; charset="UTF-8"

On 05/02/2024 22:51, Dmitry Gutov wrote:
> On 05/02/2024 19:47, Wilhelm Kirschbaum wrote:
>>> Could you give an example of problematic highlighting, though? So I
>>> can keep it mind when installing both changes.
>> Of course, sorry:
>>
>> def boo(:one), do: :boo
>>
>> highlighted boo as function-call-face, not function-name-face. Same with
>>
>>
>> def foo("boo") do
>>
>> end
>>
>>
>> and variants.
>
> Thanks! Now I get it.

I've now pushed the two your patches and one of mine.

Thank you

Not closing the report yet because you said some problem with function
calls remains, right?

Yes, one more with function calls and one issue with else blocks, where the wrong font gets applied. I will attempt a patch next week.
--0000000000004f662206120de34c--