From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Liu Hui Newsgroups: gmane.emacs.bugs Subject: bug#68559: [PATCH] Improve Python shell completion Date: Sat, 17 Feb 2024 12:36:12 +0800 Message-ID: References: <6BAFD8BF-8F18-4D9F-9DB3-A185AEF2EBCA@gmail.com> <8B4172D0-FC31-4437-99C4-683C892C5F86@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Eli Zaretskii , 68559@debbugs.gnu.org To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 17 05:38:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rbCSo-0001mw-Cw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Feb 2024 05:38:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rbCSO-00054m-Vi; Fri, 16 Feb 2024 23:37:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbCSN-00054C-DS for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2024 23:37:43 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rbCSN-00062v-5h for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2024 23:37:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rbCSg-0007kA-Dn for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2024 23:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Liu Hui Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Feb 2024 04:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68559-submit@debbugs.gnu.org id=B68559.170814467229751 (code B ref 68559); Sat, 17 Feb 2024 04:38:02 +0000 Original-Received: (at 68559) by debbugs.gnu.org; 17 Feb 2024 04:37:52 +0000 Original-Received: from localhost ([127.0.0.1]:60338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbCSW-0007jn-9f for submit@debbugs.gnu.org; Fri, 16 Feb 2024 23:37:52 -0500 Original-Received: from mail-oa1-f44.google.com ([209.85.160.44]:59412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbCSS-0007jY-Tc for 68559@debbugs.gnu.org; Fri, 16 Feb 2024 23:37:50 -0500 Original-Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-21e6be74db4so643288fac.2 for <68559@debbugs.gnu.org>; Fri, 16 Feb 2024 20:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708144583; x=1708749383; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wmd8/etpxflQbgT7n9ML5A3g5gWnT70/2s0dW1GuJno=; b=iWZZddzar73K5ET6WzCc13SmXJuNf2U7KbWnjIn8UiDSV2pvTRTfzBAMC4Dg+wOyNS PSgzVfQwM8WjBBNyPwjZ1m5aKiDAgbyBTKwHF+v11S3XZTBOF6KrU0i5u6zfFBx8a1ig L1NrvMeTaZP4+iTe1JxzdaTWQnU3LVEFD99lCTO66HmUaTclB47mofdjR8XlH3ENE5RE 36ZgE5DdrMYINQIbyeWWKFbAC4wbZlaHM5bud4nEcMtavvMHRv0TEbNFmFiGDrj2tta2 KF/6sLlpuCS+/awUT+i81qwdx6sK8Vvg/4/CoIUA05COh0X3Thlv5IxwcYMBhIzp9H9n ShkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708144583; x=1708749383; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wmd8/etpxflQbgT7n9ML5A3g5gWnT70/2s0dW1GuJno=; b=mdMbvUhEn3BFD+1pGAnJSHGKdk2EPB5efgqoxPOuISGLo60KzCv4pbvgUcWpnTymSl hbtEIv6OxAFYeOE26BPfxUubWQS6CcyrWNia6VFCt/y5OCvldGCUSri0ECLhJHNRy9MQ Z5BCsaN0fityxBSyhMP7JU/2u/i3yQ3XExLFCIYnbSyDz3u8/C/Br+7xSoLF16yCo9sb Vb5dji5VJluW7u+Pg4vdGH4VI6g7hDENv7bGUS5wN6ek9pDbXvGD+JPXRbzbtkeAxy7v 4DiRCrljlmff+j6JbHw6yW5TXDNz8pf5NSwCuvpFo5sF5UhP+24kJqdIJSSHmXTR5REB NqYg== X-Forwarded-Encrypted: i=1; AJvYcCXsaTa9uygkRmpJBzlfijtHZyqm1ScYYN+1A9sToQAYZOIGOnC3fZmU9L8s5KF9tkIIJbDsNMgK3golx1mmtzTxmddL0v0= X-Gm-Message-State: AOJu0YySZJ+CDF3NID/nqYW3izuE+9GanJ4Ty6W2xNj8ryKVjlVONV7g 7acXdwjup9wUHiSzq/XfVTVLa1ChZocLFTQccZWSw3OKW9BznaZ0MXl1IV60F88tjHip3qGbU7+ MwsuiFLj7tSfg0XY68WmB7LLM+4M= X-Google-Smtp-Source: AGHT+IEJ0X0eE9GSh7rVCpqb/G35RZUmPR4YWUNL+CvcEOkQmtCqyGxDYwzaMW++xptQAoLTBGZhwWqckxt/w0IYOO8= X-Received: by 2002:a05:6871:28d:b0:21d:fd20:c516 with SMTP id i13-20020a056871028d00b0021dfd20c516mr7471689oae.6.1708144583325; Fri, 16 Feb 2024 20:36:23 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280111 Archived-At: kobarity writes: > 0001-Set-tty-mode-to-raw-when-setting-up-Inferior-Python.patch sets > the Inferior Python tty to raw mode. python-ffap-module-path-1 will > no longer need to be skipped on Mac. If it is safe to set tty to raw > mode on all UNIX based systems, I prefer this method. How about the following change, which only affects libedit-based readline? It may enable native completion on mac, but I cannot test it. diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index b7e43f3fc68..f59bc19367b 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -4286,6 +4286,9 @@ (defcustom python-shell-completion-setup-code except: pass else: + if readline.__doc__ and 'libedit' in readline.__doc__: + import tty + tty.setraw(0) # Try to reuse current completer. completer = readline.get_completer() if not completer: @@ -4471,8 +4474,8 @@ (defun python-shell-completion-native-setup () instance.rlcomplete = new_completer if readline.__doc__ and 'libedit' in readline.__doc__: - raise Exception('''libedit based readline is known not to work, - see etc/PROBLEMS under \"In Inferior Python mode, input is echoed\".''') + import tty + tty.setraw(0) readline.parse_and_bind('bind ^I rl_complete') else: readline.parse_and_bind('tab: complete')