From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Liu Hui Newsgroups: gmane.emacs.bugs Subject: bug#63411: [PATCH] pcomplete/systemctl cannot complete units for old versions of systemd Date: Thu, 18 May 2023 21:29:46 +0800 Message-ID: References: <83edndx6qq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25957"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63411@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 18 15:31:58 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzdjZ-0006WN-S1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 May 2023 15:31:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzdj7-0004r2-Qp; Thu, 18 May 2023 09:31:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzdiz-0004pF-UY for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 09:31:22 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzdig-0006Is-Dg for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 09:31:18 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzdig-0001iG-9p for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 09:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Liu Hui Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2023 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63411 X-GNU-PR-Package: emacs Original-Received: via spool by 63411-submit@debbugs.gnu.org id=B63411.16844166086418 (code B ref 63411); Thu, 18 May 2023 13:31:02 +0000 Original-Received: (at 63411) by debbugs.gnu.org; 18 May 2023 13:30:08 +0000 Original-Received: from localhost ([127.0.0.1]:52700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzdhn-0001fR-Uo for submit@debbugs.gnu.org; Thu, 18 May 2023 09:30:08 -0400 Original-Received: from mail-oi1-f170.google.com ([209.85.167.170]:49270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzdhj-0001eZ-UZ for 63411@debbugs.gnu.org; Thu, 18 May 2023 09:30:06 -0400 Original-Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-38ede2e0e69so1119887b6e.2 for <63411@debbugs.gnu.org>; Thu, 18 May 2023 06:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684416598; x=1687008598; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RNIBt3/oxVdG0nGHPXD1KH573b1blqGnDdUhF4bEFlo=; b=W96n6bDsJfcGUSrcc1qER3MZy3V2tKJpeChQEA+SIly0kvwX/FGIsVm1Q8K/4XxZz5 xTzoRL7cZ6EwljvCR32GDYIFKPXjPmH40H66OlAIEaW/7Lcmg9ZfWyfFceSK7epXeZvt fj08nWu1Dl1fqw/FM6P80aDLK7MiRLXH6rGidRQQj+mpAcRQRbPs0JZdkiCJpgo91aT2 3AFstvx5dYM3NiupY2RR4l+/tay48LkQDqeG+qHAJTqPGwkFz8BjHmryRd0MupKRIrHn vmn1uTecmLm7zx+WEVw7+RwkR9gzQxxk9YZpkaF2U0qHtTKnhdZo5dRs/CD3vhoKUmPv vi2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684416598; x=1687008598; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RNIBt3/oxVdG0nGHPXD1KH573b1blqGnDdUhF4bEFlo=; b=D8/vW1nx3F+5spF20iX2uVE48yAUD6rPtqWqdgwoYS8Fy5ME81nigfzJ+4osQREJqN osw6aZra0j0Vl//Oqr7T+tEDYhkO7b8lEGSmKXzbfS53+GzOmZqwIXgoLGhWrOfIj6Ax q856Q3dLlykVG7AO5RHD3WJqJtWpR79+TWeKp3v5YcXpRZ3qKZpoCr+ZTB5t5x+qRU/h KypeeIjCon+a7xFF5R+l1IlxxpwmjAlhRTJjVNxKnmDyL/k1CuCmJ5loBJ/Mz30UCgij 1v2Ss+ZA9tsHH+8Glp2RVuhWA6NPDO2hMXb+6cVNViz8ne58DuXXwJfao39BvUkoqaDm msDg== X-Gm-Message-State: AC+VfDwNBWdmiT6N1ns+RSl2lrlw55fektmcVH53NMVQLPBwipmmrHNv mqULTxxDplpTAhpRTiH+zIqG75ZrYlAjo0BOhIhHZVCdYy1Kvw== X-Google-Smtp-Source: ACHHUZ4pNzojxttjpKrGkdidDnMVn/AQLSNO92WyKixNvAP+IEgYtHLFmRMrq0y1WztOm4xgZnv+u4mWBHSYtJizPsU= X-Received: by 2002:a05:6808:1791:b0:396:4a74:f452 with SMTP id bg17-20020a056808179100b003964a74f452mr1376621oib.14.1684416597947; Thu, 18 May 2023 06:29:57 -0700 (PDT) In-Reply-To: <83edndx6qq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261928 Archived-At: > I'm not an expert on systemctl; would someone who uses that please > tell if this could have any downsides? E.g., is --no-legend expected > to be deprecated, perhaps resulting in a warning message or something? > If not, why did the systemd developers add another option with the > same semantics? --no-legend is indeed superseded by --legend=yes/no in systemd v248+, but it is not deprecated. It is kept for compatibility and is totally equivalent to --legend=no, and doesn't produce any warning message. I have tested with systemctl v249 on Ubuntu 22.04 and the outputs are same. In fact, the point of the new option is it allows to display legends by --legend=yes in spite of other options such as --quiet, which is explained in https://github.com/systemd/systemd/pull/18596. Another simple solution is adding a variable, e.g. pcmpl-linux-systemd-list-unit-arguments, to allow users to change options passing to systemctl. WDYT?