From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ethan Newsgroups: gmane.emacs.bugs Subject: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally Date: Sun, 6 Jul 2014 00:27:39 -0400 Message-ID: References: <87wqbrllwr.fsf@betacantrips.com> <83fvifehjh.fsf@gnu.org> <83egxzdx35.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b4184418a8afb04fd7ec820 X-Trace: ger.gmane.org 1404620966 6437 80.91.229.3 (6 Jul 2014 04:29:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Jul 2014 04:29:26 +0000 (UTC) Cc: 17947@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 06 06:29:14 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X3e4g-0001n6-2m for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Jul 2014 06:29:14 +0200 Original-Received: from localhost ([::1]:44657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3e4f-0007Qi-L9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Jul 2014 00:29:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3e4Z-0007QY-2r for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 00:29:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3e4U-00061K-Ob for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 00:29:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3e4U-00061G-LJ for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 00:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X3e4T-0004Jg-Uc for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 00:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ethan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Jul 2014 04:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17947 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17947-submit@debbugs.gnu.org id=B17947.140462088816505 (code B ref 17947); Sun, 06 Jul 2014 04:29:01 +0000 Original-Received: (at 17947) by debbugs.gnu.org; 6 Jul 2014 04:28:08 +0000 Original-Received: from localhost ([127.0.0.1]:44453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3e3c-0004I9-0H for submit@debbugs.gnu.org; Sun, 06 Jul 2014 00:28:08 -0400 Original-Received: from mail-vc0-f176.google.com ([209.85.220.176]:58086) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3e3Y-0004He-R6 for 17947@debbugs.gnu.org; Sun, 06 Jul 2014 00:28:05 -0400 Original-Received: by mail-vc0-f176.google.com with SMTP id ik5so2720423vcb.35 for <17947@debbugs.gnu.org>; Sat, 05 Jul 2014 21:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=l9MWsg3ZickHYPzQbrWfAe7s5+PuOjL/uhHt+EO0nsI=; b=pxk8Q8WP7YteYySvkn+jPZbBjsBPq4tbmoT4wytp/BXXZhbLJt0etnoZL6c8BraWDo 6Pabpqnyez0m6nJHnLtOVrPLeNKxeerdVJLaLiBFQujAJSDgE7XTQW+OceJNgo79FtcO dgQ/kKl72OVzuWX37l0aU8uX0K+LuzebNtoWCjEr3Un1vQoh23YAbAspiMtsaS/ohMxU hhYO6IOkOJhMGvrHgKjNM/MhAHshih90LAAaBA5FOUkQtQsfM2PZUWOvrXY51RXIQSOK GBUE7Z+OqvdHEKih0LGxswsOnCT5MYGq6SALxoNsUM0MXqVxM63pZSGVw6N/NmLcBWXt s1Ew== X-Received: by 10.58.12.73 with SMTP id w9mr19622828veb.13.1404620879069; Sat, 05 Jul 2014 21:27:59 -0700 (PDT) Original-Received: by 10.58.142.3 with HTTP; Sat, 5 Jul 2014 21:27:39 -0700 (PDT) In-Reply-To: <83egxzdx35.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91230 Archived-At: --047d7b4184418a8afb04fd7ec820 Content-Type: text/plain; charset=UTF-8 Hi Eli, if you are happy with the behavior of require-final-newline, then that's fine and I don't believe you are likely to want to use ethan-wspace. The point of the warning is to make it clear to a user that you can use ethan-wspace, or require-final-newline, but not both. The point of the bug report is merely to ask that if a user wants to use ethan-wspace and not require-final-newline, that they be able to do so. Thanks Stefan for the quick turnaround on the patch and the context for why the code is the way it is! Ethan On Sat, Jul 5, 2014 at 10:45 PM, Eli Zaretskii wrote: > > From: Stefan Monnier > > Cc: 17947@debbugs.gnu.org, ethan.glasser.camp@gmail.com > > Date: Sat, 05 Jul 2014 19:02:05 -0400 > > > > >> > One user reported that ruby-mode triggers this warning. Sure > enough, in > > >> > ruby-mode.el at line 287, I see: > > >> > (set (make-local-variable 'require-final-newline) t) > > >> Removed in the `emacs-24' branch. > > > Regardless of what this or that mode does, I think it's wrong for > > > ethan-wspace to annoy users for having require-final-newline set > > > non-nil. > > > > It's his package and he's free to do what he wants with it, I think. > > Yes, he is. Which is why I said "I think". It's an opinion of an > Emacs user who has this variable customized since about forever, and > would find it annoying to be annoyed by such warnings. User who > customized this variables clearly tell that they want to be in control > of the final newline, so packages that look at that shouldn't. > --047d7b4184418a8afb04fd7ec820 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Eli, if you are happy with the behavior of require-fina= l-newline, then that's fine and I don't believe you are likely to w= ant to use ethan-wspace. The point of the warning is to make it clear to a = user that you can use ethan-wspace, or require-final-newline, but not both.= The point of the bug report is merely to ask that if a user wants to use e= than-wspace and not require-final-newline, that they be able to do so.

Thanks Stefan for the quick turnaround on the patch and the context for= why the code is the way it is!

Ethan



On Sat, Jul 5, 2014 at 10:45 P= M, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: 17947@debbugs.gnu.org= , =C2=A0ethan.glasser.camp@= gmail.com
> Date: Sat, 05 Jul 2014 19:02:05 -0400
>
> >> > One user reported that ruby-mode triggers this warning. = Sure enough, in
> >> > ruby-mode.el at line 287, I see:
> >> > =C2=A0 (set (make-local-variable 'require-final-newl= ine) t)
> >> Removed in the `emacs-24' branch.
> > Regardless of what this or that mode does, I think it's wrong= for
> > ethan-wspace to annoy users for having require-final-newline set<= br> > > non-nil.
>
> It's his package and he's free to do what he wants with it, I = think.

Yes, he is. =C2=A0Which is why I said "I think". =C2=A0It&#= 39;s an opinion of an
Emacs user who has this variable customized since about forever, and
would find it annoying to be annoyed by such warnings. =C2=A0User who
customized this variables clearly tell that they want to be in control
of the final newline, so packages that look at that shouldn't.

--047d7b4184418a8afb04fd7ec820--